From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 3FCF1388803B for ; Thu, 24 Jun 2021 13:52:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3FCF1388803B Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15ODlGs8003114; Thu, 24 Jun 2021 13:52:47 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 39c2wnk2gg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jun 2021 13:52:46 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 15ODjku2029457; Thu, 24 Jun 2021 13:52:45 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2103.outbound.protection.outlook.com [104.47.58.103]) by aserp3030.oracle.com with ESMTP id 3996mgkea3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jun 2021 13:52:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZuCf5t2bu9A9Sl2koNn+1wYh3g0JIXv9meDxY+YgNTGj0erv+MZDh+luSLqCUzQ/lVuxf8Ce7IbK3+ZQDaglsXVDLIGt+JE7UK0SQ2/z7ArW339hjBaG/0GQzzO2QdsPmLNiUexK4P3I4iOMHntkzoTBgxcEuSQkmVVZ1ROV8KdRTSxHyovBK1BDX5KGLyTupQGqaLdSD0JnJLUSmOov3GaIvOClNIWpDaqgntVKCA209sEKnnz7FQgoTFY1F2Qo4UO/GTr6dz9lhuzTzWy0Llv6sqZ+NFCrW4ibBNDY23c3QHyE/auHmH6SfB4I7MDWLdlrYOwWp+ODOdGpAe/vkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Xx+npGihYFiM1U5f2ZVLxWfKjflufT+nQg7ynJOo4Q=; b=jRdrgi5AUVgVKrwLrImeaH95P5VL2sbvGYVacbnEbwpObRPEzCZQCHATbFWxWu44x6zKeT5gL3deVtbypQ8LQC2rMELN7uSoPAXUju5TmKD+aKS7dMxaP+giRVAngbixn0xTBO5rLRzAAzlxhjnJUWv4ZwfLbpHnwYBGLfOqvIsDY/oEJmd9mx3dewiya5AlP5M9QcmZVKgrEeqn/sUt/Ns0YyKGKhlgTI+HqUg8BU+rKt5eOBFiqC6cf2mIXUgIWAQbLLKkLFC1NRlgph/oggqotHUG7dAxTw9hTIryXWg7nh7u/Dl0W0ZCq+oScooGZ5OqVMOCJATpTTwEjuepDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from DM5PR10MB2041.namprd10.prod.outlook.com (2603:10b6:3:111::16) by DM6PR10MB2457.namprd10.prod.outlook.com (2603:10b6:5:b4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Thu, 24 Jun 2021 13:52:44 +0000 Received: from DM5PR10MB2041.namprd10.prod.outlook.com ([fe80::14a9:31e9:48af:5e4f]) by DM5PR10MB2041.namprd10.prod.outlook.com ([fe80::14a9:31e9:48af:5e4f%8]) with mapi id 15.20.4242.023; Thu, 24 Jun 2021 13:52:43 +0000 From: "Jose E. Marchesi" To: Jason Merrill Cc: gcc-patches@gcc.gnu.org Subject: Re: [[PATCH V9] 1/7] dwarf: add a dwarf2int.h internal interface References: <20210531165802.5686-1-jose.marchesi@oracle.com> <20210531165802.5686-2-jose.marchesi@oracle.com> <490dc110-f55a-f7f3-2a03-c0f75454a7ae@redhat.com> Date: Thu, 24 Jun 2021 15:52:25 +0200 In-Reply-To: <490dc110-f55a-f7f3-2a03-c0f75454a7ae@redhat.com> (Jason Merrill's message of "Tue, 22 Jun 2021 16:05:04 -0400") Message-ID: <87a6nfmkti.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-Originating-IP: [141.143.193.68] X-ClientProxiedBy: PR3P189CA0025.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::30) To DM5PR10MB2041.namprd10.prod.outlook.com (2603:10b6:3:111::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from termi.oracle.com (141.143.193.68) by PR3P189CA0025.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Thu, 24 Jun 2021 13:52:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 193683a8-95bc-4410-e18f-08d937175748 X-MS-TrafficTypeDiagnostic: DM6PR10MB2457: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uy5cBEAiEOxUQ8yYx8n3FNNNQG0Pe8Tv2A3wEJYCKnq4nDj5ABW2s34NJUwM7OVF2Jzu2bc9NlFeAMhl1zwcSPdkr6nUwAy+5uWG5SQFFzQkxeuK8ui5Sg38k6wNXSxE1ml1wfEOq6jpT0OB+jhDKfptCRnddw/06xKH68+daj9LEzlu2rZUH2evXe01XyVBzTyTF3OzuBlvxfvHqv0ls17j2lKo2a5HegP+ip+0cOmr2VS7kbHaKVnQP+9Wq1nsFTccHZJ+XD0ZGZdHwfFdfkjUus1w0aWZMBaDXb0n31HspLPJEOQt/m+hG7xJC9k+yS8X4kPXG4mzG4dvCGYWFRxpQ4/vDWNMVnQOKXLvD/VhLbpgZzcVA7hEUfzXgkvcCV3aZLpSPrKaYq37kjwjp/rHWIpAyrTbC4y5WYCbdevtjm25B9j2vRSLMI2pDItTGwPQFUI/uo/X6qCY7Bk1owDZ9wPGFJyBLVIy5uGQz26vV9wpv2A9yPjwvngD/hcyRuxac4QKapl+BGkXN9u7ARU8sEFSA1vdcDt7KNS0BgpVHnJxAhrOM0z3aYesmM2Tgcb67Pk+bpvNBOmxT6MUmVrZHbL7yavsi3RXTMws5yNStD7vhRS5l8K0gMTuRw5qv2MQeyOEJoh9A1SQyZIuJfg/Vs1yzI1+caFYAO4h6Uw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR10MB2041.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(346002)(396003)(366004)(376002)(39860400002)(26005)(66946007)(186003)(83380400001)(16526019)(2906002)(38100700002)(53546011)(66476007)(66556008)(38350700002)(7696005)(52116002)(6666004)(6916009)(5660300002)(36756003)(8676002)(86362001)(4744005)(4326008)(478600001)(316002)(8936002)(2616005)(6486002)(956004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LJWstQIdulSDOxQil/VYKyWizgKjy1eb1YcVk0Atmng/hGwXjeoLhTGgEoKk?= =?us-ascii?Q?OoOASnscKuY8KzO6U4FU11NfM2ZL03FKhMyieNGNzHLtawfZjsuPrpQK0Z/4?= =?us-ascii?Q?wypBkybLIY1F7iwq2q3gIcGUDrnrhP5g66QjUXu1cv0VjfiT7fbhACdERB11?= =?us-ascii?Q?7k/FTN68leQiJ9Mh+VzpkxLpj0z5NaeEZQjqnLxuJAE6El9x/NpQDiX3JkKG?= =?us-ascii?Q?puQH+n76bwGYx8oMlHoowsMwG8JTTQ7gAaf4F1TxCjokAaf0SkND1oGV/0oI?= =?us-ascii?Q?6Y5qWSd//+bTI1Xoql2cPnfx+iFJrKW5F+Kf3wz92U5uoVQIdqqElz7+/V5m?= =?us-ascii?Q?QII5Z27oXvcGzW1XpuGSGtdZ2fPE1DGRSOB4aZU0W4BPLGJzS6FGDhs1Plyl?= =?us-ascii?Q?BU4Kdao8JE1T4sY1bIWpX8tE2vSOBBGKrSdIVQAzZPyOpZx7iQl8RkbTjeyT?= =?us-ascii?Q?f+NX9ZvrAAD5L5R0ntsGziKoWJYtw51Cn2cCyyGTPCrbeMaZVCaA7WfhXJ7n?= =?us-ascii?Q?9SL0DpfySwhJT4mm1tKVdKV/rKgVJUQN9vQXo1M+q7bSX4h0k5SqSiOiUdT8?= =?us-ascii?Q?ksl8z/yOFwMT7b19/460ZbuIgDOkqEOHKHrWgOrpncjZYW+YWkgTLD4xH0H2?= =?us-ascii?Q?rJSwISpJBjgAKHO0V37Ywz5CK4D94Zl3am+3oloWUv2FkuRQUkUOVi97FZSh?= =?us-ascii?Q?opEpsyL6LCOllAuvvkjAGSRvKkSB+9bkHhhbxMl3GTIZn4lf9OIusvJceQYm?= =?us-ascii?Q?9zr8bzV6w05FNds6LeGfAI0+sJmzIrLKb6D3vOLvRiBqhHL2IomAQ8PZ2tGs?= =?us-ascii?Q?M/C/4B5L6f9muLN4bl7kZ76QUHLFZx6EGJaskzGhU4hdP59TXq/55ftWJ6jN?= =?us-ascii?Q?/QluUxZg0GdGGq38lELlwgHzLUnhE5AIXcd+Fz95HSI5U1WF6HvUIWClhnaJ?= =?us-ascii?Q?FK0CdOQopNaKQLA70OeSrvuL3b3rIdHsxd86c6dESqgXttilHc3NkfjBXO+K?= =?us-ascii?Q?ZvzNGPvWs70tbP2bMdx4FdoLkacITFvV9q8mKmQJZ6MAFwzsl24y8uC3Xw0l?= =?us-ascii?Q?f47xIn09+cCr4bSKSYqnynkGUXEuBTQxOCHnSkmPkiwX4yiTyNFIsWdoX7jt?= =?us-ascii?Q?OEjuw4XnsNcvGWdu2rcXovcOtteJ5d8prhqKXO4e4aHT23wjTaJUVqyo9J2/?= =?us-ascii?Q?t0lQqM4Ao6JoCErZNy2qgr+q1cyA0Q1pHWCZlYgoJKmIfE4hDmftRvE15OGj?= =?us-ascii?Q?bHN/F/FJra/Hpz1RFsQ3k54sRa99kKKd9RAp/Rihs5Upp/R7S8OVpD1YWm89?= =?us-ascii?Q?qzv3Ha6/lOOgc3lTkU4PkIXS?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 193683a8-95bc-4410-e18f-08d937175748 X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB2041.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2021 13:52:43.9374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5CbRy6lP+VwTR1Y9XDBfqJD2XG9KRZK1bfaInZJQFBRv4T1FLcdC2+++d/RH9G86us0Y8jnvM8Nyxl5zd1/0LNSk5qtyYlavPUAu6LsnFD8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2457 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10024 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 mlxscore=0 mlxlogscore=816 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106240076 X-Proofpoint-GUID: PoHcWyd6HlgfHWPmUAgutBCxaN6bsDrV X-Proofpoint-ORIG-GUID: PoHcWyd6HlgfHWPmUAgutBCxaN6bsDrV X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2021 13:52:50 -0000 Hi Jason. > On 5/31/21 12:57 PM, Jose E. Marchesi via Gcc-patches wrote: >> This patch introduces a dwarf2int.h header, to be used by code that >> needs access to the internal DIE structures and their attributes. > > Why not put these bits in dwarf2out.h? We think that it makes sense to have a separated interface file for the implementation of DWARF-based debug formats. It is called `internal' because it provides access to internal data structures as well as the basic accessor functions to the internals of the DWARF DIEs. That said, if you think this is a blocker, we can put these definitions in dwarf2out.h. But we think dwarf2out.c is in much need of some refactoring, and this could be a first step in that direction :)