From: Richard Sandiford <richard.sandiford@arm.com>
To: Alan Modra <amodra@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] genattrtab bit-rot, and if_then_else in values
Date: Thu, 03 Jan 2019 12:41:00 -0000 [thread overview]
Message-ID: <87a7khsyjz.fsf@arm.com> (raw)
In-Reply-To: <20190103092154.GZ30978@bubble.grove.modra.org> (Alan Modra's message of "Thu, 3 Jan 2019 19:51:54 +1030")
Alan Modra <amodra@gmail.com> writes:
> + case PLUS:
> + current_or = or_attr_value (XEXP (exp, 0));
> + if (current_or != -1)
> + {
> + int n = current_or;
> + current_or = or_attr_value (XEXP (exp, 1));
> + if (current_or != -1)
> + current_or += n;
> + }
> + break;
This doesn't look right. Doing the same for IOR and |= would be OK
in principle, but write_attr_value doesn't handle IOR yet.
OK with the above dropped, thanks.
Richard
PS. current write_attr_value doesn't seem to handle operator precedence
properly, but that's orthogonal.
next prev parent reply other threads:[~2019-01-03 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 9:22 Alan Modra
2019-01-03 12:41 ` Richard Sandiford [this message]
2019-01-03 14:36 ` Alan Modra
2019-01-03 17:08 ` Richard Sandiford
2019-01-03 19:04 ` Richard Sandiford
2019-01-04 0:20 ` Alan Modra
2019-01-04 12:18 ` Richard Sandiford
2019-01-06 22:36 ` Alan Modra
2019-01-07 12:10 ` Richard Sandiford
2019-01-07 22:31 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7khsyjz.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=amodra@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).