From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117545 invoked by alias); 30 Nov 2018 20:42:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117534 invoked by uid 89); 30 Nov 2018 20:42:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=allocatable, sk:138bc75, git-svn-id, gitsvnid X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Nov 2018 20:42:49 +0000 Received: from svr-orw-mbx-02.mgc.mentorg.com ([147.34.90.202]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gSpcd-00023R-CO from Thomas_Schwinge@mentor.com ; Fri, 30 Nov 2018 12:42:47 -0800 Received: from SVR-ORW-MBX-09.mgc.mentorg.com (147.34.90.209) by svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 30 Nov 2018 12:42:45 -0800 Received: from tftp-cs (147.34.91.1) by SVR-ORW-MBX-09.mgc.mentorg.com (147.34.90.209) with Microsoft SMTP Server id 15.0.1320.4 via Frontend Transport; Fri, 30 Nov 2018 12:42:45 -0800 Received: by tftp-cs (Postfix, from userid 49978) id A36DFC2222; Fri, 30 Nov 2018 12:42:44 -0800 (PST) From: Thomas Schwinge To: , CC: Jakub Jelinek Subject: Re: [PATCH, OpenACC 2.5, libgomp] Add *_async versions of runtime library API functions In-Reply-To: <53570e68-bd77-c55e-86e5-1f1e7eea271a@codesourcery.com> References: <4f2750a1-9935-6629-b7fd-ce6280f902c0@mentor.com> <53570e68-bd77-c55e-86e5-1f1e7eea271a@codesourcery.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Fri, 30 Nov 2018 20:42:00 -0000 Message-ID: <87a7lqthz8.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2018-11/txt/msg02599.txt.bz2 Hi! On Mon, 10 Sep 2018 10:22:17 -0700, Cesar Philippidis wrote: > On 09/10/2018 08:04 AM, Chung-Lin Tang wrote: > > Index: libgomp/openacc_lib.h >=20 > I don't see a test case for this. Right. (Better test coverage would be desirable generally.) > I believe that openacc_lib.h is used > by fixed-mode Fortran programs (those that end in a .f). Can you add a > fixed-mode version of lib-16.f90? Not only with fixed-form, but also with free-form Fortran programs. Committed to trunk in r266683: commit d084eb0a61d209ee0d852089ea76a672f519883b Author: tschwinge Date: Fri Nov 30 20:38:57 2018 +0000 Add libgomp.oacc-fortran/lib-16-2.f90 =20=20=20=20 This is a copy of libgomp.oacc-fortran/lib-16.f90, but does 'include "openacc_lib.h"' instead of 'use openacc'. =20=20=20=20 libgomp/ * testsuite/libgomp.oacc-fortran/lib-16-2.f90: New file. =20=20=20=20 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@266683 138bc75d-0d04-04= 10-961f-82ee72b054a4 --- libgomp/ChangeLog | 4 ++= ++ libgomp/testsuite/libgomp.oacc-fortran/{lib-16.f90 =3D> lib-16-2.f90} | 3 = ++- libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git libgomp/ChangeLog libgomp/ChangeLog index d3c1bc36c145..a9dcbd808200 100644 --- libgomp/ChangeLog +++ libgomp/ChangeLog @@ -1,3 +1,7 @@ +2018-11-30 Thomas Schwinge + + * testsuite/libgomp.oacc-fortran/lib-16-2.f90: New file. + 2018-10-19 Richard Biener =20 PR tree-optimization/88182 diff --git libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 libgomp/testsu= ite/libgomp.oacc-fortran/lib-16-2.f90 similarity index 94% copy from libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 copy to libgomp/testsuite/libgomp.oacc-fortran/lib-16-2.f90 index 9701b52dd257..fa76f65912fb 100644 --- libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 +++ libgomp/testsuite/libgomp.oacc-fortran/lib-16-2.f90 @@ -1,9 +1,10 @@ +! See also "lib-16.f90". ! { dg-do run } ! { dg-skip-if "" { *-*-* } { "*" } { "-DACC_MEM_SHARED=3D0" } } =20 program main - use openacc implicit none + include "openacc_lib.h" =20 integer, parameter :: N =3D 256 integer, allocatable :: h(:) diff --git libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 libgomp/testsu= ite/libgomp.oacc-fortran/lib-16.f90 index 9701b52dd257..011f9cf31db4 100644 --- libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 +++ libgomp/testsuite/libgomp.oacc-fortran/lib-16.f90 @@ -1,3 +1,4 @@ +! See also "lib-16-2.f90". ! { dg-do run } ! { dg-skip-if "" { *-*-* } { "*" } { "-DACC_MEM_SHARED=3D0" } } =20 Gr=C3=BC=C3=9Fe Thomas