From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-393550-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 79635 invoked by alias); 15 Mar 2015 20:23:22 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 79623 invoked by uid 89); 15 Mar 2015 20:23:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-wi0-f176.google.com
Received: from mail-wi0-f176.google.com (HELO mail-wi0-f176.google.com) (209.85.212.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 15 Mar 2015 20:23:20 +0000
Received: by wixw10 with SMTP id w10so19750797wix.0        for <gcc-patches@gcc.gnu.org>; Sun, 15 Mar 2015 13:23:17 -0700 (PDT)
X-Received: by 10.194.243.1 with SMTP id wu1mr118788605wjc.69.1426450997289;        Sun, 15 Mar 2015 13:23:17 -0700 (PDT)
Received: from localhost ([95.147.106.68])        by mx.google.com with ESMTPSA id q10sm12315041wjr.41.2015.03.15.13.23.16        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Sun, 15 Mar 2015 13:23:16 -0700 (PDT)
From: Richard Sandiford <rdsandiford@googlemail.com>
To: Maxim Ostapenko <m.ostapenko@partner.samsung.com>
Mail-Followup-To: Maxim Ostapenko <m.ostapenko@partner.samsung.com>,GCC Patches <gcc-patches@gcc.gnu.org>,  Yury Gribov <y.gribov@samsung.com>,  Slava Garbuzov <v.garbuzov@samsung.com>, rdsandiford@googlemail.com
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,  Yury Gribov <y.gribov@samsung.com>,  Slava Garbuzov <v.garbuzov@samsung.com>
Subject: Re: [PATCH PR64820] Fix ASan UAR detection fails on 32-bit targets if SSP is enabled.
References: <54D8860A.7010903@partner.samsung.com>
Date: Sun, 15 Mar 2015 20:23:00 -0000
In-Reply-To: <54D8860A.7010903@partner.samsung.com> (Maxim Ostapenko's message	of "Mon, 09 Feb 2015 14:03:54 +0400")
Message-ID: <87a8ze2eoc.fsf@googlemail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2015-03/txt/msg00790.txt.bz2

Maxim Ostapenko <m.ostapenko@partner.samsung.com> writes:
> @@ -293,17 +302,15 @@ alloc_stack_frame_space (HOST_WIDE_INT size, unsigned HOST_WIDE_INT align)
>    new_frame_offset = frame_offset;

Think this assignment is dead after your change.

>    if (FRAME_GROWS_DOWNWARD)
>      {
> -      new_frame_offset -= size + frame_phase;
> -      new_frame_offset &= -align;
> -      new_frame_offset += frame_phase;
> +      new_frame_offset
> +	= align_base (frame_offset - frame_phase - size,
> +		      align, false) + frame_phase;
>        offset = new_frame_offset;
>      }
>    else
>      {
> -      new_frame_offset -= frame_phase;
> -      new_frame_offset += align - 1;
> -      new_frame_offset &= -align;
> -      new_frame_offset += frame_phase;
> +      new_frame_offset
> +	= align_base (frame_offset - frame_phase, align, true) + frame_phase;
>        offset = new_frame_offset;
>        new_frame_offset += size;
>      }

(Patch looks good to me otherwise FWIW.)

Thanks,
Richard