From: Richard Sandiford <rdsandiford@googlemail.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org,
Richard Sandiford <richard.sandiford@arm.com>,
Alan Hayward <Alan.Hayward@arm.com>,
"steven\@gcc.gnu.org" <steven@gcc.gnu.org>
Subject: Re: [PATCH][rtlanal.c][BE][1/2] Fix vector load/stores to not use ld1/st1
Date: Sat, 10 Jan 2015 14:59:00 -0000 [thread overview]
Message-ID: <87a91qg50x.fsf@googlemail.com> (raw)
In-Reply-To: <2243996.KNkFcg5eZm@polaris>
Sorry for the slow response. Jeff has approved the patch in the
meantime, but I didn't want to go ahead and apply it while there
was still disagreement...
Eric Botcazou <ebotcazou@adacore.com> writes:
>> Please be more specific though. If you don't think the patch is correct,
>> what do you think the requirement should be and how should it be integrated
>> into the existing checks?
>
> Good question, but I have asked it first. :-)
>
> So what are the new subregs that we want to accept here? Can someone write
> this down explicitly, I think that we cannot go ahead without that.
The idea is that if:
(1) we have a non-paradoxical subreg;
(2) both (reg:ymode xregno) and (reg:xmode xregno) occupy full
hard registers (no padding or unused upper bits);
(3) (reg:ymode xregno) and (reg:xmode xregno) store the same number
of bytes (X) in each constituent hard register;
(4) the offset is a multiple of X, i.e. the data we're accessing
is aligned to a register boundary; and
(5) endianness is regular (no differences between words and bytes,
or between registers and memory)
then the register offset is always the byte offset divided by X.
>> E.g. the assert is there because the main calculation is based on:
>>
>> /* Size of ymode must not be greater than the size of xmode. */
>> mode_multiple = GET_MODE_SIZE (xmode) / GET_MODE_SIZE (ymode);
>> gcc_assert (mode_multiple != 0);
>>
>> which clearly isn't a useful value if the division isn't exact.
>> Do you mean that, since mode_multiple isn't correct for the
>> DI-of-a-CI case, we should reformulate the end of the function
>> to avoid using mode_multiple at all?
>
> Yes.
It's not really obvious to me how to do that though. Maybe I just
don't understand the cases that the existing code is trying to handle
well enough.
Thanks,
Richard
next prev parent reply other threads:[~2015-01-10 13:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 11:08 Alan Hayward
2014-12-12 16:21 ` Richard Sandiford
2014-12-13 11:34 ` Eric Botcazou
2014-12-15 9:21 ` Richard Sandiford
2014-12-15 20:52 ` Eric Botcazou
2014-12-15 21:56 ` Richard Sandiford
2014-12-19 22:53 ` Eric Botcazou
2015-01-10 14:59 ` Richard Sandiford [this message]
2015-01-13 19:04 ` Eric Botcazou
2015-01-14 8:37 ` Jeff Law
2015-01-14 9:55 ` Marcus Shawcroft
2015-01-20 21:45 ` Richard Sandiford
2015-01-21 1:48 ` Eric Botcazou
2015-01-21 18:03 ` Richard Sandiford
2015-01-14 7:48 ` Jeff Law
2015-01-09 7:12 ` Jeff Law
-- strict thread matches above, loose matches on Subject: below --
2014-12-10 9:51 Alan Hayward
2014-12-10 10:25 ` Marcus Shawcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a91qg50x.fsf@googlemail.com \
--to=rdsandiford@googlemail.com \
--cc=Alan.Hayward@arm.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
--cc=steven@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).