From: Andreas Schwab <schwab@linux-m68k.org>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix finding default baseline symbols directory
Date: Mon, 29 Sep 2014 17:24:00 -0000 [thread overview]
Message-ID: <87a95il4px.fsf@igel.home> (raw)
In-Reply-To: <20140929130831.GA4197@redhat.com> (Jonathan Wakely's message of "Mon, 29 Sep 2014 14:08:31 +0100")
Jonathan Wakely <jwakely@redhat.com> writes:
> Would a safer change be to just add a new pattern for aarch64?
>
> --- a/libstdc++-v3/configure.host
> +++ b/libstdc++-v3/configure.host
> @@ -345,6 +345,9 @@ case "${host}" in
> x86_64)
> abi_baseline_pair=x86_64-linux-gnu
> ;;
> + aarch64)
> + abi_baseline_pair=aarch64-linux-gnu
> + ;;
> *)
> if test -d ${glibcxx_srcdir}/config/abi/post/${try_cpu}-linux-gnu; then
> abi_baseline_pair=${try_cpu}-linux-gnu
IMHO it doesn't make sense to use try_cpu here if it is generic.
* configure.host (abi_baseline_pair): If try_cpu is generic use
host_cpu for the default.
diff --git a/libstdc++-v3/configure.host b/libstdc++-v3/configure.host
index a12871a..d1298c4 100644
--- a/libstdc++-v3/configure.host
+++ b/libstdc++-v3/configure.host
@@ -346,8 +346,13 @@ case "${host}" in
abi_baseline_pair=x86_64-linux-gnu
;;
*)
- if test -d ${glibcxx_srcdir}/config/abi/post/${try_cpu}-linux-gnu; then
- abi_baseline_pair=${try_cpu}-linux-gnu
+ if test $try_cpu = generic; then
+ try_abi_cpu=$host_cpu
+ else
+ try_abi_cpu=$try_cpu
+ fi
+ if test -d ${glibcxx_srcdir}/config/abi/post/${try_abi_cpu}-linux-gnu; then
+ abi_baseline_pair=${try_abi_cpu}-linux-gnu
fi
esac
case "${host}" in
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2014-09-29 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 21:42 Andreas Schwab
2014-09-29 13:08 ` Jonathan Wakely
2014-09-29 17:24 ` Andreas Schwab [this message]
2014-09-29 18:38 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a95il4px.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).