From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1556 invoked by alias); 22 May 2014 11:58:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1535 invoked by uid 89); 22 May 2014 11:58:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 May 2014 11:58:08 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WnRdK-0003da-Jm from Thomas_Schwinge@mentor.com ; Thu, 22 May 2014 04:58:02 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 22 May 2014 04:58:02 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.2.247.3; Thu, 22 May 2014 12:58:00 +0100 From: Thomas Schwinge To: Gary Benson , Andrew Burgess CC: Ian Lance Taylor , gcc-patches , Jason Merrill , Subject: Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special. In-Reply-To: <20140514142016.GA32660@blade.nx> References: <1399646123-9960-1-git-send-email-aburgess@broadcom.com> <536E7A72.1040203@broadcom.com> <20140514090125.GA4974@blade.nx> <537337AF.3020806@broadcom.com> <20140514142016.GA32660@blade.nx> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/23.4.1 (i486-pc-linux-gnu) Date: Thu, 22 May 2014 11:58:00 -0000 Message-ID: <87a9aavxdr.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2014-05/txt/msg01863.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 2965 Hi! On Wed, 14 May 2014 15:20:16 +0100, Gary Benson wrote: > Andrew Burgess wrote: > > On 14/05/2014 10:01 AM, Gary Benson wrote: > > > Ian Lance Taylor wrote: > > > > Andrew Burgess wrote: > > > > > On 09/05/2014 9:53 PM, Ian Lance Taylor wrote: > > > > > > Andrew Burgess wrote: > > > > > > > if ((AUTO_DEMANGLING || GNU_DEMANGLING)) > > > > > > > { > > > > > > > success =3D gnu_special (work, &mangled, &decl); > > > > > > > + if (!success) > > > > > > > + { > > > > > > > + delete_work_stuff (work); > > > > > > > + string_delete (&decl); > > > > > > > + } > > > > > > > > > > > > > > This patch is OK. > > >=20 > > > Andrew, would you like me to commit this? > >=20 > > Yes please. >=20 > Done: > https://gcc.gnu.org/viewcvs/gcc?view=3Drevision&revision=3D210425 In GCC, I'm consistenly seeing the following new failure: ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected FAIL at line 4350, options --format=3Dauto --no-params: in: _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z out: (null) exp:=20 ./test-demangle: 895 tests, 1 failures make[2]: *** [check-cplus-dem] Error 1 The patch was committed incompletely; I added the missing last line in r210803: commit 8207b6a22d5955c41109399cb09f0af661a593ea Author: tschwinge AuthorDate: Thu May 22 11:56:45 2014 +0000 Commit: tschwinge CommitDate: Thu May 22 11:56:45 2014 +0000 Fix test in libiberty/testsuite/demangle-expected. =20=20=20=20 libiberty/ * testsuite/demangle-expected: Fix last commit. =20=20=20=20 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@210803 138bc75d-0d04-04= 10-961f-82ee72b054a4 --- libiberty/ChangeLog | 4 ++++ libiberty/testsuite/demangle-expected | 1 + 2 files changed, 5 insertions(+) diff --git libiberty/ChangeLog libiberty/ChangeLog index 7156be7..7b25c7e 100644 --- libiberty/ChangeLog +++ libiberty/ChangeLog @@ -1,3 +1,7 @@ +2014-05-22 Thomas Schwinge + + * testsuite/demangle-expected: Fix last commit. + 2014-05-14 Andrew Burgess =20 * cplus-dmem.c (internal_cplus_demangle): Free any resources diff --git libiberty/testsuite/demangle-expected libiberty/testsuite/demang= le-expected index 823a1c4..864ee7e 100644 --- libiberty/testsuite/demangle-expected +++ libiberty/testsuite/demangle-expected @@ -4347,3 +4347,4 @@ void post >(std::function&&)::{lambda()#1}*& std --format=3Dauto --no-params _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z +_QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTfeZAAAoJEK3/DN1sMFFtkjMH/iQYvg2o3meltVQyvh9E5bde ns3mglLqkXbqONYvjYyptCgbLere5N2860WcdrWrbRVNWNPjk/e6o+4TBEMSCWhE Z/HNMMmb+OK0olNdhxYj93MGhzunytwmaXEcb1oPSRTHfs0qnQNW93rcYnDL+Csn D0tUvZT1YVEqLFvap7oqb1KDbO84C599aFzHRB1CxzrRyeJcUekwEyNlykTLTZlD a9z8vuBGXjpGplnKc6hXxVxVAAN6CmFQfEQECkVG/Vcm6vU0G7kUjwi8EFCrD22Z lnmDCkJpzDnFSyiWOK/KXRDRszqX0g9eAVMuIoRvDjol4T2+lMB0yFBpGSxmLZE= =+mIm -----END PGP SIGNATURE----- --=-=-=--