From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25796 invoked by alias); 22 Feb 2013 19:49:33 -0000 Received: (qmail 25787 invoked by uid 22791); 22 Feb 2013 19:49:32 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-we0-f169.google.com (HELO mail-we0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Feb 2013 19:49:26 +0000 Received: by mail-we0-f169.google.com with SMTP id t11so888399wey.28 for ; Fri, 22 Feb 2013 11:49:25 -0800 (PST) X-Received: by 10.194.120.169 with SMTP id ld9mr5859970wjb.24.1361562564946; Fri, 22 Feb 2013 11:49:24 -0800 (PST) Received: from localhost ([2.26.169.65]) by mx.google.com with ESMTPS id t7sm292842wiy.2.2013.02.22.11.49.23 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 22 Feb 2013 11:49:24 -0800 (PST) From: Richard Sandiford To: Jakub Jelinek Mail-Followup-To: Jakub Jelinek ,Steve Ellcey , Aldy Hernandez , gcc-patches , rdsandiford@googlemail.com Cc: Steve Ellcey , Aldy Hernandez , gcc-patches Subject: Re: PR target/52555: attribute optimize is overriding command line options References: <20130218230522.GB1215@tucnak.zalov.cz> <1C0E790D7E4C75418622FD04CC2A1172015D5C06@bamail02.ba.imgtec.org> <20130222100311.GJ1215@tucnak.zalov.cz> <1361554314.1732.17.camel@ubuntu-sellcey> <20130222181740.GP1215@tucnak.zalov.cz> Date: Fri, 22 Feb 2013 19:49:00 -0000 In-Reply-To: <20130222181740.GP1215@tucnak.zalov.cz> (Jakub Jelinek's message of "Fri, 22 Feb 2013 19:17:40 +0100") Message-ID: <87a9qwuo1p.fsf@talisman.default> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-02/txt/msg01080.txt.bz2 Jakub Jelinek writes: > On Fri, Feb 22, 2013 at 09:31:54AM -0800, Steve Ellcey wrote: >> On Fri, 2013-02-22 at 11:03 +0100, Jakub Jelinek wrote: >> >> > The problem I believe is that Aldy has changed init_optabs and insn-opinit.c >> > to use this_fn_optabs instead of this_target_optabs, but it is only set in >> > invoke_set_current_function_hook. During save_target_globals we want to >> > init this_target_optabs, so we need to temporarily switch this_fn_optabs to >> > make that happen. >> > >> > 2013-02-22 Jakub Jelinek >> > >> > PR target/52555 >> > * target-globals.c (save_target_globals): For init_reg_sets and >> > target_reinit remporarily set this_fn_optabs to this_target_optabs. >> > >> >> I built with this patch and ran the GCC testsuite (using the target >> mips-mti-linux-gnu), it fixed the problem and caused no regressions for >> me. > > Richard, is that ok for trunk then? Looks good to me. Thanks for fixing it. Richard