From: Richard Sandiford <rdsandiford@googlemail.com>
To: "Steve Ellcey " <sellcey@mips.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, mips, stabs] Do any MIPS targets use stabs?
Date: Mon, 07 Jan 2013 20:38:00 -0000 [thread overview]
Message-ID: <87a9sk4tkn.fsf@talisman.default> (raw)
In-Reply-To: <87ip784tyl.fsf@talisman.default> (Richard Sandiford's message of "Mon, 07 Jan 2013 20:30:10 +0000")
Richard Sandiford <rdsandiford@googlemail.com> writes:
> "Steve Ellcey " <sellcey@mips.com> writes:
>> While testing all the variations of my mips-mti-elf target I found that
>> a number of debug tests like gcc.dg/debug/trivial.c fail when compiled
>> using a stabs debug flag (-gstabs3 for example) and -mips16. While running
>> the GNU simulator I get:
>>
>> mips-core: 1 byte read to unmapped address 0xffffe820 at 0xffffffff80020278
>> program stopped with signal 10 (User defined signal 1).
>> FAIL: gcc.dg/debug/trivial.c -gstabs3 -O execution test
>>
>> Since I don't actually care about STABS I was looking at undefining
>> DBX_DEBUGGING_INFO in mips-mti-elf.h and mips-mti-linux.h which makes
>> the failures a moot point for me since I would no longer run the tests
>> with any -stabs flags.
>>
>> But I was wondering, are there any MIPS targets that do use stabs? If not
>> maybe we should just remove the define of DBX_DEBUGGING_INFO from mips.h
>> instead of undefing it just for my targets. Opinions?
>
> Do you know why selecting stabs causes an execution failure?
> That shouldn't happen regardless of whether the debug info itself is good.
Ah, sorry, this reminded me of a patch I'd written a year ago and never
got around to sanity-checking. Does it fix the problem for you?
Richard
Index: gas/config/tc-mips.c
===================================================================
--- gas/config/tc-mips.c 2012-01-28 14:47:10.000000000 +0000
+++ gas/config/tc-mips.c 2012-01-28 14:48:14.000000000 +0000
@@ -1476,7 +1476,9 @@ static const pseudo_typeS mips_pseudo_ta
{"section", s_change_section, 0},
{"short", s_cons, 1},
{"single", s_float_cons, 'f'},
+ {"stabd", s_mips_stab, 'd'},
{"stabn", s_mips_stab, 'n'},
+ {"stabs", s_mips_stab, 's'},
{"text", s_change_sec, 't'},
{"word", s_cons, 2},
@@ -16817,9 +16819,7 @@ s_insn (int ignore ATTRIBUTE_UNUSED)
static void
s_mips_stab (int type)
{
- if (type == 'n')
- mips_mark_labels ();
-
+ mips_mark_labels ();
s_stab (type);
}
next prev parent reply other threads:[~2013-01-07 20:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 18:27 Steve Ellcey
2013-01-07 20:30 ` Richard Sandiford
2013-01-07 20:38 ` Richard Sandiford [this message]
2013-01-07 20:54 ` Steve Ellcey
2013-01-08 16:30 ` Steve Ellcey
2013-01-07 20:41 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9sk4tkn.fsf@talisman.default \
--to=rdsandiford@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=sellcey@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).