From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32378 invoked by alias); 8 Dec 2010 16:49:07 -0000 Received: (qmail 32354 invoked by uid 22791); 8 Dec 2010 16:49:06 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Dec 2010 16:49:00 +0000 Received: (qmail 31824 invoked from network); 8 Dec 2010 16:48:58 -0000 Received: from unknown (HELO dirichlet.schwinge.homeip.net) (thomas@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Dec 2010 16:48:58 -0000 From: Thomas Schwinge To: "Joseph S. Myers" Cc: gcc-patches@gcc.gnu.org, maxim@codesourcery.com, thomas@schwinge.name Subject: Re: [PATCH] glibc / uclibc / bionic switch vs. non-Linux, GNU-based systems References: <1291821876-23891-1-git-send-email-thomas@schwinge.name> Date: Wed, 08 Dec 2010 16:58:00 -0000 In-Reply-To: (Joseph S. Myers's message of "Wed, 8 Dec 2010 16:33:35 +0000 (UTC)") Message-ID: <87aakgnrbj.fsf@dirichlet.schwinge.homeip.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-12/txt/msg00680.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1378 Hallo! On 2010-12-08 16:33, Joseph S. Myers wrote: > On Wed, 8 Dec 2010, Thomas Schwinge wrote: >> This patch makes GNU/Hurd buildable again. Previously, I had made this >> Linux libc switch depend on Linux kernel only, but when Maxim added >> support for bionic on 2010-05-27 in r159917, then it broke again, and I'm >> now finally giving in... Let the libc options be there at run-time; we >> simply won't use them. > > This alternative patch limits use of linux.opt to those targets for > which it is relevant - that is, *-*-linux* (systems using the Linux > kernel and an MMU-based ABI), as those are the systems for which > alternative libcs may be available withing a single compiler > configuration. > > This patch works by defining SINGLE_LIBC (along with DEFAULT_LIBC) for Why not just SINGLE_LIBC for (a) triggering this single libc case, and (b) specifying which one to use? That is: > +#ifdef SINGLE_LIBC > +#define OPTION_GLIBC (DEFAULT_LIBC =3D=3D LIBC_GLIBC) Use ``SINGLE_LIBC =3D=3D [...]'' instead. Etc. > - tm_defines=3D"$tm_defines OPTION_GLIBC=3D1";; > + tm_defines=3D"$tm_defines DEFAULT_LIBC=3DLIBC_GLIBC SINGLE_LIBC";; Use ``SINGLE_LIBC=3DLIBC_GLIBC'' instead. Etc. Or did you have a specific reason to use two #define:s for that? (I have not tested this suggestion, so perhaps I'm missing some detail.) Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 197 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkz/tvAACgkQC9ZuxbdEiFijpQCgiUY822zXqmZ7XJh5hgA5yFuO 4K4AoIvKFbjWRRG078/o5jonkiWkOl4+ =Czqs -----END PGP SIGNATURE----- --=-=-=--