public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <rsandifo@nildram.co.uk>
To: Rask Ingemann Lambertsen <rask@sygehus.dk>
Cc: Mark Mitchell <mark@codesourcery.com>,
	 GCC Patches <gcc-patches@gcc.gnu.org>,
	 fortran@gcc.gnu.org,  java-patches@gcc.gnu.org
Subject: Re: Link tests after GCC_NO_EXECUTABLES
Date: Fri, 07 Dec 2007 11:27:00 -0000	[thread overview]
Message-ID: <87abomzqvw.fsf@firetop.home> (raw)
In-Reply-To: <20071206175819.GO17368@sygehus.dk> (Rask Ingemann Lambertsen's 	message of "Thu\, 6 Dec 2007 18\:58\:20 +0100")

OK, I'm not doing a good job of staying out of this discussion as
promised, but I was hoping someone else would raise this point...

My main concern with applying this patch in its current state is that,
while we have (intentionally) only been talking about *-elf so far,
newlib != *-elf.  Cygwin is also an important newlib user, and I don't
remember anyone explicitly mentioning it so far in this thread.  Is this
patch really safe there?  Cygwin's newlib provides all sorts of POSIXy
stuff that you don't get in your typical *-elf target (see libc/posix)
so things like:

> +ac_cv_func_execl=${ac_cv_func_execl=no}
> +ac_cv_func_execve=${ac_cv_func_execve=no}
> +ac_cv_func_execvp=${ac_cv_func_execvp=no}

(just a sample) might unintentionally limit the functionality of
libgfortran on that target.  I think the same thing could apply
to targets like Newlib/Linux, if GCC supports it.

While I'm here, I noticed a very minor nit.  The patch has:

> +ac_cv_func_fork=${ac_cv_func_fork=no}
> +ac_cv_func_fork=${ac_cv_func_fork=yes}

where the last line is redundant (though harmless).

Richard

  parent reply	other threads:[~2007-12-07 11:27 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <46EFBCC1.6070200@gmail.com>
     [not found] ` <46EFC383.7020503@t-online.de>
     [not found]   ` <46EFC9E9.7090201@gmail.com>
     [not found]     ` <46EFCEF9.3060304@t-online.de>
     [not found]       ` <46EFCF7A.2080704@gmail.com>
     [not found]         ` <46EFD236.6080907@t-online.de>
     [not found]           ` <46EFDA4D.3070006@gmail.com>
2007-11-27 15:35             ` Bernd Schmidt
2007-11-27 22:17               ` Mark Mitchell
2007-11-27 22:40                 ` Bernd Schmidt
2007-11-27 22:43                   ` Mark Mitchell
2007-11-27 22:58                     ` Bernd Schmidt
2007-11-27 23:17                       ` Mark Mitchell
2007-11-28  0:23                         ` Bernd Schmidt
2007-11-28  0:33                           ` Mark Mitchell
2007-11-28  1:03                             ` Bernd Schmidt
2007-11-28  1:24                               ` Mark Mitchell
2007-11-28  6:34                                 ` Bernd Schmidt
2007-11-28 10:37                                   ` Mark Mitchell
2007-11-28 15:47                                     ` Bernd Schmidt
2007-11-28  8:16                                 ` Joseph S. Myers
2007-11-28 10:01                                   ` Mark Mitchell
2007-11-28 11:37                                     ` Joseph S. Myers
2007-11-28 11:40                                       ` Mark Mitchell
2007-11-28 15:37                                       ` Bernd Schmidt
2007-11-28 13:07                             ` Richard Sandiford
2007-11-28 16:06                               ` Rask Ingemann Lambertsen
2007-11-28 16:59                               ` Daniel Jacobowitz
2007-11-28 18:55                               ` Mark Mitchell
2007-11-28 22:41                                 ` Richard Sandiford
2007-11-28 23:03                                 ` Rask Ingemann Lambertsen
2007-11-29  6:21                                   ` Mark Mitchell
2007-11-30 21:07                                     ` Rask Ingemann Lambertsen
2007-11-30 21:08                                       ` Mark Mitchell
     [not found]                                         ` <20071130211005.GQ17368@sygehus.dk>
2007-12-01  9:48                                           ` Richard Sandiford
2007-12-01 11:53                                             ` Rask Ingemann Lambertsen
2007-12-01 12:03                                               ` Rask Ingemann Lambertsen
2007-12-01 13:37                                                 ` Andreas Schwab
2007-12-01 22:35                                                   ` Rask Ingemann Lambertsen
2007-12-02 21:11                                                     ` Mark Mitchell
2007-12-05 17:22                                                       ` Rask Ingemann Lambertsen
2007-12-06  0:38                                                         ` Mark Mitchell
2007-12-06 17:58                                                           ` Rask Ingemann Lambertsen
2007-12-07  1:37                                                             ` Mark Mitchell
2007-12-07 15:31                                                               ` Rask Ingemann Lambertsen
2007-12-07 18:39                                                                 ` Mark Mitchell
2007-12-07 21:48                                                                   ` Rask Ingemann Lambertsen
2007-12-07 21:57                                                                     ` Mark Mitchell
2007-12-13 22:25                                                                       ` [PATCH v2] " Rask Ingemann Lambertsen
2007-12-30 13:46                                                                         ` Ping " Rask Ingemann Lambertsen
2007-12-30 17:41                                                                           ` Paolo Bonzini
2007-12-07 11:27                                                             ` Richard Sandiford [this message]
2007-12-07 15:18                                                               ` Rask Ingemann Lambertsen
2007-12-08 11:25                                                                 ` Richard Sandiford
2007-12-04 14:46                                                     ` Rask Ingemann Lambertsen
2007-12-05  0:10                                                     ` Hans-Peter Nilsson
2007-12-05  0:19                                                       ` Rask Ingemann Lambertsen
2007-12-05  0:46                                                         ` Hans-Peter Nilsson
2007-11-30  3:56                                 ` Richard Sandiford
2007-11-30  5:32                                   ` Mark Mitchell
2007-11-30  8:07                                     ` Benjamin Kosnik
2007-11-30  9:58                                   ` Rask Ingemann Lambertsen
2007-11-30 11:41                                     ` Mark Mitchell
2007-11-30 23:25                                       ` Rask Ingemann Lambertsen
2007-11-30 13:16                                     ` Richard Sandiford
2007-11-30 20:32                                       ` Rask Ingemann Lambertsen
2007-11-30 21:10                                       ` Mark Mitchell
2007-11-30 21:15                                         ` DJ Delorie
2007-12-01  9:55                                         ` Richard Sandiford
2007-12-02 21:01                                           ` Mark Mitchell
2007-12-03 15:55                                             ` Richard Sandiford
2007-12-03 14:40                                     ` btest-gcc.sh patch ping and " Hans-Peter Nilsson
2007-12-03 16:07                                       ` Richard Sandiford
2007-12-03 22:43                                         ` Hans-Peter Nilsson
2007-12-03 16:59                                       ` Geoff Keating
2007-12-03 22:39                                         ` Hans-Peter Nilsson
2007-12-04  6:52                                           ` Geoff Keating
2007-12-04 22:26                                             ` btest-gcc.sh patch ping Hans-Peter Nilsson
2009-03-28 14:10                                             ` btest-gcc.sh patch ping and Re: Link tests after GCC_NO_EXECUTABLES Richard Guenther
2009-03-28 20:37                                               ` Geoff Keating
2007-11-30 20:49                                   ` Rask Ingemann Lambertsen
2008-05-15 21:40                                   ` Bernd Schmidt
2008-05-15 23:02                                     ` Richard Sandiford
2008-05-15 23:10                                       ` Bernd Schmidt
2008-05-16  0:18                                         ` Mark Mitchell
2008-05-16  2:21                                           ` Joseph S. Myers
2008-06-18 21:05                                             ` Ralf Wildenhues
2008-06-19  3:57                                               ` Mark Mitchell
2008-07-07 20:14                                                 ` Ralf Wildenhues
2007-11-28  8:54                       ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87abomzqvw.fsf@firetop.home \
    --to=rsandifo@nildram.co.uk \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java-patches@gcc.gnu.org \
    --cc=mark@codesourcery.com \
    --cc=rask@sygehus.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).