From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 9DB013858401 for ; Mon, 28 Nov 2022 22:35:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9DB013858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.96,201,1665475200"; d="scan'208";a="88397949" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 28 Nov 2022 14:35:36 -0800 IronPort-SDR: 0JcA+XKz0aHkIYCDfU/n+hMt8GJwvXCYgA9qaAZ6j7D6wqoTVXFwR4KsrGFppoHFatEs8R9IMr hZIVv4kieQzJxTzOY5A7ifIQF9mcPXVd0armNUktSnaOqCH9um+CJe/wEww5cKyS3gJ51T0xY8 sSAaCMhzfkMz3txVMtpeP6mL6vGBhBH6dlt5wWlVXxKlJCmlwMPYeZp+U2qh7QiMi9llCgY1Q4 NCuTi801Zbpa9Mx3JdcxvFM+vp6MP7FGBVRB4/81ptJ6wIN9qaG7BpXTQ189t3tJd91Ct4H07N JXo= Date: Mon, 28 Nov 2022 22:35:31 +0000 From: Joseph Myers To: Zopolis0 CC: Subject: Re: Java front-end and library patches. In-Reply-To: Message-ID: <87be1195-fee5-7355-ddd-ddceedcce0a6@codesourcery.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3109.8 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 25 Nov 2022, Zopolis0 via Gcc-patches wrote: > Firstly, to get feedback and reviews on the 56 already existing > patches, even though most are just re-adding code or making idiomatic > changes, so that when the final issue is solved everything has already > been approved (hopefully) and the merge is good to go. I think a lot more explanation is needed to get much useful feedback. * Each patch should have its own explanation of what it is doing and why, in the message body (not in an attachment). Just the commit summary line and ChangeLog entries aren't enough, we need the actual substantive commit message explaining the patch. * An overall explanation is needed of what the patch series is doing and why. Why is it now considered useful to add this front end back? Which version is the basis of the one being added back - the version removed from GCC (that used ECJ for converting Java source to Java byte-code), or some other version? How has the series been validated? Would you propose to maintain the front end and libraries in future? Would you re-open any bugs against the front end or libraries that were closed (as WONTFIX or otherwise) as a result of it being removed from the tree (maybe when it was removed, maybe later when the last release series with the front end ceased to be supported)? And so on. -- Joseph S. Myers joseph@codesourcery.com