From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 94692384CBA3 for ; Tue, 28 Nov 2023 12:43:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94692384CBA3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 94692384CBA3 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701175409; cv=pass; b=wmN4As4IupZ/L/adrkwtLwgQjUZZlMlQIlkyjlyUZBkk4ZlLEOjtGm2KvD+jsL0m8vYCOZzEpdPjCDAuzQdU6UM+FVYfyzzXOYZiyGi8dZMOCFqIzRnk6aDcbvPXQHeEfsq9vbbfPHTTx7Tql2CiV3V9a7KUcQtVph+0bPe8cR4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701175409; c=relaxed/simple; bh=vOKeRc8T+C3VQDsRQXwbFHlCVAmHbGkn1zg1qgUypE8=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=R1chyqViQ/otYlc4Kir04M8UhLXC4ubpfNuxB7r3ZRvPRArZHOVYgsyYdYfrxlM1t8EPbFe/pDP9OrtHhEg5E59xcadzxxXrhgfnc7ijSafLLVzkiJxdtjcHT/5KPXitHlxuYI1L9k8/YAygj7F8xel3z6cRTltEHmKz3kmiHQo= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ASBTXsC030544 for ; Tue, 28 Nov 2023 12:43:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2023-11-20; bh=GHlH/TRb/lBvL8gRNPoiQ1AaRDowXqtT+y9LAuIFXvk=; b=CHgKhDjSFb1PXP9nb25DlC+8NcfVaCtlHRCG9IR+Q1zstc2XxyUnB0Xgdb9OnnvFAcjf s+zMp1vXbb8OZZp0OEAhwuB9SqMNQcdnWK5DJybFMmfAYPUxsC+EwVjcx/FzeQF8zn84 Wj//dO32+PcPzYN4bVnP7fZuj04PgR+LUZWr4IETrMqVFmQxZkDB51rI0ilWaZcqZBHj xfnw4mvoa/jRaiddw5lnmlp8HiHTuSVC3ZlaE5fAQcOS8X5U+j1q2b1YtxZFL9WgTsnl c2S5J8qCCe9S0opXkMre7Szz5UCIde5lbpQ2lY2jgDZc6W2pLpfnoWhhfsv/yk/1XdRo ag== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3un1rxhmn8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 28 Nov 2023 12:43:27 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3ASC12YD009309 for ; Tue, 28 Nov 2023 12:43:26 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2169.outbound.protection.outlook.com [104.47.73.169]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3uk7c6jrd4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 28 Nov 2023 12:43:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gSK/vrPqHvRC1gjO3W7YNzDRx5jQxSYWpWvQ20AL5tdButTGQ18f/lf5EEPRMkzm5NXxHTZoPmqjvf5tdbop5yaYqLZAxJlw0CIqOopB4KVzIQbgcBJP4tWXQiexiykBp5j42JF/hjhNQtMnw+43D3RRfTHFvbZXbywsyKFm54DEaPnwuYJn87kleYsfBh5Q2Il7nIR6tk5RAb9kchL2ptOozyF8of3IX9Obrmvx7BnRjBtOk3nvbJ9cLdO3kR/2/4GmlOHs1R15oU7sZj02P5U2ZTtu/o6U9hfsMcG6oK6jB53nu+uOmF5Ht1Efkx+9ca6f8Xi/HY4yziDmi6TnFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GHlH/TRb/lBvL8gRNPoiQ1AaRDowXqtT+y9LAuIFXvk=; b=krtwIr4fOgQ7nuYdKA2Muu+4et5EL+npK+j84b6oszNV0TZErNipgpXcvKrAyqyZt+04V3Fv1uRRxfvE0Q00FWuLjFQYY+iyb0vGxjEaZM2t4CveuO34eY28tf0j94ruDv3nAvFCkattnAukBRerzEunMVjceU5veK/muxYnYxo7vEp0/ZStcFMMg77k5IGSRHb2sLw2lbF6nTJhyHYbsYt50wqcFg0FWulYXkSwShFwXVQz4G9ibq4bgNUbyQEvcXu85rB84ysNingvI1D6fbkNPU4PjelsjBfgifGN4rg1k4sqDaH8rti89qKvlLzlZ0QWYb4ZUnNcbpEu9JV7Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GHlH/TRb/lBvL8gRNPoiQ1AaRDowXqtT+y9LAuIFXvk=; b=RYWCXiZ6SyYLh1t27h4rS12D+tWvqfB5qTU9UlDfwrAaPAsE1ctacmHN9vnGT5/d8yNLOV2PECmk8XQjDX8Q88gAW9T8xXv1T7DsYVI2K9Ef6hn0pr4vuaS8faI2bpierSOLHBGBUM+9mnSLSdS5atRrxqpnEFehGxGs2/27ILI= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by SN7PR10MB6474.namprd10.prod.outlook.com (2603:10b6:806:2a1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Tue, 28 Nov 2023 12:43:16 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::fec4:3a58:6118:aab2]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::fec4:3a58:6118:aab2%6]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 12:43:16 +0000 References: <20231113223638.11660-1-cupertino.miranda@oracle.com> <161a90b9-0c58-4f48-859c-29624fdd0946@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: David Faust Cc: gcc-patches@gcc.gnu.org, jose.marchesi@oracle.com, elena.zannoni@oracle.com Subject: Re: [PATCH] bpf: Corrected condition in core_mark_as_access_index. In-reply-to: <161a90b9-0c58-4f48-859c-29624fdd0946@oracle.com> Date: Tue, 28 Nov 2023 12:43:11 +0000 Message-ID: <87bkbeaw0w.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: AM0PR01CA0159.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::28) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|SN7PR10MB6474:EE_ X-MS-Office365-Filtering-Correlation-Id: 15f6b433-66a6-4b7b-6e62-08dbf00f978a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lGeeKZm7zlibKrSVThafBOiSasLclBkrnerJdwcgGbSIBbVhjrtLk3rfu0wmX72pYLC66v9kFflT5Q78bLMhoiFP+ESOFOhESSkHVkP0uEvOzBfdn2n+3A9KhsgU/LnqcswOs/OezzD2TPah2Spv5n8qpmF5XVnplyNG4w78yEzCK1r3WZUuNN/c9JFzAjPwphJrKzCy5ha0kr3CrD5a7HYwD/d293dk3bI8Dh+Lbt4WZNvsUJhAsG0qrlw0BfpSahAfocy1eZn0/qGnUykNRU9wRuPWVvMReldTa7fq9MaRlMMDRe/95Cgg+02v/yh/2d6x8KU+Yg0pIYN2vWoZ/SD0pbh/uhtw9GE6YVerNc/WFBV2hF3TTyntSQd7Tw5HoykbiadwtHvgT3Xkt2EBUs/hHftk03ueUjnPsSXNRmXXbAo1ZlhBTlJNOqLMPd6F53ch+drufF9+0xWxUwUYmFgtLpvMaikFETA5HPlIZNpbuJyzNu9KFsXjaAUYnWX62Sbkt/CRu2CwotEA2rEcdYqcgEVwkCM1swMRiRjntfNII7qOIryUf2tuZWuWXyv+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(39860400002)(396003)(366004)(346002)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(36756003)(4744005)(2906002)(41300700001)(5660300002)(86362001)(6666004)(6512007)(53546011)(83380400001)(38100700002)(107886003)(6506007)(2616005)(44832011)(6486002)(478600001)(37006003)(66556008)(66476007)(8936002)(4326008)(6862004)(8676002)(316002)(6636002)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZAv2CVhXgLvKcwmRHADJL+QQ5uV7qRRFdAS2M8D8crp0S+Oh2bhIrebAEvkk?= =?us-ascii?Q?eEaKGiAOaHA0QLftxVs+E4/NUkyMWQIBFDAISsojX5RKoxijXXVZva4vpwlI?= =?us-ascii?Q?K+GsfNg827EVlrCxGDOLEOX3RSWxvOuAHHol+kkgdnjX+XF1AUY2RoAFMAuR?= =?us-ascii?Q?o4QkVQwYc34KQ9vnqtfDt/lNaPFDgQxoy/noT6B8AR+4HS8GGMem65mK20Ka?= =?us-ascii?Q?yoJkAukolUL7rn7vrb/kGrDYMtoleUDTs5ScXAXXCVeOjLbsLVEQ4P0vHZIY?= =?us-ascii?Q?FkbNYktvRdMo4oS4bjL3XcpwOZI4nC/Nqc8aJo93WfDdXVRfaduqrzMTwF/6?= =?us-ascii?Q?VbB3qI8Za5rcdWh9kgPJuV0oJWcuYcHBTm3/RlZRoi4KbgliNOQjUsU4sv0e?= =?us-ascii?Q?eI9ngfOY2UKCiF8FeZgjNDpoZ5A4S+CS+7XKHMnjt8/cWeSlQZm5tTrTB3gI?= =?us-ascii?Q?4HDIJdSeDuMuA6jyUI4IFCmFYvQmmfO8zKcIdlk6zNL3ypCWj6V37g/uv/FO?= =?us-ascii?Q?fErL8zgFY7ojcNwVhcs+5N//TSryhIGGiQqyq2wFWUJJ91iijIKTT6P61Yx2?= =?us-ascii?Q?I7f8jaKXhT93NkOeSfsZNpt4aLD1PXiFMe+t4zXViZZHHL5653NZtXjvhEje?= =?us-ascii?Q?UP2D4NbCvUpnEEB6T5LDBTrFY4UCjujD0WUVw8Z9iEh1+XjONi61A2EUF7XH?= =?us-ascii?Q?REQPD1tV3/KZa8bNyL9LiJBx/6vPfn7ODoAbH62tc3bRaJ7ke8BdgS/sI+Fv?= =?us-ascii?Q?+AIoEsYcM5gxt05IPoOwsf5DoVOiFgA/hMn0qiGiiiMN6pYgINUwnofdXEcq?= =?us-ascii?Q?PTInmFJINjGlsJnEqgcwy3Tk2JAGFKhc1jLZ4xuPVaAEX7Pvqk6qectFq5Jz?= =?us-ascii?Q?JP5Not8C2UguMxLIr/N8A4ceTOhSSKmKMdQdsI43oXIX5mUoMR8smarNmJzF?= =?us-ascii?Q?spiIzs27xCc5LLkgomZGW13oWKvCdS+hVDQtPg9i56KpKxDgN1dnwjKcDRHC?= =?us-ascii?Q?dUWHchZTnZ4u3fgYtEpg9T6fxbfoR7PPGNh+f6Ty86s6jz7KkVvOKDvInjyP?= =?us-ascii?Q?uW+p7VVatQ5ODR1bh12VWK1+hEttEZtc+u7iHvRPD1NJwOWuMPj8I9sCGycg?= =?us-ascii?Q?wzkayLwloP9oCqsp0IaWXyEV3tRXQr62djNIMyaq4esKg0DO5OX1ivaieCng?= =?us-ascii?Q?kdjMou9xT4qKjHzK6DOwFN9zt8+dp5ZiA/laXI2TrDNMGhDy4eH+JZwIu6fP?= =?us-ascii?Q?lXlpqiDNqCpIBIYzZ6uXOWITSwzkEX5rBYxFNp2rNxMtXLgmWiDjaN4bweSp?= =?us-ascii?Q?FryFuML9YyjupvfIlsC0G5IbgJiYJ0B5tyCaaS4jX6HJ9/hbGavWVqo8JWdN?= =?us-ascii?Q?y3+nceQRn6KoCx8iHq9zE8HrmfEYtwGS81lzISy2P+VB8jDPvgOyNW7QflV2?= =?us-ascii?Q?QRdg4p9tj3Qihmsx/8tkEwBGCEc6HaccnRqkohqZDrIPJuU2ctF7WxzOff/5?= =?us-ascii?Q?Z8+lg+bPv9bAUFLEfVnNC2F2I0NoDZLFsLPscmISE9w1/w6++PTwozVOOaIt?= =?us-ascii?Q?mnhFJcUNpe0u0n+iqwOdj1JdJoJqRM/SY9XhD2AsTlAz3Ejm/YJxENn7KEDw?= =?us-ascii?Q?zAqcnRtyjCxVZt56tfsissY=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: R0nWoHuUGSSmmtWCyCq9cGuHnwG4N88igmqc5OvDgtJxkO74YrsQVWk/X+efF7FiMJ/686eIrrdnowTorcF0h5cmKdGKYlxXVqA7ehA9S6pCEh+py0eObYEHwxG9nM6XU2qHvHCjj8zPHzFCU+6mJVFwaTZz2S6vnGWLcModi34nOZDFYca0EllE9nwGzDSB6ev8m61v5Y62GqZt37IqK4B/DVKZPevURaD0mey+g+6r9y0cfZTciZAaa0mkzfRbP8Mea75CFV1J+TKtb0g3ukVRKby/04IseY7mfPqwIQCthwkBHTCziKJP4C+c7sFs8O/mYsgMoRdU3g56MUWN2qtECRyIQUYz4GGnboB9Hi3WjGlWV4/MQ35GSHp1enqeBK+7PoqM+/1F/zxK6QyLEajq8N+NS7jupAhYfZeiS0idLZ9w0X9bHtGqWeVlFVEyQwDYG+qSNFL//UI9IjyNjFLQIM+TR6/vI9NTmxqVr6QfbyeVkH+7ZYubBQxI+MFLgFlmXicX68IzOVjJcflByngvOxjeylDXGPLYA06E+46F1UUmTldxG6kxxm9w2+fsZ2Iqe1jCDiU8CZHkAwwpaegpfvSKQgo+hiqrjCHpE/yIbFsz0en5o+CEykDTvUhIfqFEsh184xheAO1QsdJHaOXqdEzYSBU+8yKD4kH6XvrXtz7Z9K2ZjL83bJzjoVJeEIzv5aA2B6Y3kp0C1Epdv8EzLk5O4m3JmWzpLjrTf1ibeaqNWJSaDcD8niF6dvtV X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15f6b433-66a6-4b7b-6e62-08dbf00f978a X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 12:43:16.2861 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wNUGoQbKurwbIkyEaMoas+n84vI8KJK4HPLgy/S8jKfLXngdZw21Zd1FSYOuizA54gEfUalhE9sfRp17/mbAxoj0prhQgCPZAsSmxjRexk8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6474 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-28_12,2023-11-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311280101 X-Proofpoint-GUID: 5uIFuDIzCAdtayPyNRqZ_iDv_vK6z_dP X-Proofpoint-ORIG-GUID: 5uIFuDIzCAdtayPyNRqZ_iDv_vK6z_dP X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks! Committed ! David Faust writes: > On 11/13/23 14:36, Cupertino Miranda wrote: >> gcc/ChangeLog: >> * config/bpf/core-builtins.cc (core_mark_as_access_index): >> Corrected check. > > OK, thanks. > >> --- >> gcc/config/bpf/core-builtins.cc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gcc/config/bpf/core-builtins.cc b/gcc/config/bpf/core-builtins.cc >> index 2ba78d7aed2e..1376c9309035 100644 >> --- a/gcc/config/bpf/core-builtins.cc >> +++ b/gcc/config/bpf/core-builtins.cc >> @@ -1611,7 +1611,7 @@ core_mark_as_access_index (tree expr) >> || TREE_CODE (expr) == INDIRECT_REF) >> expr = TREE_OPERAND (expr, 0); >> >> - if (bpf_enum_mappings->get (expr) == NULL) >> + if (core_access_index_map->get (expr) == NULL) >> core_access_index_map->put (expr, NULL_TREE); >> } >>