From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 265C53848346 for ; Mon, 13 Nov 2023 19:43:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 265C53848346 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 265C53848346 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699904606; cv=none; b=d8sMjagwm/ujv5IADxQo6xhb/Fai++gaxz3V9m6S6G89PmWKRoo+xOhhxaAITxWxEV6+S/TPgwasWrygv+BZ3WLuGzb/ZLVbjsmw5Mrls6Tq2A+tTWJbtn9r5N6qExKUVRTxIL8GdTYm0kGQqMsbpvA+XVLAAqEhpsH0fjQupSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699904606; c=relaxed/simple; bh=0OIhVaNsGlJpLNrERJmTAzTj7f8s8q91g0f6XZFscDY=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=RXwS7OdkUV0nTNZCoS9DIolgtlwSv0oIvXRZTm2KlmWh2gt4RURXZ84CfMKZgELUUqdTHWT9NOm1HNV9/rto5AehdHesfLOOnJQ/tb8JvaXZcU2ZadUatm875tl/nkbKC2eHVCFUHp2VHRz7tNXHSfwy/KvVtFFk2iS9lIhwaec= ARC-Authentication-Results: i=1; server2.sourceware.org References: <7f561d1416464a4ddd3304475218688a2ffd3ea8.1699879818.git.fweimer@redhat.com> User-agent: mu4e 1.10.8; emacs 30.0.50 From: Sam James To: Florian Weimer Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror [PR91092] Date: Mon, 13 Nov 2023 19:42:08 +0000 Organization: Gentoo In-reply-to: <7f561d1416464a4ddd3304475218688a2ffd3ea8.1699879818.git.fweimer@redhat.com> Message-ID: <87bkbx4ey0.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Florian Weimer writes: > In the future, it may make sense to avoid cascading errors from > the implicit declaration, especially its assumed int return type. > This change here only changes the kind of the diagnostic, not > its wording or consequences. > > gcc/c/ > > * doc/invoke.texi (Warning Options): Document changes. > > gcc/c/ > > * c-decl.cc (implicit_decl_pedpermerror): Rename from > implicit_decl_warning. Call pedpermerror instead of > pedwarn and warning_at. > (implicitly_declare): Adjust callers. > > gcc/testsuite/ > > * c-c++-common/spellcheck-reserved.c (test, test_2): Expect > error instead of warning. > (f): Expect error instead of warning. > * gcc.dg/Wimplicit-function-declaration-c99.c: Compile with > -fpermissive due to expected warning. > * gcc.dg/Wimplicit-function-declaration-c99-2.c: New test. > Copied from gcc.dg/Wimplicit-function-declaration-c99.c. > Expect error. > * gcc.dg/missing-header-fixit-1.c: Compile with -fpermissive > due to expect error. > * gcc.dg/missing-header-fixit-1a.c: New test. Copied from > gcc.dg/missing-header-fixit-1.c, but expect error. > * gcc.dg/missing-header-fixit-2.c: Compile with -fpermissive > due to expect error. > * gcc.dg/missing-header-fixit-2a.c: New test. Copied from > gcc.dg/missing-header-fixit-2.c, but expect error. > * gcc.dg/missing-header-fixit-4.c: Compile with -fpermissive > due to expect error. > * gcc.dg/missing-header-fixit-4a.c: New test. Copied from > gcc.dg/missing-header-fixit-4.c, but expect error. > * gcc.dg/missing-header-fixit-5.c: Compile with -fpermissive > due to expect error. > * gcc.dg/missing-header-fixit-5a.c: New test. Copied from > gcc.dg/missing-header-fixit-5.c, but expect error. > * gcc.dg/pr61852.c: Expect implicit-function-declaration > error instead of warning. > * gcc.dg/spellcheck-identifiers-2.c: Compile with > -fpermissive due to expected warnings. > * gcc.dg/spellcheck-identifiers-2a.c: New test. Copied > from gcc.dg/spellcheck-identifiers-2a.c. Expect errors. > * gcc.dg/spellcheck-identifiers-3.c: Compile with > -fpermissive due to expected warnings. > * gcc.dg/spellcheck-identifiers-3a.c: New test. Copied > from gcc.dg/spellcheck-identifiers-2a.c. Expect errors. > * gcc.dg/spellcheck-identifiers-4.c: Compile with > -fpermissive due to expected warnings. > * gcc.dg/spellcheck-identifiers-4a.c: New test. Copied > from gcc.dg/spellcheck-identifiers-2a.c. Expect error. > * gcc.dg/spellcheck-identifiers.c: Compile with > -fpermissive due to expected warnings. > * gcc.dg/spellcheck-identifiers-1a.c: New test. Copied > from gcc.dg/spellcheck-identifiers.c. Expect errors. > * gcc.target/aarch64/sve/acle/general-c/ld1sh_gather_1.c (f1): > Expect error. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_1.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_index_restricted_1.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_1.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_2.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_3.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_4.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_5.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_1.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_2.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_3.c: > (f1): Likewise. > * gcc.target/aarch64/sve/acle/general-c/load_ext_gather_offset_restricted_4.c: > (f1): Likewise. This is PR91092. In due course, we'll also have to update the porting to GCC 14 page.