From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id E676E3858D37; Fri, 28 Apr 2023 12:56:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E676E3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.99,234,1677571200"; d="scan'208";a="3775945" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 28 Apr 2023 04:56:24 -0800 IronPort-SDR: YFtvr+nWzzn08+V+dVQQVZOfAJV2dtGzKykaSt/SPu1aOZiggWdCiAdWTQ1OhIUUZuM7R4NTL8 vXSmbzZeGVsnCiF6ZLRNHlPqalmJ0z/05b6yqpRsiAO8WmNNzfONhoAen+9K+e7uZHZzjEccIF xT3686xLow7R8X6J7hzp7YAUQyKbzIyQI8nMQijD9LGbDWuyU0uCXHjLXYfoLquHb/r+Eg0Cer Oxq/A34WLh1JdgYfIhmsjMUyyj9H9R/p8yhmcPTwzmrIRrzYLuUSKIGAPse9U++Tiw+lSfiXKK OY0= From: Thomas Schwinge To: Julian Brown CC: , , , Subject: Re: [PATCH] OpenACC: Stand-alone attach/detach clause fixes for Fortran [PR109622] In-Reply-To: <20230427183647.99112-1-julian@codesourcery.com> References: <138a36f7-8b1e-5955-1d3a-5713a0fcf5b6@univ-grenoble-alpes.fr> <20230427183647.99112-1-julian@codesourcery.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Fri, 28 Apr 2023 14:56:18 +0200 Message-ID: <87bkj817yl.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Julian! On 2023-04-27T11:36:47-0700, Julian Brown wrote: > This patch fixes several cases where multiple attach or detach mapping > nodes were being created for stand-alone attach or detach clauses > in Fortran. After the introduction of stricter checking later during > compilation, these extra nodes could cause ICEs, as seen in the PR. > > The patch also fixes cases that "happened to work" previously where > the user attaches/detaches a pointer to array using a descriptor, and > (I think!) the "_data" field has offset zero, hence the same address as > the descriptor as a whole. Thanks for looking into this. I haven't reviewed the patch itself, but noticed one thing: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.fortran/pr109622-2.f90 > +!$acc enter data copyin(var) > --- /dev/null > +++ b/libgomp/testsuite/libgomp.fortran/pr109622-3.f90 > +!$acc enter data copyin(var, tgt) > --- /dev/null > +++ b/libgomp/testsuite/libgomp.fortran/pr109622.f90 > +!$acc enter data copyin(var, var2) You'll want to move these into 'libgomp/testsuite/libgomp.oacc-fortran/' to actually test them with '-fopenacc' instead of '-fopenmp'. ;-) Chalk up one for the idea that I once had, to have '-fopenacc', '-fopenmp', '-fopenmp-simd' enable '-Wunknown-pragmas' by default. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955