From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [IPv6:2001:67c:2050:0:465::201]) by sourceware.org (Postfix) with ESMTPS id 7606C3858D1E for ; Sat, 11 Mar 2023 01:53:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7606C3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4PYQtd6YrLz9sSL; Sat, 11 Mar 2023 02:53:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1678499609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z2CN6jYqNKncsyuF7tGYWhneWlPcxh0s+Y22GBvTkTo=; b=lVXNGgUfprXw1bod24SyD7FleT31XAAfYN6hMy+oOvSQO+vTHG4Aa/Dbe4Vx0+lS8EiLtY ThJot1hX3g1Ve5olFwOXyFa6Ncou1Ivt7xlaLA9j8KNyu9d+g1O9VpRNkmSfoXwSDCeJoW sG1wIzEH4StJ5mFwKIO4xe9zRH6P+2GUDP8TevtCvVQxjxo0fp2lfQqZJfqv9qgOWYYWkn zY4TMuyIHeIBg6bQ1jYLK23zevpSqR+FadIvqfFJqUR4gDhOxkqGIKWgywSRiEQyx4avhP oT1lBxznSq5M3ydHUdESEPvg9a67b0I061t41kvrlb9h7ZS25WJWQrphZCbhWg== References: <20230223102714.3606058-1-arsen@aarsen.me> <20230223102714.3606058-2-arsen@aarsen.me> <9dd976a4-4e09-d901-b949-6d5037567b9b@codesourcery.com> <86sfed63l6.fsf@aarsen.me> <1db33a21-4645-1c63-faf2-4048be07c323@siemens.com> From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: Sandra Loosemore Cc: Sandra Loosemore , gcc-patches@gcc.gnu.org, Gerald Pfeifer , Joseph Myers Subject: Re: [PATCH v2 1/5] docs: Create Indices appendix Date: Sat, 11 Mar 2023 02:34:45 +0100 In-reply-to: <1db33a21-4645-1c63-faf2-4048be07c323@siemens.com> Message-ID: <87bkl0nje6.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Rspamd-Queue-Id: 4PYQtd6YrLz9sSL X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sandra Loosemore writes: > On 3/9/23 13:38, Arsen Arsenovi=C4=87 wrote: >> Found the change. HTML got support for CONTENTS_OUTPUT_LOCATION, >> which defaults to after_top, which ignores the inline location of >> these elements. Here's a patch: >> maintainer-scripts/ChangeLog: >> * update_web_docs_git: Set CONTENTS_OUTPUT_LOCATION=3Dinline in >> order to put @shortcontents above contents. See >> 9dd976a4-4e09-d901-b949-6d5037567b9b@codesourcery.com on >> gcc-patches. > > I don't think this is an adequate fix. We mere mortals build the manuals= with > "make html" etc instead of the maintainer scripts for the web site, so we= need > a solution that we can put either in the Makefile or directly in the .texi > files, that won't blow up for older versions of Texinfo that don't suppor= t this > thing. Hm, I've forgotten about that. AFAICT, the only way to specify this customization variable is through makeinfo flags. It'd seem that unrecognized variables produce a warning, though, so at least building with older versions won't fail. We could probably test for whether -c CONTENTS_OUTPUT_LOCATION produces no warning, and if so, pass an extra flag in the makefile, or just accept the warning on older versions (before 6.8). Those, IIUC, should behave as if CONTENTS_OUTPUT_LOCATION is set to inline, but I haven't tested that (it's getting quite late). Also worth noting is that the contents come before the top node when set up like this. It might be nice to gate that behind @ifhtml or such. Maybe we should also consider suggesting that texi2any places @shortcontents first in after_top mode. I can handle that if you think that's reasonable. I'll send the updated patch in the morning. > -Sandra Thanks, have a lovely night. =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIYEARYKAC4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZAvfERAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosST7AABAMU8SVAe5iLDbd3DjgFtpQ1l8O+m7zV03RTJ ClJVzsgXAP9fngp5EQJSJdnxTFXHKJEvzXtCmwmUrBwAW10AgfNqDQ== =5iqQ -----END PGP SIGNATURE----- --=-=-=--