From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 028073858C5E for ; Thu, 9 Mar 2023 09:51:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 028073858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3297edpw018258; Thu, 9 Mar 2023 09:51:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=duX5GHTer+XOerePsse5XHdqKrXvidmt4jsztCupt+k=; b=I9ufD6XcCvXOvx30ClO4FVa2gSwZWXs/LNLhTHCM6lN465U/hF68xMkdaV+QLdzfeF+V EtNoEsVsYdoIDPo+UaHqG391FmzBsR1BqnRnC2ES3cfJf00bVXundjo+AlrVLuuwCKCf 7ywTD5qc2WsQX4NHZEz6bQqWZ4rnNRMC3FrVz0+ecXRyafU4n2ZnqTyJTpf2sHBoSORt zsjEccMqJusj3/CxZibSKmy+93saJwtnfJ9upxkscXCwLrT1VovFuec0KGxiFkyaJztJ U2uY05jAFZb/Im1dhRmn92E5qdYHKfbraKtn/M9J0rgznequg0v3J6Jf4Edh23sJ1nLt zA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3p5nn96kqg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Mar 2023 09:51:20 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 3298Kli5007287; Thu, 9 Mar 2023 09:51:19 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3p6g4h110n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Mar 2023 09:51:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LYqj2n7pDwdLFRNB0M53cZCBIAlf+0qlshjyw165pJN1ZCoBtX44x1aN74xXPrUD+DKHFJnLSGDS/2JOrkt46K+b8L5VLIB8DOGYzCIzLTBWg5WRE9ldXyE+quOs2/vuroslvliWUWcN15oWTTcdv/b+/Syf90hJZV/e9cpFYtXzvHImDHJyrV73bWd+yTUJbWsAo3rj7CRv7x4uXKw/RJ8ZgXec8YFkIQR8mk+o1OJvk+T/TEFnjgFO9u5Su9LUnt4H56CNsv9hmkch687x1PQEz7VAu5sZEN64OLgla8HoCOwNqZXXiL/bFTAFL2SjagEZ98cCB8mjotoqqobsKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=duX5GHTer+XOerePsse5XHdqKrXvidmt4jsztCupt+k=; b=lgPcMAAGnh0ZWLmmonLEBHK7HR47T7P5G/YNfE0mdtFg4Tgdp8DS4yfmIhSDpU/USWXocRaBze/nPMGrJG8wSeZzVgmHQ2wA8qCMubTdc+mmKSmxxh/d2kmaGsdl6qZ5zpkd41/PwpL1XXIEhxov1tEdgAynU9RR2x/vyLLukmKGXFPBc4XwFo8KmkGmUQBinvfPHDIGJ/Zk5KxD2C8mRS+Gw4xW64z46zHeb/Pa/0YkICbmbF3nJtiB7rzujSPYdjiuxiw8+6rxgnZZaKzQBsh+JAZasTJttlxTr20Gleb6v0TfLKZFQep7HpJqGZ+mwpon82QtDtljsDaiXq/V7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duX5GHTer+XOerePsse5XHdqKrXvidmt4jsztCupt+k=; b=sZRtjaTWxWMHSnZ4Mkv94l12DuQIngWzTMvzGyre16R7gJYvklr8Vyu5mGbtXFe6525EUILCpys1etY/8eZTAYsvne09p9YJcv3D9NfNq60GSFdiWnJC8waqn3pEbRX7//A9wXhhBz+equLk/1mmbPYuqvrCtgfXd5/T4tMIAdQ= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by CO6PR10MB5790.namprd10.prod.outlook.com (2603:10b6:303:145::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.17; Thu, 9 Mar 2023 09:51:17 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728%6]) with mapi id 15.20.6156.023; Thu, 9 Mar 2023 09:51:17 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-3-cupertino.miranda@oracle.com> <795fde7f-5bde-d1a5-e790-b15774effd1c@gmail.com> <875yen5ib4.fsf@oracle.com> <87h6wg15np.fsf@oracle.com> <87v8knax2p.fsf@oracle.com> <87wn4tajir.fsf@oracle.com> <87o7psbbuk.fsf@oracle.com> <87v8jn9zus.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Jeff Law Cc: Cupertino Miranda , jose.marchesi@oracle.com, gcc-patches@gcc.gnu.org Subject: Re: [PING, PING] Re: [PATCH 2/2] Corrected pr25521.c target matching. In-reply-to: <87v8jn9zus.fsf@oracle.com> Date: Thu, 09 Mar 2023 09:51:11 +0000 Message-ID: <87bkl245io.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: AM9P195CA0010.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:21f::15) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|CO6PR10MB5790:EE_ X-MS-Office365-Filtering-Correlation-Id: 7abdd52b-2451-4bfb-86de-08db2083d3be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ++oIzWIEESOaVfmW8sqhQRXMu7hBAsQwES8Ch5zvycdWC4k553DF5wVbeQJdwgrozMF8UKVYKQTCGYNsgGtRoLtxHNm54TiJoZerP5q9ejDHJwb+jO8ZS1CtdFiT+whTUqLJn0F9yuzClo7kqCquBa92BiHetKpGS3keMYutKyGjK7WX3YKMLs9iG2622JhKsQl2mIlb4pIhVWpBgR+Kr5SN5eThVKK+lWgt0jsC3D89ARvIF5g1QT7ubHl9kU2aIAnKOMezLbbhxO1Ibuw1nDSSnHNL3NZNRMrJR8i80jYU4T1GTccUOvartrxLb+iUIqcj1YW8mLfhOAFENkTkG9vGig5F6cwtIhb1hUYWG1OQxdR3LuiGzUD1kZWyFg9AEiw41JCeLCO6KK8w4uXshh+eTUoncwPRk5T/KvUmkKzcDe7Jug1LzOdHV2dPItEbvcgxg6BzGRkZTyn40oqbUNMSzjDRHOVwWdf80OBBWRMzaFuDo2Kt9Yq1Mn08mIm1pF1wGgHpflnFuezmNw3J+LhFc2s9aCAyyKHjMfWwslVc2l9It2xRrRIPUSSAUUmC7vH2yKCxLFXFFPCzL/7g3QppocDRRhfh6zWJBFmIPFdVDYKHUX6vYcyAns0WEh32YduV8/yLpvj/DZKy3VqbKg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(39860400002)(396003)(376002)(136003)(451199018)(83380400001)(478600001)(36756003)(186003)(38100700002)(66556008)(66476007)(44832011)(66946007)(4326008)(8676002)(6916009)(6512007)(2906002)(6506007)(53546011)(2616005)(6666004)(5660300002)(316002)(6486002)(41300700001)(8936002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7+6+kzKYOOEKU5yfEAKyjYMJhZSy7LiHBTJLjKvkW7cZK0be5H/x2D/9VNnv?= =?us-ascii?Q?AwcnEq3UCN/MTDv8x2/LzZeGuL3oFU4i1PHz0dH64TPnO0wMgxvWvvLf2cCc?= =?us-ascii?Q?8EzFlYtu0194HplZzRpzNnZsDWcVTwvlv0lrE2ejbQqSvZBhaVoVDGr5pozL?= =?us-ascii?Q?XAPwpyw+3PFeLOzMb52Ua/W8reTxHQ6gOGW/FGkvQNBTx4V8zs4G3lje1jOH?= =?us-ascii?Q?KvD7KNTu7HMd1LMSXNyGrSQLiW/A8NAXPKKzQLRLGhZ5KSEltWM69euT5RQr?= =?us-ascii?Q?4euHEcpNU8r9sUUy40gPn0+5lCnTCUCNWXKHprGTggrCphRco3aGFb/r7mmq?= =?us-ascii?Q?GYQ3bRX8jhi7fP1dU5KiQQBodEowld72sCnqDJwmFXafgLkoqlBMICnEpy6d?= =?us-ascii?Q?RqDF5zC7nVR/Bm9oPxjpX8aySOC8t36ALciO9/QnVhbRtcvWsbBEQnTW7JOw?= =?us-ascii?Q?ZVD04j5BToNkn1VmqjPk18B9pxQMMNCklC7SW4WhcnloUqK6KTHSLE+wssi8?= =?us-ascii?Q?eB4TWkR2SD9+6Bl5DQSBf1xegDVbJNc+hRoV2X6tjjKi6mRXsK1Hw2sZwheB?= =?us-ascii?Q?QDg/9ldUZt7sslJ9UQ6fJSdPWinoX7OkTwj+/ywg/Z56wgm0BFnhsv60jFVB?= =?us-ascii?Q?aop+XDQnL8xRV9gfqMIo3633uT3Mmdi5mKSutdmHR200COf5uoSI71IRvg0N?= =?us-ascii?Q?6atkqwhyKQ9taZ23koKUfDZJB749maJAVSzyw/8MOwxVIJNhQlUbjnM8tzJC?= =?us-ascii?Q?mvYruJZG/P3FZPQIz11GM/dMeG3GgguIOWqn/Ze7STnxU4V0d5MaCuZINJby?= =?us-ascii?Q?Ufi6zeRR/hGeOUfsz7NtINlEJr/jGJ7GXobPBVpc7LXuibDeCzL+e8KJnYPC?= =?us-ascii?Q?qyTRvWh8yJtLWWLddGU6PoCFSuMs7pL8vYFS2R4LxlFLuH8YHcmPE/JMlEZT?= =?us-ascii?Q?NuJwUTOZjAFy3XCy3bVJKWOkH4E14694YO3ustSNC6PMeRWtbCGavV4GJIxF?= =?us-ascii?Q?pByd4YowwmQc2z6+cB1WAygkZ9M22m9rNbHe1Nbe0TyuzVnGx1RSYW3HDXCA?= =?us-ascii?Q?3xT51a8FctDmU1dn04m+zALnGtsNUXOck6N5JXTjDKc736C4UajaYSYmpr3X?= =?us-ascii?Q?j9T+FoGEzFyOJ5+3t5opcdLyqw0DWBCTCbw8jXqB2+Oc/BARWpDl8TY1q5Ya?= =?us-ascii?Q?PKu1jI/Pq+L9ZAbjRqzrPRitccYNXl1Lh3Yv1GTkToebGLiW5PoCex3aFLF5?= =?us-ascii?Q?xTdDHPEBoRg7xcpFQ3OYHboFBBCyOwUhkSOodehpPgbJXlpcjYbxsyI42Gps?= =?us-ascii?Q?1ipXF/r654qcbLZNWvHPvdh+65v68kdBLfb+l3kMKPtExOd9nhWeZ+7jV/3S?= =?us-ascii?Q?zAptsTfz+FgiVv+LqLHf/38DAze3n86V3FWXAE/Rz5VDhavgfvcvUJU/sXrY?= =?us-ascii?Q?V1MyUF/USgUNeJWCju4IaPa91X+iEa6ItcmL8IYwxn2MlJk4z7EKEH0u0sv9?= =?us-ascii?Q?bqMJyJYU8VmUdD+lg2AynscgqNGCqtJK7G30+Ly6nkpF3ZwoOfEbJPnZ9YIA?= =?us-ascii?Q?hIEl/g07eZvkEjfIxdee5HjkDChNiWjixU3ux51KP3wF8/OWmHVi+x/M5mmF?= =?us-ascii?Q?/D/7vSGXbGjhLl5FLUlG4V9cahjZS9mvLtyqDtyjcIvR?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: t1p8fwF9DjIcxJKkadKhq/GV+jbdBYhY0CpYZlUsqko8tB2IMBOVLHnLdJHEKBqG6oSp8fdKFPc5V5Sq3zJsCziRPbFMle62V8HXnlWrsprkFZq3m6WX8/NAaBK6gsb4CdH2CyoljgReTk9AF7mPxeZ78m8KmLM2ZY/8Cc7kFywherGkBxzJB5gm7w3fGhBspuGwdzOo2IUOT2K+Bk83RVexDOmlW5XalctyVUsMJy+Fozdpxjs911OLg9Lnr1/Rf4jyVXhwWSSgmmz4/4NXzhEG2Rd8EM9fiihoDwaYVmwWQ3VIaA7fLdLPUFYv2QNGOuwCYWZPr7G/P8CIaMlZUA6vlMEZihRWQd5yuTFWO2LcjR4ZUFQjvGuykeUKOdGV4tyRQLOn0FQD1/7luIuy6XJu4+DQ3fmdPqq8C7aiTQr0sMRf+Y3kLUv/lK97BNRI/vtdN33qqrjjfXd6u34LgNq9Qik6BEB9kd1nxQRe2aqXgF+Pwa5+oIsQZxeAnnzrR1VW3SB88YYV6qwE5dp1sVVjYx8G745GF1d1gosV0ztIxnB9qioyxC8te9RJJdeE8q5nb/+gtWhKbz2k2ddP/z+oUIJGIRpQwFb/9AYdTLFRIbAS8VHIl92vTaxnXVoHp8CbZ7N2z5jOccNTYcK5d38CzdwO4y3CIAV1qsbi7pxMFamev+dpNWueSRWpBmo8GQ6k6ZCqeZwVtiC08a2B9oUNinu1SxYrNrl90/S2WxAyCvxprzItnN4WyntoMex6kmyAhUVnTlqaU/eWR6x+4g== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7abdd52b-2451-4bfb-86de-08db2083d3be X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 09:51:17.0371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MPtn+edigJwCvqViS2tukW+nAZMbom+9b5YThAdG/MNfn+G4gr3IxlmysQCjrY+7QAs1yNA5r7CK/J1jeq++Z7lfMPVcWi2hxY5FIkXUDlY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5790 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-09_06,2023-03-08_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303090077 X-Proofpoint-GUID: 2dd8jb43uxnYDtcB0YGLPTwv7M0kntji X-Proofpoint-ORIG-GUID: 2dd8jb43uxnYDtcB0YGLPTwv7M0kntji X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [PING] Cupertino Miranda writes: > Hi Jeff, > > Please, please, give me some feedback on this one. > I just don't want to have to keep asking you for time on this small > pending patches that I also have to keep track on. > > I realized your committed the other one. Thank you ! > > Best regards, > Cupertino > > > Cupertino Miranda writes: > >> PING !!!!! >> >> Cupertino Miranda via Gcc-patches writes: >> >>> Hi Jeff, >>> >>> Can you please confirm if the patch is Ok? >>> >>> Thanks, >>> Cupertino >>> >>>> Cupertino Miranda via Gcc-patches writes: >>>> >>>>> Thank you for the comments and suggestions. >>>>> I have changed the patch. >>>>> >>>>> Unfortunately in case of rx target I could not make >>>>> scan-assembler-symbol-section to match. I believe it is because the >>>>> .section and .global entries order is reversed in this target. >>>>> >>>>> Patch in inlined below. looking forward to your comments. >>>>> >>>>> Cupertino >>>>> >>>>> diff --git a/gcc/testsuite/gcc.dg/pr25521.c b/gcc/testsuite/gcc.dg/pr25521.c >>>>> index 63363a03b9f..82b4cd88ec0 100644 >>>>> --- a/gcc/testsuite/gcc.dg/pr25521.c >>>>> +++ b/gcc/testsuite/gcc.dg/pr25521.c >>>>> @@ -2,9 +2,10 @@ >>>>> sections. >>>>> >>>>> { dg-require-effective-target elf } >>>>> - { dg-do compile } */ >>>>> + { dg-do compile } >>>>> + { dg-skip-if "" { ! const_volatile_readonly_section } } */ >>>>> >>>>> const volatile int foo = 30; >>>>> >>>>> - >>>>> -/* { dg-final { scan-assembler "\\.s\?rodata" } } */ >>>>> +/* { dg-final { scan-assembler {.section C,} { target { rx-*-* } } } } */ >>>>> +/* { dg-final { scan-assembler-symbol-section {^_?foo$} {^\.(const|s?rodata)} { target { ! "rx-*-*" } } } } */ >>>>> diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp >>>>> index c0694af2338..91aafd89909 100644 >>>>> --- a/gcc/testsuite/lib/target-supports.exp >>>>> +++ b/gcc/testsuite/lib/target-supports.exp >>>>> @@ -12295,3 +12295,13 @@ proc check_is_prog_name_available { prog } { >>>>> >>>>> return 1 >>>>> } >>>>> + >>>>> +# returns 1 if target does selects a readonly section for const volatile variables. >>>>> +proc check_effective_target_const_volatile_readonly_section { } { >>>>> + >>>>> + if { [istarget powerpc-*-*] >>>>> + || [check-flags { "" { powerpc64-*-* } { -m32 } }] } { >>>>> + return 0 >>>>> + } >>>>> + return 1 >>>>> +} >>>>> >>>>> >>>>> Jeff Law writes: >>>>> >>>>>> On 12/7/22 08:45, Cupertino Miranda wrote: >>>>>>> >>>>>>>> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>>>>>>>> This commit is a follow up of bugzilla #107181. >>>>>>>>> The commit /a0aafbc/ changed the default implementation of the >>>>>>>>> SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the >>>>>>>>> placement of `const volatile' objects. >>>>>>>>> However, the following targets use target-specific selection functions >>>>>>>>> and they choke on the testcase pr25521.c: >>>>>>>>> *rx - target sets its const variables as '.section C,"a",@progbits'. >>>>>>>> That's presumably a constant section. We should instead twiddle the test to >>>>>>>> recognize that section. >>>>>>> Although @progbits is indeed a constant section, I believe it is >>>>>>> more interesting to detect if the `rx' starts selecting more >>>>>>> standard sections instead of the current @progbits. >>>>>>> That was the reason why I opted to XFAIL instead of PASSing it. >>>>>>> Can I keep it as such ? >>>>>> I'm not aware of any ongoing development for that port, so I would not let >>>>>> concerns about the rx port changing behavior dominate how we approach this >>>>>> problem. >>>>>> >>>>>> The rx port is using a different name for the section. That's valid thing to >>>>>> do and to the extent we can, we should support that in the test rather than >>>>>> (incorrectly IMHO) xfailing the test just becuase the name isn't what we >>>>>> expected. >>>>>> >>>>>> To avoid over-eagerly matching, I would probably search for "C," I wouldn't do >>>>>> that for the const or rodata sections as they often have a suffix like 1, 2, 4, >>>>>> 8 for different sized rodata sections. >>>>>> >>>>>> PPC32 is explicitly doing something different and placing those objects into an >>>>>> RW section. So for PPC32 it makes more sense to skip the test rather than xfail >>>>>> it. >>>>>> >>>>>> Jeff