From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 4F46C3858C51 for ; Tue, 12 Jul 2022 06:34:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4F46C3858C51 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.92,265,1650960000"; d="scan'208,223";a="78563589" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 11 Jul 2022 22:33:43 -0800 IronPort-SDR: zrvh4TGsQxFPZIF8zKYcbjucUm51RyJBa0pqRa5uz6VbyF6OR1y6hMy69tqUh0bvLHEi9lB+bm AeoBu9mvNJtcC2XvYit9BXzZLkZBgLuQ+hOBtdyX0aT7v6/2hsfzzJWgKBnHXf/7LMdMtocT3b DYgVIRQ3Lwerq1KiLGdr7n3LnY81nz2VoUHRh5R1l2zC3dhheeDyA3L9Oly9fg6e+bMRDHWNAY +JFfNT12Bn7eVCFXL/NUiycjXqdCNpsycfwD4BmQOQcSnWcPzWyV8defXHX2rZb8W4Y/jUq6MQ cr0= From: Thomas Schwinge To: Subject: XFAIL 'offloading_enabled' diagnostics issue in 'libgomp.oacc-c-c++-common/reduction-5.c' [PR101551] (was: Enhance '_Pragma' diagnostics verification in OMP C/C++ test cases) In-Reply-To: <87edys3spb.fsf@euler.schwinge.homeip.net> References: <20220709205230.GA4991@ldh-imac.local> <377c7016-633c-f354-8c21-599ff2b56449@gmail.com> <87edys3spb.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Tue, 12 Jul 2022 08:33:33 +0200 Message-ID: <87bktu4z7m.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 06:34:03 -0000 --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi! On 2022-07-11T11:27:12+0200, I wrote: > [...], I've just pushed to master branch > commit 06b2a2abe26554c6f9365676683d67368cbba206 > "Enhance '_Pragma' diagnostics verification in OMP C/C++ test cases" > --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c > @@ -17,7 +17,7 @@ const int n =3D 100; > #define check_reduction(gwv_par, gwv_loop) \ > { \ > s1 =3D 2; s2 =3D 5; \ > -DO_PRAGMA (acc parallel gwv_par copy (s1, s2)) \ > +DO_PRAGMA (acc parallel gwv_par copy (s1, s2)) /* { dg-line DO_PRAGMA_lo= c } */ \ > DO_PRAGMA (acc loop gwv_loop reduction (+:s1, s2)) \ > for (i =3D 0; i < n; i++) \ > { \ > @@ -45,8 +45,10 @@ main (void) > > /* Nvptx targets require a vector_length or 32 in to allow spinlocks w= ith > gangs. */ > - check_reduction (num_workers (nw) vector_length (vl), worker); > - /* { dg-warning "region is vector partitioned but does not contain vec= tor partitioned code" "test1" { target *-*-* } pragma_loc } */ > + check_reduction (num_workers (nw) vector_length (vl), worker); /* { dg= -line check_reduction_loc } > + /* { dg-warning "22:region is vector partitioned but does not contain = vector partitioned code" "" { target *-*-* } pragma_loc } > + { dg-note "1:in expansion of macro 'DO_PRAGMA'" "" { target *-*-* }= DO_PRAGMA_loc } > + { dg-note "3:in expansion of macro 'check_reduction'" "" { target *= -*-* } check_reduction_loc } */ Oh my, PR101551 "[offloading] Differences in diagnostics etc." strikes again... The latter two 'note' diagnostics are currently only emitted in non-offloading configurations. I've now pushed to master branch commit 3723aedaad20a129741c2f6f3c22b3dd1220a3fc "XFAIL 'offloading_enabled' diagnostics issue in 'libgomp.oacc-c-c++-common/reduction-5.c' [PR101551]", see attached. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename="0001-XFAIL-offloading_enabled-diagnostics-issue-in-libgom.patch" >From 3723aedaad20a129741c2f6f3c22b3dd1220a3fc Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 12 Jul 2022 08:17:37 +0200 Subject: [PATCH] XFAIL 'offloading_enabled' diagnostics issue in 'libgomp.oacc-c-c++-common/reduction-5.c' [PR101551] Fix-up for recent commit 06b2a2abe26554c6f9365676683d67368cbba206 "Enhance '_Pragma' diagnostics verification in OMP C/C++ test cases". Supposedly it's the same issue as in , where I'd noted that: | [...] with an offloading-enabled build of GCC we're losing | "note: in expansion of macro '[...]'" diagnostics. | (Effectively '-ftrack-macro-expansion=0'?) PR middle-end/101551 libgomp/ * testsuite/libgomp.oacc-c-c++-common/reduction-5.c: XFAIL 'offloading_enabled' diagnostics issue. --- libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c index 72094609f0f..ddccfe89e73 100644 --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c @@ -45,10 +45,11 @@ main (void) /* Nvptx targets require a vector_length or 32 in to allow spinlocks with gangs. */ - check_reduction (num_workers (nw) vector_length (vl), worker); /* { dg-line check_reduction_loc } + check_reduction (num_workers (nw) vector_length (vl), worker); /* { dg-line check_reduction_loc } */ /* { dg-warning "22:region is vector partitioned but does not contain vector partitioned code" "" { target *-*-* } pragma_loc } - { dg-note "1:in expansion of macro 'DO_PRAGMA'" "" { target *-*-* } DO_PRAGMA_loc } - { dg-note "3:in expansion of macro 'check_reduction'" "" { target *-*-* } check_reduction_loc } */ + { dg-note "1:in expansion of macro 'DO_PRAGMA'" "" { target *-*-* xfail offloading_enabled } DO_PRAGMA_loc } + { dg-note "3:in expansion of macro 'check_reduction'" "" { target *-*-* xfail offloading_enabled } check_reduction_loc } + TODO See PR101551 for 'offloading_enabled' XFAILs. */ check_reduction (vector_length (vl), vector); check_reduction (num_gangs (ng) num_workers (nw) vector_length (vl), gang worker vector); -- 2.35.1 --=-=-=--