From: Richard Sandiford <richard.sandiford@arm.com>
To: Matthew Malcomson <matthew.malcomson@arm.com>
Cc: gcc-patches@gcc.gnu.org, richard.earnshaw@arm.com,
james.greenhalgh@arm.com, marcus.shawcroft@arm.com,
nd@arm.com
Subject: Re: [PATCH][GCC][AARCH64] Canonicalize aarch64 widening simd plus insns
Date: Thu, 12 Jul 2018 10:18:00 -0000 [thread overview]
Message-ID: <87bmbc7o67.fsf@arm.com> (raw)
In-Reply-To: <006edc68-c5a2-e77d-70d6-02ac77ef53e3@arm.com> (Matthew Malcomson's message of "Wed, 11 Jul 2018 11:36:27 +0100")
Looks good to me FWIW (not a maintainer), just a minor formatting thing:
Matthew Malcomson <matthew.malcomson@arm.com> writes:
> diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md
> index aac5fa146ed8dde4507a0eb4ad6a07ce78d2f0cd..67b29cbe2cad91e031ee23be656ec61a403f2cf9 100644
> --- a/gcc/config/aarch64/aarch64-simd.md
> +++ b/gcc/config/aarch64/aarch64-simd.md
> @@ -3302,38 +3302,78 @@
> DONE;
> })
>
> -(define_insn "aarch64_<ANY_EXTEND:su><ADDSUB:optab>w<mode>"
> +(define_insn "aarch64_<ANY_EXTEND:su>subw<mode>"
> [(set (match_operand:<VWIDE> 0 "register_operand" "=w")
> - (ADDSUB:<VWIDE> (match_operand:<VWIDE> 1 "register_operand" "w")
> - (ANY_EXTEND:<VWIDE>
> - (match_operand:VD_BHSI 2 "register_operand" "w"))))]
> + (minus:<VWIDE>
> + (match_operand:<VWIDE> 1 "register_operand" "w")
> + (ANY_EXTEND:<VWIDE>
> + (match_operand:VD_BHSI 2 "register_operand" "w"))))]
The (minus should be under the "(match_operand":
(define_insn "aarch64_<ANY_EXTEND:su>subw<mode>"
[(set (match_operand:<VWIDE> 0 "register_operand" "=w")
(minus:<VWIDE> (match_operand:<VWIDE> 1 "register_operand" "w")
(ANY_EXTEND:<VWIDE>
(match_operand:VD_BHSI 2 "register_operand" "w"))))]
Same for the other patterns.
Thanks,
Richard
next prev parent reply other threads:[~2018-07-12 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 10:36 Matthew Malcomson
2018-07-12 10:18 ` Richard Sandiford [this message]
2018-07-12 10:39 ` Sudakshina Das
2018-07-19 12:35 ` Matthew Malcomson
2018-07-24 15:12 ` James Greenhalgh
2018-07-24 15:39 ` Kyrill Tkachov
2018-07-30 13:30 ` Christophe Lyon
2018-07-30 13:58 ` Kyrill Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmbc7o67.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=james.greenhalgh@arm.com \
--cc=marcus.shawcroft@arm.com \
--cc=matthew.malcomson@arm.com \
--cc=nd@arm.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).