From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16686 invoked by alias); 13 Jun 2017 06:59:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14795 invoked by uid 89); 13 Jun 2017 06:59:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f178.google.com Received: from mail-wr0-f178.google.com (HELO mail-wr0-f178.google.com) (209.85.128.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 06:59:32 +0000 Received: by mail-wr0-f178.google.com with SMTP id g76so124218460wrd.1 for ; Mon, 12 Jun 2017 23:59:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:mail-followup-to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version; bh=wub/c65TCW6gKLR2XkD3dMQQQH/sKWyYcdpYz4V6BM4=; b=MCeSzdQrpOUAyBf7B6glirKk766Y4Cbyx8ydzXjlXkpmRAqqdu2Ae3hOH8+UIeFOD6 cZDeYmuF/rZrH9mCn38i1sK+OHgqYe6kVOYo7vg2thCVN5KkhqWmjvsiBgSMAeRJwLXw AsulsFFkBxidzQ8P14sTI/sVGiWDyAf3iz7ETWWdjRZXfPmheogG0lS9e1T4jC6suL/Q BRI5Ah2t9rBHB5hmLqHlKLCvHFnEk0PAkkO/Vjm+OZ3gZIL9huoKgjSt75NjKpW7Mxeb ck9C++dbSuALBWhiUHVhRxUzEak+rAxC/1FB7BWSOo2ZZzF73+LyVuxHLy0aExwRk94g md1w== X-Gm-Message-State: AKS2vOyokcHv9+EhDYhFA0+VyBU7/3eK/a4ExmsEjDJ39BFNCNhQexRW 8979xFmQgqsM7P+5 X-Received: by 10.223.164.80 with SMTP id e16mr1886826wra.100.1497337171566; Mon, 12 Jun 2017 23:59:31 -0700 (PDT) Received: from localhost (92.40.249.225.threembb.co.uk. [92.40.249.225]) by smtp.gmail.com with ESMTPSA id r24sm9093296wrc.16.2017.06.12.23.59.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Jun 2017 23:59:30 -0700 (PDT) From: Richard Sandiford To: Pedro Alves Mail-Followup-To: Pedro Alves ,Tom de Vries , GCC Patches , Jakub Jelinek , Rainer Orth , Mike Stump , richard.sandiford@linaro.org Cc: Tom de Vries , GCC Patches , Jakub Jelinek , Rainer Orth , Mike Stump Subject: Re: [RFC] Dejagnu patch to handle multi-line directives References: <87mv9dskk4.fsf@linaro.org> Date: Tue, 13 Jun 2017 06:59:00 -0000 In-Reply-To: (Pedro Alves's message of "Mon, 12 Jun 2017 19:54:41 +0100") Message-ID: <87bmpsfk4v.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-06/txt/msg00861.txt.bz2 Pedro Alves writes: > On 06/12/2017 08:59 AM, Richard Sandiford wrote: >> I realise there's probably more that can go wrong with it, but how >> about instead treating unbalanced { ... } as a sign that the directive >> continues to the next line? This would allow: >> >> /* { dg-additional-options >> "-DSTACK_SIZE=[dg-effective-target-value stack_size]" >> { target { stack_size } } } */ > > In a TCL .exp file you'd split the lines with a '\' continuation > character. Wouldn't that be more natural? Like: > > /* { dg-additional-options \ > "-DSTACK_SIZE=[dg-effective-target-value stack_size]" \ > { target { stack_size } } } */ It'd be more normal to omit \ in a braced list though, so I think the version without is more natural Tcl style. > Might be less magical and simpler to implement too. The reason I avoided \ was because it's a "native" continuation marker for C and C++, but not for Fortran, Ada and others. So using \ would change the way the comment is treated by some front ends and not others. E.g. things like: // a \ // b trigger: warning: multi-line comment [-Wcomment] (Maybe moot anyway given Mike's response.) Thanks, Richard