From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34600 invoked by alias); 23 Nov 2015 07:46:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 34583 invoked by uid 89); 23 Nov 2015 07:46:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Nov 2015 07:46:49 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1a0lpm-0003mQ-0d from Thomas_Schwinge@mentor.com ; Sun, 22 Nov 2015 23:46:46 -0800 Received: from tftp-cs (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.224.2; Sun, 22 Nov 2015 23:46:45 -0800 Received: by tftp-cs (Postfix, from userid 49978) id 2C81DC229E; Sun, 22 Nov 2015 23:46:45 -0800 (PST) From: Thomas Schwinge To: Bernd Schmidt , Nathan Sidwell , Jakub Jelinek CC: GCC Patches Subject: Re: [ptx] partitioning optimization In-Reply-To: <56464673.3060702@redhat.com> References: <564270D6.6090303@acm.org> <56432F50.6000208@redhat.com> <564349B5.5050202@acm.org> <56434E7D.4070803@redhat.com> <564642E0.6090303@acm.org> <56464673.3060702@redhat.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (i586-pc-linux-gnu) Date: Mon, 23 Nov 2015 07:47:00 -0000 Message-ID: <87bnalrwdl.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2015-11/txt/msg02643.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 2041 Hi! On Fri, 13 Nov 2015 21:22:11 +0100, Bernd Schmidt wro= te: > On 11/13/2015 09:06 PM, Nathan Sidwell wrote: > > On 11/11/15 09:19, Bernd Schmidt wrote: > >> On 11/11/2015 02:59 PM, Nathan Sidwell wrote: > >>> That's not the problem. How to conditionally enable the test is the > >>> difficulty. I suspect porting something concerning accel_compiler fr= om > >>> the libgomp testsuite is needed? > >> > >> Maybe a check_effective_target_offload_nvptx which tries to see if > >> -foffload=3Dnvptx gives an error (I would hope it does if it's > >> unsupported). > > > > This patch seems to do the trick. tested on an offload-aware build > > (passes), and a regular x86_64-linux build (skipped as unsupported). Thanks for adding such tests! > I think this is fine. I may have pointed this out before a few times... ;-) -- -- this doesn't work for build-tree testing ("make check"), if GCC has not yet been installed ("make install"), which is still the default testing procedure as far as I know. spawn [...]/build-gcc/gcc/xgcc -B[...]/build-gcc/gcc/ [...]/source-gcc/= gcc/testsuite/gcc.dg/goacc/nvptx-merged-loop.c -fno-diagnostics-show-caret = -fdiagnostics-color=3Dnever -fopenacc -O2 -foffload=3D-fdump-rtl-mach -dump= base nvptx-merged-loop.c -Wa,--no-verify -ffat-lto-objects -lm -o nvptx-mer= ged-loop.exe xgcc: error: libgomp.spec: No such file or directory compiler exited with status 1 [...] FAIL: gcc.dg/goacc/nvptx-merged-loop.c (test for excess errors) [...] UNRESOLVED: gcc.dg/goacc/nvptx-merged-loop.c scan-rtl-dump mach "Mergin= g loop .* into " Here, -fopenacc induces -lgomp. So, we'll either need a (dummy?) libgomp available to link against in gcc/testsuite/, or come up with a way to do LTO/offloading compilation without actually linking (libgomp into) the final executable, or move such tests into libgomp/testsuite/. (Jakub?) Gr=C3=BC=C3=9Fe Thomas --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWUsRWAAoJEK3/DN1sMFFt/VcH/Aq98OZYeJ5RkJYd2G0n4ScL cI4AC+4kyLjgUziPC/vGPBcCZo7k8gCPNvgP5MIIcFH3F/oayx121MhzDiCVT0fI 0ID98j4DkGhNpW9sVf17rbY6hZy+deJd+82yRI/KPkmefbVOiROYY8SQWjQOghQj 80hmtqNqMWMt5jRx2dLbwJFkfNbdRJjYJSXjh4vultghbp7tCVBIuOA5rTDr+MnT d6JMhp1NapvKh8ehqSKpj43YtVSHuywvorz6WrHC+K1CQTeO/6ZTidfrmQUWaE15 rUL+D9Ywo2/j+wCTX2z5Z5pzud9xTl27ZytYTlLZoKPcgY45JS0riN5VgCurj8A= =O70J -----END PGP SIGNATURE----- --=-=-=--