From: Richard Sandiford <rdsandiford@googlemail.com>
To: Jeff Law <law@redhat.com>
Cc: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Subject: Re: Fix reload1.c warning for some targets
Date: Thu, 13 Aug 2015 20:33:00 -0000 [thread overview]
Message-ID: <87bnebc4or.fsf@googlemail.com> (raw)
In-Reply-To: <55CB7F88.5040104@redhat.com> (Jeff Law's message of "Wed, 12 Aug 2015 11:16:56 -0600")
Jeff Law <law@redhat.com> writes:
> On 08/05/2015 08:18 AM, Richard Sandiford wrote:
>> Building some targets results in a warning about orig_dup[i] potentially
>> being used uninitialised. I think the warning is fair, since it isn't
>> obvious that the reog_data-based loop bound remains unchanged between:
>>
>> for (i = 0; i < recog_data.n_dups; i++)
>> orig_dup[i] = *recog_data.dup_loc[i];
>>
>> and:
>>
>> for (i = 0; i < recog_data.n_dups; i++)
>> *recog_data.dup_loc[i] = orig_dup[i];
>>
>> Tested on x86_64-linux-gnu. OK to install?
>>
>> Thanks,
>> Richard
>>
>> gcc/
>> * reload1.c (elimination_costs_in_insn): Make it obvious to the
>> compiler that the n_dups and n_operands loop bounds are invariant.
> So thinking more about this, I think the best way forward is to:
>
> 1. Create a new BZ with the false positive extracted from c#4.
>
> 2. Install your patch and close 55035.
>
> I'll take care of #1, you can handle #2.
Thanks, I've now done #2.
Richard
next prev parent reply other threads:[~2015-08-13 20:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 14:18 Richard Sandiford
2015-08-05 17:01 ` Jeff Law
2015-08-05 17:33 ` Richard Sandiford
2015-08-11 20:05 ` Jeff Law
2015-08-12 17:17 ` Jeff Law
2015-08-13 20:33 ` Richard Sandiford [this message]
2015-08-13 21:08 ` Jeff Law
2015-08-24 11:05 ` Rainer Orth
2015-09-03 8:50 ` Richard Sandiford
2015-09-04 20:16 ` Jeff Law
2015-09-10 19:33 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnebc4or.fsf@googlemail.com \
--to=rdsandiford@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).