From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106653 invoked by alias); 18 Jul 2015 15:38:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 106629 invoked by uid 89); 18 Jul 2015 15:38:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 18 Jul 2015 15:38:36 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1ZGUC8-0006MT-TW from Thomas_Schwinge@mentor.com ; Sat, 18 Jul 2015 08:38:32 -0700 Received: from tftp-cs (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.224.2; Sat, 18 Jul 2015 08:38:32 -0700 Received: by tftp-cs (Postfix, from userid 49978) id B9F16C22F4; Sat, 18 Jul 2015 08:38:31 -0700 (PDT) From: Thomas Schwinge To: Nathan Sidwell CC: GCC Patches , Jakub Jelinek Subject: Re: [gomp] Move openacc vector& worker single handling to RTL In-Reply-To: <559F10F2.9050102@acm.org> References: <5597120D.2080308@acm.org> <20150703231159.GP10247@tucnak.redhat.com> <559844EF.6010208@acm.org> <559AD85B.2050102@acm.org> <20150707095408.GD10247@tucnak.redhat.com> <559BDE68.9010302@acm.org> <20150707142229.GG10247@tucnak.redhat.com> <559D381C.7020804@acm.org> <20150708145822.GB10247@tucnak.redhat.com> <559D9A29.2020409@acm.org> <559F10F2.9050102@acm.org> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Sat, 18 Jul 2015 20:31:00 -0000 Message-ID: <87bnf9v5ma.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2015-07/txt/msg01602.txt.bz2 --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 5629 Hi Nathan! On Thu, 09 Jul 2015 20:25:22 -0400, Nathan Sidwell wrote: > This is the patch I committed. [...] Prompted by your recent "-O0 patch" to =C2=BB[f]ix PTX worker spill/fill=C2= =AB, I used the attached patch 0001-O0-libgomp-C-C-testing.patch to run all C and C++ libgomp testing with -O0 (for Fortran, we iterate through various kinds of optimization levels anyway). (There are no regressions of OpenMP testing.)=20=20 For OpenACC nvptx offloading, there must still be something wrong; here's a count of the (non-deterministic!) regressions of ten runs of the libgomp testsuite. As private-vars-loop-worker-5.c fails most often, it probably makes sense to look into that one first. For avoidance of doubt, there are no such regressions if I un-apply your patch to =C2=BB[m]ove openacc vector& worker single handling to RTL=C2=AB. libgomp.oacc-c: 3: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-local-worker-1.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 = execution test 4: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-local-worker-2.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 = execution test 3: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-local-worker-3.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 = execution test 5: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-local-worker-4.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 = execution test 4: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-local-worker-5.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 = execution test 3: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-loop-vector-1.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 e= xecution test 2: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-loop-vector-2.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 e= xecution test 3: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-loop-worker-2.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 e= xecution test 2: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-loop-worker-3.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 e= xecution test 2: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-loop-worker-4.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 e= xecution test 8: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-loop-worker-5.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 e= xecution test 4: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-loop-worker-6.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 e= xecution test 4: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/priva= te-vars-loop-worker-7.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 e= xecution test 1: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/worke= r-partn-5.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 execution test 3: [-PASS:-]{+FAIL:+} libgomp.oacc-c/../libgomp.oacc-c-c++-common/worke= r-partn-6.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 execution test libgomp.oacc-c++: 5: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-local-worker-1.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D= 0 execution test 5: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-local-worker-2.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D= 0 execution test 4: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-local-worker-3.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D= 0 execution test 5: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-local-worker-4.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D= 0 execution test 6: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-local-worker-5.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D= 0 execution test 3: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-loop-vector-1.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0= execution test 2: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-loop-worker-2.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0= execution test 4: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-loop-worker-3.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0= execution test 4: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-loop-worker-4.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0= execution test 7: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-loop-worker-5.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0= execution test 4: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-loop-worker-6.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0= execution test 5: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/pri= vate-vars-loop-worker-7.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0= execution test 1: [-PASS:-]{+FAIL:+} libgomp.oacc-c++/../libgomp.oacc-c-c++-common/wor= ker-partn-6.c -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 execution t= est Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-O0-libgomp-C-C-testing.patch Content-Transfer-Encoding: quoted-printable Content-length: 2038 =46rom a527ce3bcb60a4dbd8feb579dd90688b33760d78 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Fri, 17 Jul 2015 15:24:19 +0200 Subject: [PATCH] -O0 libgomp C, C++ testing --- libgomp/testsuite/libgomp.c++/c++.exp | 1 + libgomp/testsuite/libgomp.c/c.exp | 1 + libgomp/testsuite/libgomp.oacc-c++/c++.exp | 1 + libgomp/testsuite/libgomp.oacc-c/c.exp | 1 + 4 files changed, 4 insertions(+) diff --git a/libgomp/testsuite/libgomp.c++/c++.exp b/libgomp/testsuite/libg= omp.c++/c++.exp index d6d525a..6bdb83d 100644 --- a/libgomp/testsuite/libgomp.c++/c++.exp +++ b/libgomp/testsuite/libgomp.c++/c++.exp @@ -16,6 +16,7 @@ if [info exists lang_include_flags] then { if ![info exists DEFAULT_CFLAGS] then { set DEFAULT_CFLAGS "-O2" } +set DEFAULT_CFLAGS "-O0" =20 # Initialize dg. dg-init diff --git a/libgomp/testsuite/libgomp.c/c.exp b/libgomp/testsuite/libgomp.= c/c.exp index 25f347b..f89377f 100644 --- a/libgomp/testsuite/libgomp.c/c.exp +++ b/libgomp/testsuite/libgomp.c/c.exp @@ -16,6 +16,7 @@ load_gcc_lib gcc-dg.exp if ![info exists DEFAULT_CFLAGS] then { set DEFAULT_CFLAGS "-O2" } +set DEFAULT_CFLAGS "-O0" =20 # Initialize dg. dg-init diff --git a/libgomp/testsuite/libgomp.oacc-c++/c++.exp b/libgomp/testsuite= /libgomp.oacc-c++/c++.exp index 7309f78..4dba472 100644 --- a/libgomp/testsuite/libgomp.oacc-c++/c++.exp +++ b/libgomp/testsuite/libgomp.oacc-c++/c++.exp @@ -18,6 +18,7 @@ if [info exists lang_include_flags] then { if ![info exists DEFAULT_CFLAGS] then { set DEFAULT_CFLAGS "-O2" } +set DEFAULT_CFLAGS "-O0" =20 # Initialize dg. dg-init diff --git a/libgomp/testsuite/libgomp.oacc-c/c.exp b/libgomp/testsuite/lib= gomp.oacc-c/c.exp index 60be15d..80b4635 100644 --- a/libgomp/testsuite/libgomp.oacc-c/c.exp +++ b/libgomp/testsuite/libgomp.oacc-c/c.exp @@ -18,6 +18,7 @@ load_gcc_lib gcc-dg.exp if ![info exists DEFAULT_CFLAGS] then { set DEFAULT_CFLAGS "-O2" } +set DEFAULT_CFLAGS "-O0" =20 # Initialize dg. dg-init --=20 2.1.4 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVqnLNAAoJEK3/DN1sMFFtQz8IAKUq5kZxDGI8mw5aEniA5PYo GUniW6ouQ0LtBMWYKxMTe7/u073zxSOx8/P3IzS4vDULg+PXUGsqIQCDr0+duDw2 OOCbMlqAO+54yoYuAQtO+JVa3y4ivt63aAxUsAZ4N1bQ2Vok9TX+ZzMcfS0k5Ots SlHDtn6IB/jDedvSBrowbJah8TfQuD2+P434uxpgjwYCbmBNqnggw2K7Ar8NhIp+ Ovfss8G0dGY3yRIV0nAwbrtjYHp9lsV8+lgKA0pcoOFcAFTab6roHscL6Vyx0AmI kIQjgrAVn3gG/UFVpa+fULaofcmN4mCO7ajoe6COcOuAFsrh7x63EHMCgfW/d6g= =9ekO -----END PGP SIGNATURE----- --==-=-=--