From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21859 invoked by alias); 13 Nov 2014 13:24:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21847 invoked by uid 89); 13 Nov 2014 13:24:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Nov 2014 13:24:50 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XouOE-0004t6-NH from Thomas_Schwinge@mentor.com for gcc-patches@gcc.gnu.org; Thu, 13 Nov 2014 05:24:47 -0800 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.181.6; Thu, 13 Nov 2014 13:24:45 +0000 From: Thomas Schwinge To: CC: Julian Brown , James Norris Subject: Re: [gomp4] [2/3] OpenACC 2.0 support for libgomp - new tests In-Reply-To: <20141014171142.14aa7de4@octopus> References: <20141014171142.14aa7de4@octopus> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Thu, 13 Nov 2014 13:32:00 -0000 Message-ID: <87bnobcjxs.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2014-11/txt/msg01471.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 2370 Hi! On Tue, 14 Oct 2014 17:11:42 +0100, Julian Brown = wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.oacc-c/context-2.c > + float *h_X, [...] > + h_X =3D (float *) malloc (N * sizeof (float)); > + d_X =3D (float *) acc_copyin (&h_X[0], N * sizeof (float)); > +#pragma acc parallel copyin (h_X[0:N]), copy (h_Y2[0:N]) copyin (alpha) As made apparent by a testsuite regression, after gomp-4_0-branch commit r217482, , this needs to be changed as follows; committed to gomp-4_0-branch in r217484: commit 0a74cef871aefd56e577d19864f80e78b6af09e8 Author: tschwinge Date: Thu Nov 13 13:22:54 2014 +0000 libgomp testsuite: Fix data clause. =20=20=20=20 ... after having extended libgomp to actually distinguish between "non-force"/"force" semantics. =20=20=20=20 libgomp/ * testsuite/libgomp.oacc-c-c++-common/context-2.c: Fix data clause. =20=20=20=20 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@2174= 84 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog.gomp | 3 +++ libgomp/testsuite/libgomp.oacc-c-c++-common/context-2.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git libgomp/ChangeLog.gomp libgomp/ChangeLog.gomp index 254846f..a5a58a0 100644 --- libgomp/ChangeLog.gomp +++ libgomp/ChangeLog.gomp @@ -1,5 +1,8 @@ 2014-11-13 Thomas Schwinge =20 + * testsuite/libgomp.oacc-c-c++-common/context-2.c: Fix data + clause. + * target.c (gomp_map_vars_existing): Error out if "force" semantics. (gomp_map_vars): Actually pass kinds to gomp_map_vars_existing. diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/context-2.c libgomp/= testsuite/libgomp.oacc-c-c++-common/context-2.c index 16464d5..6a52f74 100644 --- libgomp/testsuite/libgomp.oacc-c-c++-common/context-2.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/context-2.c @@ -149,7 +149,7 @@ main (int argc, char **argv) =20 context_check (pctx); =20 -#pragma acc parallel copyin (h_X[0:N]), copy (h_Y2[0:N]) copyin (alpha) +#pragma acc parallel present (h_X[0:N]), copy (h_Y2[0:N]) copyin (alpha) { int i; =20 Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUZLEPAAoJEK3/DN1sMFFtwsIH/Anl4h7BbaSBs07UHjCkbIV3 B8DFKykdD3uV29eYKJNvB6MyZhGbdCf0Cbd7MJ/+qUZfpOrVu+Wh/0S0qaGk1KCN QzbYDVHJTfFlnsXpOxDhRILwo+rCDIPB5Du89+yhm4XHj0YGkUvyF3nfPQ4vr9o7 FPmRqu8xSbSVhPu/XqVxDnA9hFqzlPR4+ewuzVJj568OND/28XGnIs79OG4NUrSx oU7x4CNNYJJjjs8oNtMiNQPkmTxy3swqq0TjpvNaJvzqRVO9co5SOg6VT1cI+ByE qEMmoRfHI06mSf23fanTinR+Hcz2gf0aO73/OFDMfZaKyxZxphAucLdS7tzKQCI= =q+pV -----END PGP SIGNATURE----- --=-=-=--