From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21184 invoked by alias); 3 Nov 2010 21:23:45 -0000 Received: (qmail 21160 invoked by uid 22791); 3 Nov 2010 21:23:43 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-ww0-f51.google.com (HELO mail-ww0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Nov 2010 21:23:38 +0000 Received: by wwi17 with SMTP id 17so1047743wwi.8 for ; Wed, 03 Nov 2010 14:23:36 -0700 (PDT) Received: by 10.227.152.65 with SMTP id f1mr2538128wbw.47.1288819415908; Wed, 03 Nov 2010 14:23:35 -0700 (PDT) Received: from localhost (rsandifo.gotadsl.co.uk [82.133.89.107]) by mx.google.com with ESMTPS id h29sm7843987wbc.3.2010.11.03.14.23.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 03 Nov 2010 14:23:33 -0700 (PDT) From: Richard Sandiford To: Uros Bizjak Mail-Followup-To: Uros Bizjak ,gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, MIPS]: Remove ugly hack from "call_internal" splitter References: Date: Wed, 03 Nov 2010 21:27:00 -0000 In-Reply-To: (Uros Bizjak's message of "Tue, 2 Nov 2010 08:56:43 +0100") Message-ID: <87bp66gkzc.fsf@firetop.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-11/txt/msg00356.txt.bz2 Uros Bizjak writes: > Hello! > > We should simply use curr_insn instead of an ugly hack. > > 2010-11-02 Uros Bizjak > > * config/mips/mips.md (call_internal): Pass curr_insn to > mips_split_call. > > Compile tested on x86_64-pc-linux-gnu for mips-elf cross. Please do the call splitters too. OK with that change if it passes regression testing. Thanks, Richard