From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8650 invoked by alias); 10 Aug 2007 01:52:05 -0000 Received: (qmail 8160 invoked by uid 22791); 10 Aug 2007 01:52:04 -0000 X-Spam-Check-By: sourceware.org Received: from mailhost.cs.tamu.edu (HELO postal.cs.tamu.edu) (128.194.138.100) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 10 Aug 2007 01:51:59 +0000 Received: from soliton.cs.tamu.edu (vpn-33.cs.tamu.edu [128.194.150.33]) by postal.cs.tamu.edu (Postfix) with ESMTP id 9AC0C46DE04; Thu, 9 Aug 2007 20:51:57 -0500 (CDT) Received: by soliton.cs.tamu.edu (Postfix, from userid 1000) id DDEF01AAEB; Thu, 9 Aug 2007 20:57:27 -0500 (CDT) To: "Kaveh R. GHAZI" Cc: Mark Mitchell , DJ Delorie , lopezibanez@gmail.com, gcc-patches@gcc.gnu.org Subject: Re: Add a __nowarn__ keyword References: <46B9F0B5.1080302@gnu.org> <200708082254.l78MsIC8014802@greed.delorie.com> <20070809134017.GA10368@caradoc.them.org> <20070809143028.GA14681@caradoc.them.org> <6c33472e0708090805t210191f6r63832af3afdd0816@mail.gmail.com> <200708091531.l79FVI4w032104@greed.delorie.com> <46BB93CD.7070300@codesourcery.com> From: Gabriel Dos Reis In-Reply-To: Date: Fri, 10 Aug 2007 01:52:00 -0000 Message-ID: <87bqdg883c.fsf@soliton.cs.tamu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00631.txt.bz2 "Kaveh R. GHAZI" writes: | On Thu, 9 Aug 2007, Mark Mitchell wrote: | | > DJ Delorie wrote: | > | > > If we can solve a subset of the attachment problem, let's use the | > > push/pop technique I described. It sets us up for all the things | > > we'll need if/when we solve the general attachment problem. | > | > I think we should add the push/pop, and then accept that it's not | > perfect yet. It's still better than nothing, and it would probably work | > well for many front-end warnings, which is where most warnings come from. | > Mark Mitchell | | Based on the above, and on Ian's comments regarding warnings from the | middle-end, I think we're going to extend the pragma interface rather than | accept __nowarn__. In this case I think DJ or someone familiar with that | code is better suited to implement the push/pop mechiansim than I. | | I made a good-faith effort to provide a way for users to "elegantly" work | around -Wcast-qual warnings as Mark requested. Since we're not going to | use it and the existing mechanism doesn't work yet, what I'd like to do is | install my CONST_CAST patch using the union. When the pragma interface is | suitably updated, I volunteer to update the definition of CONST_CAST in | system.h to take advantage of it. Meanwhile I can finish the | constification stuff and get GCC bootstrapping with -Wcast-qual enabled. | | Mark - okay to install CONST_CAST using a union? | http://gcc.gnu.org/ml/gcc-patches/2007-07/msg01993.html Based on the promise you made, I would suggest that we accept the ungly union hack, and remove it as soon as possible, once we have a good enough push/pop stuff. -- Gaby