public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard@codesourcery.com>
To: Kenneth Zadeck <zadeck@naturalbridge.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
	  Steven Bosscher <stevenb.gcc@gmail.com>,
	  "Park, Seongbae" <seongbae.park@gmail.com>
Subject: Re: [dataflow]: PATCH COMMITTED to fix problems with dce.
Date: Fri, 18 May 2007 17:05:00 -0000	[thread overview]
Message-ID: <87bqginjub.fsf@firetop.home> (raw)
In-Reply-To: <464B08B0.80601@naturalbridge.com> (Kenneth Zadeck's message of 	"Wed, 16 May 2007 09:35:44 -0400")

Kenneth Zadeck <zadeck@naturalbridge.com> writes:
> Index: dce.c
> ===================================================================
> --- dce.c	(revision 124596)
> +++ dce.c	(working copy)
> @@ -66,6 +66,11 @@ deletable_insn_p (rtx insn, bool fast)
>  {
>    rtx x;
>  
> +  /* These insns may not have real uses but are there because the
> +     dwarf unwinder may need to see the values they compute.  */
> +  if (RTX_FRAME_RELATED_P (insn))
> +    return false;
> +
>    switch (GET_CODE (PATTERN (insn)))
>      {
>      case USE:

Hmm.  I'm a little uneasy about this.  I didn't think frame-relatedness
was a reason in itself not to delete something.

As far as prologue and epilogue instructions in general go -- not just
frame-related ones -- I thought the backend was supposed to add a
REG_MAYBE_DEAD note to instructions that might legitimately be deleted
as dead.  And I thought that gcc should abort if it thinks a prologue
or epilogue instruction without such a note is dead.  I think that
applies to frame-related as well as non-frame-related instructions.

(It's quite possible I'm misunderstanding what you're doing here,
and that this is just noise.  Sorry if so.)

Richard

      reply	other threads:[~2007-05-18 17:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-16 13:36 Kenneth Zadeck
2007-05-18 17:05 ` Richard Sandiford [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bqginjub.fsf@firetop.home \
    --to=richard@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=seongbae.park@gmail.com \
    --cc=stevenb.gcc@gmail.com \
    --cc=zadeck@naturalbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).