[PATCH] testsuite/libstdc++: Fix required locales of a testcase

[PATCH] testsuite/libstdc++: Fix required locales of a testcase

[Marius Hillenbrand]

The testsuite for libstdc++ aims to skips test cases for which not all
required locales are installed. This patch adds missing directives about
required locales to one test case to avoid false positive test failures
on systems that have a partial set of locales installed.

Verified by test suite runs that this patch changes the test case from
FAIL to UNSUPPORTED when not all required locales are available and that
the test case will run and PASS when the necessary locales have been
added.

Please review and merge this patch if you agree. While this patch is
trivial, it may safe others a few minutes of confusion ;-)

Marius


libstdc++-v3/ChangeLog:

2020-11-24  Marius Hillenbrand  <mhillen@linux.ibm.com>

	* testsuite/22_locale/locale/cons/5.cc: Add missing directives
	for required locales.
---
 libstdc++-v3/testsuite/22_locale/locale/cons/5.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc b/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc
index 8fd73960abb..49e863ec85c 100644
--- a/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc
+++ b/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc
@@ -1,5 +1,7 @@
-// { dg-require-namedlocale "en_PH" }
 // { dg-require-namedlocale "de_DE" }
+// { dg-require-namedlocale "en_PH" }
+// { dg-require-namedlocale "es_MX" }
+// { dg-require-namedlocale "fr_FR" }
 // { dg-require-namedlocale "it_IT" }
 
 // 2000-09-13 Benjamin Kosnik <bkoz@redhat.com>
-- 
2.26.2

[PING] [PATCH] testsuite/libstdc++: Fix required locales of a testcase

[Marius Hillenbrand]

I'd like to ping the small fixup in
https://gcc.gnu.org/pipermail/gcc-patches/2020-November/560100.html

Please review and merge, if OK.

Marius


-------- Forwarded Message --------
Subject: [PATCH] testsuite/libstdc++: Fix required locales of a testcase
Date: Tue, 24 Nov 2020 17:26:26 +0100
From: Marius Hillenbrand <mhillen@linux.ibm.com>
To: gcc-patches@gcc.gnu.org
CC: Marius Hillenbrand <mhillen@linux.ibm.com>

The testsuite for libstdc++ aims to skips test cases for which not all
required locales are installed. This patch adds missing directives about
required locales to one test case to avoid false positive test failures
on systems that have a partial set of locales installed.

Verified by test suite runs that this patch changes the test case from
FAIL to UNSUPPORTED when not all required locales are available and that
the test case will run and PASS when the necessary locales have been
added.

Please review and merge this patch if you agree. While this patch is
trivial, it may safe others a few minutes of confusion ;-)

Marius


libstdc++-v3/ChangeLog:

2020-11-24  Marius Hillenbrand  <mhillen@linux.ibm.com>

	* testsuite/22_locale/locale/cons/5.cc: Add missing directives
	for required locales.
---
 libstdc++-v3/testsuite/22_locale/locale/cons/5.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc
b/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc
index 8fd73960abb..49e863ec85c 100644
--- a/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc
+++ b/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc
@@ -1,5 +1,7 @@
-// { dg-require-namedlocale "en_PH" }
 // { dg-require-namedlocale "de_DE" }
+// { dg-require-namedlocale "en_PH" }
+// { dg-require-namedlocale "es_MX" }
+// { dg-require-namedlocale "fr_FR" }
 // { dg-require-namedlocale "it_IT" }
  // 2000-09-13 Benjamin Kosnik <bkoz@redhat.com>
-- 
2.26.2

Re: [PING] [PATCH] testsuite/libstdc++: Fix required locales of a testcase

[Jonathan Wakely]

On 14/12/20 11:19 +0100, Marius Hillenbrand wrote:
>I'd like to ping the small fixup in
>https://gcc.gnu.org/pipermail/gcc-patches/2020-November/560100.html
>
>Please review and merge, if OK.

Patches for libstdc++ need to be CC'd to the libstdc++ list, or I
won't see them (this is mentioned at https://gcc.gnu.org/lists.html
which https://gcc.gnu.org/contribute.html#patches links to).

The patch itself is good, so I'll merge it today, thanks!

>Marius
>
>
>-------- Forwarded Message --------
>Subject: [PATCH] testsuite/libstdc++: Fix required locales of a testcase
>Date: Tue, 24 Nov 2020 17:26:26 +0100
>From: Marius Hillenbrand <mhillen@linux.ibm.com>
>To: gcc-patches@gcc.gnu.org
>CC: Marius Hillenbrand <mhillen@linux.ibm.com>
>
>The testsuite for libstdc++ aims to skips test cases for which not all
>required locales are installed. This patch adds missing directives about
>required locales to one test case to avoid false positive test failures
>on systems that have a partial set of locales installed.
>
>Verified by test suite runs that this patch changes the test case from
>FAIL to UNSUPPORTED when not all required locales are available and that
>the test case will run and PASS when the necessary locales have been
>added.
>
>Please review and merge this patch if you agree. While this patch is
>trivial, it may safe others a few minutes of confusion ;-)
>
>Marius
>
>
>libstdc++-v3/ChangeLog:
>
>2020-11-24  Marius Hillenbrand  <mhillen@linux.ibm.com>
>
>	* testsuite/22_locale/locale/cons/5.cc: Add missing directives
>	for required locales.
>---
> libstdc++-v3/testsuite/22_locale/locale/cons/5.cc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc
>b/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc
>index 8fd73960abb..49e863ec85c 100644
>--- a/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc
>+++ b/libstdc++-v3/testsuite/22_locale/locale/cons/5.cc
>@@ -1,5 +1,7 @@
>-// { dg-require-namedlocale "en_PH" }
> // { dg-require-namedlocale "de_DE" }
>+// { dg-require-namedlocale "en_PH" }
>+// { dg-require-namedlocale "es_MX" }
>+// { dg-require-namedlocale "fr_FR" }
> // { dg-require-namedlocale "it_IT" }
>  // 2000-09-13 Benjamin Kosnik <bkoz@redhat.com>
>-- 
>2.26.2
>