From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 17A4D3858C5E for ; Wed, 14 Jun 2023 19:05:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17A4D3858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-655fce0f354so5516046b3a.0 for ; Wed, 14 Jun 2023 12:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686769519; x=1689361519; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZGKI5HJjQ1jrQzqzsLcrz0AJHMSeJaj3oKUVzFlbusI=; b=sANqIAAG5axYBYU0TB7tXJfMSMKG39gWdyjkGxj8D6nT9NVMBAw7sU8rJ+AlCktk91 wND7puL6+TEVndA5gkkBzfGm2pdmxWpngUlyA7MmOtPvSKHndl5rypP1jL9sVaNL6z4D yltAnWLUfRuB/ZMaLn7WOhtmg+u1DuLvEc8D3TAXbXxiTuDn6Ki5r6DykRNroe/MwSEJ zW8qXTR2sUpAtsiVo11Su6/YJo+rl7k+yLpkR/CLDRhykd1Hj7mUtbhqFSIG8wLliEPP Al5bcpSJ3ruDkdeZA27XSJhN0bLE82y1SPPsMzEDphwtz2kQboat34kdt7Bu3impU6gh UxOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686769519; x=1689361519; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZGKI5HJjQ1jrQzqzsLcrz0AJHMSeJaj3oKUVzFlbusI=; b=isYS6eRfEQqEavoSE+eSCkf5p2B54CxB0Seb6tfYVCpzSyUZbvmBa/x1Fwme+o8zxL U/D1OdZTqdimvZf/XhlmlmQauKqbQNTB/ekozd3J0e+X5JF5u8Q6plCs3N4cIvywZ+mB aeD2i5U1Gi7FEWRr2DDLwo1HKAjpb6VvZYl74GR2dK7iZkPREHxdgb5yZ+G4oqFYm/iA xaptCoiXumKF98y41xXUUxdPfxGUzIGXcLD98m0yrLanRfRc7xus1ImCi0mQyKo5A29y J7a0H2k/PmJ0xdweGju5R1cZbAHTW66uKteXnzzmLs6Ss4r+x8y4FQYLlDCVLW2PomX2 aRlw== X-Gm-Message-State: AC+VfDyU5Br84EGp0jwIgCCAiyQJoshvTQh7bgVlSwvP7+SyF/LfyECu 9h/VGfaH1XVC8UsxY4WPO9s= X-Google-Smtp-Source: ACHHUZ73S5IwtuCbFJupfW0xNHTCwrd0xDachKUtvciJYglRLMGe3Mpr9iiIxy12c9AU7+EHJVNktg== X-Received: by 2002:a05:6a20:e193:b0:106:4197:b7ff with SMTP id ks19-20020a056a20e19300b001064197b7ffmr1830455pzb.30.1686769518805; Wed, 14 Jun 2023 12:05:18 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id i21-20020aa78b55000000b0064fdf576421sm11042135pfd.142.2023.06.14.12.05.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 12:05:18 -0700 (PDT) Message-ID: <87cfd0c0-4e59-4cf8-1e72-eb9e1dc78c5f@gmail.com> Date: Wed, 14 Jun 2023 13:05:16 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH V2] RISC-V: Ensure vector args and return use function stack to pass [PR110119] Content-Language: en-US To: Robin Dapp , "juzhe.zhong@rivai.ai" , =?UTF-8?B?5LiB5LmQ5Y2O?= , gcc-patches References: <20230614115611.2227435-1-lehua.ding@rivai.ai> <2858E481EBED11AA+2023061420033110394853@rivai.ai> <33729abc-b810-c060-17b6-05df0f35612e@gmail.com> From: Jeff Law In-Reply-To: <33729abc-b810-c060-17b6-05df0f35612e@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/14/23 06:05, Robin Dapp via Gcc-patches wrote: >> Oh. I see Robin's email is also wrong. CC Robin too for you.... > > It still arrived via the mailing list ;) > >> Good to see a Fix patch of the ICE before Vector ABI patch. >> Let's wait for more comments. > > LGTM, this way I don't even need to rewrite my tests. I think Palmer wanted to include a pointer to the psabi MR, so we should probably include that in a comment. So OK with that in a comment. I think there was talk of having this all be hidden behind a flag, but given it's an ICE on vector types, I don't mind just defining something for now to fix the ICE and give psabi time to finalize that spec. This was also a good reminder that the vector work can't really be complete until we have the psabi updates in place and implemented. The efforts can obviously continue in parallel, but it's a dependency worth noting in the RISE context. Jeff