From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 1F0B53858D37 for ; Tue, 5 Dec 2023 23:12:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F0B53858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F0B53858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701817927; cv=none; b=bB+4H2wtVXle9iLx/tD8Ej2swamVbGvzOsnmtvWvbD0aN5IKXWSQNuH+519+es94FZwNf+f42LS67M/0DPhCaqTKopEfbGzMlTAFFIke1CBCKb7vb4vnzprZs6iYAzWXwKz5SWTSxQT2ImgzOoQeOq39SwMhGeKqWAKP8Ctjy+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701817927; c=relaxed/simple; bh=pu8uYEYoIrJ3/rcx0uIXUm/KRYVI8GfUAVUMBnI8Zjk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dAW3/ZIeHeHN29OP2HpIB7zbV4zRtcDUzUztrp8vr8yTXsevvqzUrOnAk4pMOpqavaVew5qaWVJvBgyuH1pCZuv7uK2ZWkLrp51EXDwhGGgRYYky4KGnIEHbmAKi/xIv4Wdjfj/KpsGOTVrrvc2ssFcfzTe9sPSj6EjIuEqqZVQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40c0a074e71so28394075e9.1 for ; Tue, 05 Dec 2023 15:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701817925; x=1702422725; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=iSi5P4AQORtoPPgJSVEhygpRofx7oFOiJH1UWMruDJw=; b=Ip9ww/MNukKDyAqen3fcndCvwPh4cqUM8yZjyz1sky/FdnEcslh/cHEhWp2Bc4GW2K CA7bLo9yjxmu6yn6ltuwKJMmWL9Qj5iHXd/qCs1iHpYMwIiLOOlOmwvr+VsARxXZZssG U1D8dQ/wZq+aUQ1mLdkJAzQ9PIQ5LLHIx99OorfYHMrVSlJGbf/w5RKbNftMWGnSairG 8gHuC4lIYkAZ6gkCzVa+vGfguwxpJm6xEpffIUF8wmVEUm4T8ttGzWpbehWZbm3Tjv4k DqL/4txYh4QwumoVMTfcA6JN4PocMQLhra9TdNnBqWWpjayF96r2CqCBp+HzFu9Kp44k 9QfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701817925; x=1702422725; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iSi5P4AQORtoPPgJSVEhygpRofx7oFOiJH1UWMruDJw=; b=OZTVoDdW3IBfRb0dyB2tBp/sLYD7UyB0baj/1lyRNRRhFWEhiuVgP1CacmFdsCbvSz 2r6EJcqjxFtDr4YT28Wzto0TtDis7tn+poN2pT+Eq1FsYYMvIO7hUePysrMMqda01Aeo 4K/VMK7FOOfvmjKNbQGjF/GFt1qFTpbPRgV0ZUDIqQGOp+e7pLdpQ0CHCaLxOOhrQ2uX vEBSPQWKxZgQey9pSD9+DIrXGRtRIzaS/0RWRT+g4/kpOOYnTCHEI4yUePfLik5uKjde nhIn3bgx5cjL6/vChzK7l+lwOUCXlPPfeVVavDhmSqXEnlmAaCpMrXC1kPX7KrE1E1zD r7NQ== X-Gm-Message-State: AOJu0YyCTMKxD2SyRnBsBB8nwoVYdqvkuAbi0qUdpLv7gaSRvU3VJl/T POkIJVdne0EnLoOcZYxVg6g= X-Google-Smtp-Source: AGHT+IHuZCdvrsOYKqH6hdymUx7UGzjJuugcDGYPW2FOsDhxlb3i8mheL9VbNbSQ2Ecrto8uFYsMOg== X-Received: by 2002:a05:600c:4e8e:b0:40b:5e1b:54a0 with SMTP id f14-20020a05600c4e8e00b0040b5e1b54a0mr42961wmq.44.1701817924471; Tue, 05 Dec 2023 15:12:04 -0800 (PST) Received: from lancelot ([82.152.202.43]) by smtp.gmail.com with ESMTPSA id v11-20020a05600c444b00b003fefaf299b6sm20034331wmn.38.2023.12.05.15.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 15:12:03 -0800 (PST) Received: from gaius by lancelot with local (Exim 4.96) (envelope-from ) id 1rAeaA-00C5yL-0f; Tue, 05 Dec 2023 23:12:02 +0000 From: Gaius Mulley To: Thomas Schwinge Cc: Subject: Re: Modula-2: Support '-isysroot [...]' References: <87wmtt3sam.fsf@euler.schwinge.homeip.net> Date: Tue, 05 Dec 2023 23:12:02 +0000 In-Reply-To: <87wmtt3sam.fsf@euler.schwinge.homeip.net> (Thomas Schwinge's message of "Tue, 5 Dec 2023 10:36:01 +0100") Message-ID: <87cyvkz1kt.fsf@localhost> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thomas Schwinge writes: > Hi! > > OK to push the attached "Modula-2: Support '-isysroot [...]'"? > > This greatly improves test results for the cross configurations I've > tested, but I don't know if any real handling needs to be implemented, or > this should be done differently altogether? > > > Gr=C3=BC=C3=9Fe > Thomas > > > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe > 201, 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; > Gesch=C3=A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der G= esellschaft: > M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 > >>>From 0bd30fd25138497df5320e5f63fd04e1b5756cc5 Mon Sep 17 00:00:00 2001 > From: Thomas Schwinge > Date: Tue, 5 Dec 2023 09:54:54 +0100 > Subject: [PATCH] Modula-2: Support '-isysroot [...]' > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > In GCC cross configurations (tested '--target=3Damdgcn-amdhsa' and > '--target=3Dnvptx-none') with a sysroot configured, the 'gm2' driver invo= cations > are passed '--sysroot=3D[...]', which is translated into '-isysroot [...]= ' for > the 'cc1gm2' compiler invocation. The latter, however gets complained ab= out: > > cc1gm2: warning: command-line option =E2=80=98-isysroot [...]=E2=80= =99 is valid for C/C++/D/Fortran/ObjC/ObjC++ but not for Modula-2 > > ..., and therefore a ton of FAILs. > > Reproducer (also for non-cross, native configurations): > > $ build-gcc/gcc/gm2 -Bbuild-gcc/gcc -v --sysroot=3D/tmp -x modula-2 /= dev/null > [...] > build-gcc/gcc/cc1gm2 [...] -isysroot [...]/tmp [...] > cc1gm2: warning: command-line option =E2=80=98-isysroot /tmp=E2=80=99= is valid for C/C++/D/Fortran/ObjC/ObjC++ but not for Modula-2 > [...] > > gcc/m2/ > * lang.opt (-isysroot): New. > --- > gcc/m2/lang.opt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gcc/m2/lang.opt b/gcc/m2/lang.opt > index 24f3c6594b9..a60c03e69d4 100644 > --- a/gcc/m2/lang.opt > +++ b/gcc/m2/lang.opt > @@ -405,6 +405,10 @@ iquote > Modula-2 > ; Documented in c.opt >=20=20 > +isysroot > +Modula-2 > +; Documented in c.opt > + > isystem > Modula-2 > ; Documented in c.opt Hi Thomas, yes indeed and many thanks for the fix! gm2-lang.cc anticipates OPT_isysroot (albeit it does nothing with it yet) regards, Gaius