public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Marc <dkm@kataplop.net>
To: Richard Sandiford <richard.sandiford@arm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v3] mklog: handle Signed-off-by, minor cleanup
Date: Mon, 04 Sep 2023 21:45:29 +0200	[thread overview]
Message-ID: <87cyyxu3fr.fsf@arrakis.kataplop.net> (raw)
In-Reply-To: <mpta5u1wzps.fsf@arm.com>


Richard Sandiford <richard.sandiford@arm.com> writes:

>> +# this regex matches the first line of the "end" in the initial commit message
>> +FIRST_LINE_OF_END_RE = re.compile('(?i)^(signed-off-by:|co-authored-by:|#) ')
>
> Personally I think it would be safer to drop the final space in the regexp.
>
> OK with that change if you agree.

Hello,

You're correct. I'll commit the adjusted change.

Thanks,
Marc

  reply	other threads:[~2023-09-04 19:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 11:08 [PATCH v2] mklog: handle Signed-Off-By, " Marc Poulhiès
2023-08-22  6:56 ` Richard Sandiford
2023-09-03 18:47   ` [PATCH v3] mklog: handle Signed-off-by, " Marc Poulhiès
2023-09-04 18:38     ` Richard Sandiford
2023-09-04 19:45       ` Marc [this message]
2023-08-02  9:06 Marc Poulhiès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyyxu3fr.fsf@arrakis.kataplop.net \
    --to=dkm@kataplop.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).