From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gandi.kataplop.net (gandi.kataplop.net [46.226.111.114]) by sourceware.org (Postfix) with ESMTPS id C29553858C30 for ; Mon, 4 Sep 2023 19:46:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C29553858C30 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=kataplop.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kataplop.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kataplop.net; s=rsa1; h=Content-Type:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=F0fFIaNKwl32Pr88duUyxwNrKr9revifwF/pzDAlJgQ=; b=SrQqmkj6wfzEmE/aVVPYAqRVGb Fmi/utmnwJeHesXVZuyei/Nq0WBeB7MRpc6rIG2UWZ7evObAfaleTvvj3o0xq+FxBTFrBmEsa9EGI pwd7n4334UunbQg0QjOixrGJHnp/2vfd/oo4tRrM1nLsLMM0ahZFMqZO/0A8nblSb8xw=; Received: from [176.191.105.132] (helo=arrakis) by gandi.kataplop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdFWr-00062x-ME; Mon, 04 Sep 2023 21:46:33 +0200 References: <20230903184706.259231-1-dkm@kataplop.net> User-agent: mu4e 1.8.13; emacs 29.1 From: Marc To: Richard Sandiford Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v3] mklog: handle Signed-off-by, minor cleanup Date: Mon, 04 Sep 2023 21:45:29 +0200 In-reply-to: Message-ID: <87cyyxu3fr.fsf@arrakis.kataplop.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam_score: -1.0 X-Spam_bar: - X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard Sandiford writes: >> +# this regex matches the first line of the "end" in the initial commit message >> +FIRST_LINE_OF_END_RE = re.compile('(?i)^(signed-off-by:|co-authored-by:|#) ') > > Personally I think it would be safer to drop the final space in the regexp. > > OK with that change if you agree. Hello, You're correct. I'll commit the adjusted change. Thanks, Marc