From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 944C93858002 for ; Tue, 15 Aug 2023 19:03:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 944C93858002 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37FHiQCu020237 for ; Tue, 15 Aug 2023 19:03:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=f7ZwztnWYPJqJzzKnazjBGewYuv95McgUfs3gr8KJZc=; b=RXYd1jifWRc+wp4/JR0XNz01ML+2opS6Zl8frOAf6vbfQem5+MFnzJ5ocoLrg9R16DkI 6EFFF57ldRhocsKaVr0eFwQ1q3yGmgHBEwfJHeOC7aT2x8GwbgBFuUOmucvXiuUwUZi5 C9J9arqjevvRuzQaBUloIFNlxleSTj2z89pr9pogayP2bS5SCmNlIo7l7E/TMxi3xC3g 0UGgDdmqAbcfA8JUIkUgWYmdWLLqI6TmgpeWra8RzGJUFX7vvE3osZhBZFhYV0Ba5HIL dSa8ShUrYA8dwZAw49zL7i0bths+maalXos9Udq6WOo/xaG0PUjQuvXIByxjEBtRRy4R Sw== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3se30swfmd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 15 Aug 2023 19:03:09 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 37FHUbh5040720 for ; Tue, 15 Aug 2023 19:03:08 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2042.outbound.protection.outlook.com [104.47.73.42]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3sey70efpy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 15 Aug 2023 19:03:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWInUZuQzD7wmKx4xuJim/y0UDNEAS81aCYD9EaK1469QQHW8aKqD9F+bWCKXQqYe55p2WfrcZ8zufwVikJ0S6nzKQUuuTaS0ei8GYhSASnVJ5SjFbfry2vaEQ8EikZtNkciah4N0zCJdwvInQlaQtKio0mvQf/Cl/OnSQTAa93mze3lXBpOCHykRANBvoGP2ubqfAZRRp2As5Wp7bhlwlljsOnvrvqFTpttP1FJ9W2Bt0C7XnBAhzZn0uADW9hTPOzh3pKx1SX1TFGFqySlX9rpe8GixZ1chOEe0rgGnt7bVfI28Rl2FXpScPqfwxK4lB6qNshEtJrdloMJmjT6Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f7ZwztnWYPJqJzzKnazjBGewYuv95McgUfs3gr8KJZc=; b=lmkvMqQ/0uDcEp+DBGMSWw52sbpnCuWXCNe/nc8gMf5O1Eh4U73JZCAW2voniYMgTvtE8bB1sf4HE6S5h28B2cFqhYwp+qPLACwgASYSs26WAsOeUEQHJjMWjJwvYEIwjfZUv9G25UV6LN0Z9GX2o24gqaIt465hyIz6Uz9dRHR8GexhAKqWnPnlE7OXSCn5tur0QXbJJ5pGYvH7LHiXlnRae9Yfag/l1j/ET5VG58637ESl6JOw8ufCsRrii590cJlspUsYCGBmlg8KYw2jU6Vyu/C5Ahn6j334MK9wi7YLk0VdEBl/YzEIN0KLCU3GfiF7ikFc16TLS1k6eWcmLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f7ZwztnWYPJqJzzKnazjBGewYuv95McgUfs3gr8KJZc=; b=CC2EUAZ/pFKGpBQM0vZllmYeC3CoIsZG/vhcFKrpwSUxPafYeYsPgNl7vdkCLcYYr1Ithls2LkV3wKWiqQZiRCHR7QKvX4j6NwwDYFA6ZYBa9HolpFSkKkkN7Bc+mu8LUn0CWwmSVpHVTqYJzW7YDnn7F39axFthIKsar26+Zl8= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by IA0PR10MB6866.namprd10.prod.outlook.com (2603:10b6:208:434::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.26; Tue, 15 Aug 2023 19:03:06 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::7d31:72cf:ebed:894f]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::7d31:72cf:ebed:894f%5]) with mapi id 15.20.6678.025; Tue, 15 Aug 2023 19:03:06 +0000 From: "Jose E. Marchesi" To: David Faust Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] bpf: fix pseudoc w regs for small modes [PR111029] In-Reply-To: <20230815184618.7396-1-david.faust@oracle.com> (David Faust's message of "Tue, 15 Aug 2023 11:46:18 -0700") References: <20230815184618.7396-1-david.faust@oracle.com> Date: Tue, 15 Aug 2023 21:02:59 +0200 Message-ID: <87cyzo3z8c.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LO2P123CA0105.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::20) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|IA0PR10MB6866:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ea11ad0-34b0-40a3-8abe-08db9dc241df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GFiNH+DJFw1hNlBu1IkiILY+9+hkZ53SVxM+C8UDuSx2iGGF3KvE5UPczrzODeg0uAwcSAjhbD33IKeB2OifJYuxzheMXVJG7+0iFEWmqXhYy6tuNacj7Iom1/zSeUrY9fYQGA/xey5uWSm57JtI5EaLTWxjuwb18Z09UR5ekrK9fdSq4nx+rOV4GReJUbNarFq+GfRJUbdNhplggCiF3mm/Yn+D7KzAfSYI0odsIb0AMQ9b/rP1F6NmWk58TyMubKnUrISq217eDTF0VtB7Rj9JuVKFetl+h+WUMf3Ty1n+k0d8KD7G1H8xgdFwHDnCHcVeJbF/TNN6kLzd+s3BsZz0xJ50DU/LmEsLGMuYfi5Iq+ubHm2GNi9KeUGP7iXV2+4b4ua/LY9CEzrouJCvkSA/OkwpYI1NYK2JFdvKaKLkSpq6lVGUFW4rP9oq4LMrBhY9F3JemHCF2J2H6ws5EfFZfIFoe4dN1EhH+z+ykuCQf4JCBCWMbniHg2uxGpRdOsFueiZ9ZXTYsYAYyws2nbBX7TYENJ59Ko7fmC++MknurHmI4pPF8lxcLJmUEmD2GEcJpP1EGCg/+OP+Pf1y8A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(136003)(39860400002)(346002)(376002)(396003)(1800799009)(186009)(451199024)(66556008)(66476007)(66946007)(5660300002)(38100700002)(86362001)(36756003)(6486002)(37006003)(6666004)(6512007)(2906002)(6506007)(316002)(4326008)(26005)(6636002)(84970400001)(41300700001)(8676002)(8936002)(6862004)(478600001)(83380400001)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VT/fLRSSDFqm89ng6SFY1U2ddL/Nyv1lXKo7LTEWgpqnxG2nx+fStqs5JUpx?= =?us-ascii?Q?JLk6xf+DbRbwyH/PEyG28QYKBnaXbed5qLVswTzZgCIeXCmMaFMyhTKXYk9p?= =?us-ascii?Q?cGEWnPfeMIW6mI7ZrMRNtSN32TavOolXV5JO8wpD1IrIpefwRYmbnhEVc8DT?= =?us-ascii?Q?PDCpWKMZCbpmg144aEvbOLqR0ebK9rcvNTCuvI8g0UQ4Bm+hjA5yWb4iilV4?= =?us-ascii?Q?05xwcRA62vq13Y9wOmC4S3wYqhHxtqxHxxum7nd1DwS7bKykvzSirtk0lRDs?= =?us-ascii?Q?B1ULyvRnOaoVDl0C9KMFWBQJTwZvoW0y7c4+Wzi2AmD2rDYX9oeH6sba3myN?= =?us-ascii?Q?DGz8wEquSgRNpWfBO6DNoOHNuWktyZXdS0rbysPO2zmIy6ntbdRz26K+IlKL?= =?us-ascii?Q?3P5SM12a7F9jhZ74LL8qoDe8GQn0a2tyV75jQCSwov3rrY64KTcjod44Yj/n?= =?us-ascii?Q?6Unju8SDHMmQ1apX9a7lF3pKWC0caUEKlqvAjBCngEaC2l8FT/7J+WLWVObT?= =?us-ascii?Q?rJKo0lqT3zO9IMfScoBoIc5Kpt5V9OaCdG8XDZrpvdEN8uCnyqyF7jQ4zKnB?= =?us-ascii?Q?ia+J7KUpIvt2+RL4pFZvX9L+mHQzK0yke+Tv7dsm1eZmkM3Zt8+nwbyCUSY9?= =?us-ascii?Q?190B+5q7obC3RW+xmTXTyKGb5XiBaC4UVqrcflynVTMJzhVav0sIzeNHkRUw?= =?us-ascii?Q?gVMPLnIaC3CsLhPFIM8/TYHg3+NUcmgDEaQFnKjQm3tfnH8d3toKxQ88BMoE?= =?us-ascii?Q?Ll4VaI8Ys1Q/PzEP9zn3E35iiWYyVUu4ERDE8vkLUW56gXx9Vci6fOZhhAmA?= =?us-ascii?Q?3X89FMZ9oWs39JGKfQkSQnvrR4OJPN7vDTRQFH6Fu/KwHF7QBp9PQObKOBx6?= =?us-ascii?Q?fWmn4wmXL3tVUvkgncktoz+/SoJUZFFOZdsWnJErFg3Y2F5nWEWppllRbJYl?= =?us-ascii?Q?7CabbmVW07O2Gfr6OADixwiGQPHlJ+IrPn5p7bYJfae/VSiNLDBV9H+A9IKm?= =?us-ascii?Q?nibr1AKNH2pWJJAMH57fHSbjF8rxwhge+9dHdiUoCBpD5jM/b7HVE7NVzNFF?= =?us-ascii?Q?beRPb2Rla0yr+XxiQHuKZzDpFXvXkcGLiMYeA0hLOyZnxu0xIgzGRngMaTKF?= =?us-ascii?Q?utV6U3zDEDGQdGFlFWyc3Ty3MKF6iGl0r2KKfjWNkk3IyGLVHKwzi9zNM6R+?= =?us-ascii?Q?YZpOK71VlKeA8BlqxdEc81Mhed+vBuR6oqtWr5lTyhkTXe4+zDBcdaaSe1GS?= =?us-ascii?Q?DNQQTODxqp83H1gqa9vUvqL1Qa/PrKcbFGbULwF/01TitfBVFbz/klc5Lfat?= =?us-ascii?Q?lhWaKcuAftLllmvGNcglX4kWboaoRqkAujg/n9n4s1Okv39eZmtO8IxsFbBY?= =?us-ascii?Q?RHLdrdv84IggdtgCz5VPRPn67MR0de2il8wpUK6O35AFASWvxKXLtFWbY9Mf?= =?us-ascii?Q?OSzDnWQK0rsLr6ISA62f6s8CLyNx8lQiXngUlyl3qEXPmJSUqFAHo8JCr9zv?= =?us-ascii?Q?AVEa+ilpTAPOCQJcOChEqf7VEJRYKKzWJNwrcHRHI03rYBI+B6HbS588+uYy?= =?us-ascii?Q?Qi9zLnIQ5znibBNUXo/Cv3xD3152ZRlARKJjBaRSdAILHHZBsHuXpRkYgD4U?= =?us-ascii?Q?Rg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZE7R3gZ1BkRLvcXrahxfyKm7f5SsCwe2nmIPL4pWTEWUwfVbr+W68HyT2SHBzMkSKe/DWRUBslNrLHr/O2z01qUmlN5nizj4pZlUWjOlUdX1kyehLj9QYiMWXBdJmgJlwJzW8wuW9gzgGHlaG8r5VUOjnEp8tEziB1R+p1xZf+tUJd/38AnAVktZmpFTPDT41NCi9vNe+8XfuZJM+5xwLnS7z5IUSZyXVvHFKZgZxEPEuLjdPycq9r1yKmZXNQj0c7EEZWoQv3ZrAA/s2jDO4kJQMnpikY11S14gMS7JKMCiHuHDHIgJcJxjiTYn46QIkMht3fRiB9lgRp/fR5llMAGfbcyjs25T/B6DRgbox3ZX4BoGh2da/HImwWsG/uBL69ocVU1+ha7Y3orM0ts7bVpgxeX4tDQAzYzjryJBIzr44HZpsIH9HS+woDkJlNRmACIarQmTLcDUDjoDk8b2mequitpcrCotti/IChurs4C7rQ993ShUG4AE5FbrDk91108hUkjMFfQISpjcbNBzDj+NhVp2Y3AwioMglR7/rIRLEaR1VH2/89SRVvSt/x0Y1YB6meKHTnGM69mee0cXdlpaP1XFeVpP+KYThg/P2ms+bd6bzSxShBzpkSZtjOnh/DixpQG5lVs4786dtQRNsA0Mg6YHA27nEGkdop75PAyy7aXQ+p9SnmkKGC0xSm5j1c4wQqFev1Z3B7kHe3tbaG+6zSYX3aNWcbcp9geRSQAuWpwnW8MzgK/abD/lKJpd X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea11ad0-34b0-40a3-8abe-08db9dc241df X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2023 19:03:06.0965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k+EoCngz8pPmwjjRfOT+MgJ7/Nuk0CU3gu8cI4V09XVGoTJ8Ummt0u3j1fUk7QrMrxAfpWtUyYxSl3xjQhJLq/HFnAi0AdbtnP2fjGdaLZg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6866 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-15_17,2023-08-15_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=773 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308150171 X-Proofpoint-GUID: oXpPXV9g4-wTLv6xS8w1F2cSsUp8myWT X-Proofpoint-ORIG-GUID: oXpPXV9g4-wTLv6xS8w1F2cSsUp8myWT X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello David. Thanks for the patch. OK. > In the BPF pseudo-c assembly dialect, registers treated as 32-bits > rather than the full 64 in various instructions ought to be printed as > "wN" rather than "rN". But bpf_print_register () was only doing this > for specifically SImode registers, meaning smaller modes were printed > incorrectly. > > This caused assembler errors like: > > Error: unrecognized instruction `w2 =(s8)r1' > > for a 32-bit sign-extending register move instruction, where the source > register is used in QImode. > > Fix bpf_print_register () to print the "w" version of register when > specified by the template for any mode 32-bits or smaller. > > Tested on bpf-unknown-none. > > PR target/111029 > > gcc/ > * config/bpf/bpf.cc (bpf_print_register): Print 'w' registers > for any mode 32-bits or smaller, not just SImode. > > gcc/testsuite/ > > * gcc.target/bpf/smov-2.c: New test. > * gcc.target/bpf/smov-pseudoc-2.c: New test. > --- > gcc/config/bpf/bpf.cc | 2 +- > gcc/testsuite/gcc.target/bpf/smov-2.c | 15 +++++++++++++++ > gcc/testsuite/gcc.target/bpf/smov-pseudoc-2.c | 15 +++++++++++++++ > 3 files changed, 31 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/gcc.target/bpf/smov-2.c > create mode 100644 gcc/testsuite/gcc.target/bpf/smov-pseudoc-2.c > > diff --git a/gcc/config/bpf/bpf.cc b/gcc/config/bpf/bpf.cc > index 3516b79bce4..1d0abd7fbb3 100644 > --- a/gcc/config/bpf/bpf.cc > +++ b/gcc/config/bpf/bpf.cc > @@ -753,7 +753,7 @@ bpf_print_register (FILE *file, rtx op, int code) > fprintf (file, "%s", reg_names[REGNO (op)]); > else > { > - if (code == 'w' && GET_MODE (op) == SImode) > + if (code == 'w' && GET_MODE_SIZE (GET_MODE (op)) <= 4) > { > if (REGNO (op) == BPF_FP) > fprintf (file, "w10"); > diff --git a/gcc/testsuite/gcc.target/bpf/smov-2.c b/gcc/testsuite/gcc.target/bpf/smov-2.c > new file mode 100644 > index 00000000000..6f3516d2385 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/bpf/smov-2.c > @@ -0,0 +1,15 @@ > +/* Check signed 32-bit mov instructions. */ > +/* { dg-do compile } */ > +/* { dg-options "-mcpu=v4 -O2" } */ > + > +int > +foo (unsigned char a, unsigned short b) > +{ > + int x = (char) a; > + int y = (short) b; > + > + return x + y; > +} > + > +/* { dg-final { scan-assembler {movs32\t%r.,%r.,8\n} } } */ > +/* { dg-final { scan-assembler {movs32\t%r.,%r.,16\n} } } */ > diff --git a/gcc/testsuite/gcc.target/bpf/smov-pseudoc-2.c b/gcc/testsuite/gcc.target/bpf/smov-pseudoc-2.c > new file mode 100644 > index 00000000000..6af6cadf8df > --- /dev/null > +++ b/gcc/testsuite/gcc.target/bpf/smov-pseudoc-2.c > @@ -0,0 +1,15 @@ > +/* Check signed 32-bit mov instructions (pseudo-C asm dialect). */ > +/* { dg-do compile } */ > +/* { dg-options "-mcpu=v4 -O2 -masm=pseudoc" } */ > + > +int > +foo (unsigned char a, unsigned short b) > +{ > + int x = (char) a; > + int y = (short) b; > + > + return x + y; > +} > + > +/* { dg-final { scan-assembler {w. = \(s8\) w.\n} } } */ > +/* { dg-final { scan-assembler {w. = \(s16\) w.\n} } } */