From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id D8D4D3858434 for ; Thu, 5 May 2022 09:35:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D8D4D3858434 Received: by mail-wm1-x32c.google.com with SMTP id c190-20020a1c35c7000000b0038e37907b5bso4752502wma.0 for ; Thu, 05 May 2022 02:35:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Na+lWNKLVDy5oeWKVWcatZacwZo/JkoCWqe8JPzOuww=; b=KTPVEMwhSRGbMGmRCyT57+MgzjopxSSsNiey4msd/QXdmxKvjCQtYKz0z3yyvt59Jg pckDxxqoV/WcFjpzFLdG2mZ6O6JjoahTbD9IkZ8xPAuGP6jvudMg9ZwprU/qsV6aAwPl Ld69S6Wdzp2KNgXhbVc8EtYhxgtvyQDZuJGaCL516hvP4cuGObxz0GiaWhGjFEH/Q9cZ ZOm8UHfvFMiVyH5TWwqDyf77gX7ReokjISsPaSSRCNCH0roGnei7v+cgxJTaBO8TzBmk uPcj9Lq43nSLP2oYSrOve1rMgCYWmW6e6pULWNrTfm5x4eSG9KivBHWwgKdWPMlQeqoS 8mfg== X-Gm-Message-State: AOAM531BoaeGfbkJZ0QfpoaXjiHogORFGVwbY/6azMvk9rqwde0EYATZ qs6VumUYvMC3Sea4AjCW0BEnNKVl+6KJQA== X-Google-Smtp-Source: ABdhPJwDjr2hw8mtSdGs/wnmtoQ/ITaWwSKGswoAB/FmEHrXEVtcjvE2elJ7FwzVoft5rTAXTx/48Q== X-Received: by 2002:a05:600c:1c23:b0:394:55df:f03f with SMTP id j35-20020a05600c1c2300b0039455dff03fmr3659465wms.185.1651743354576; Thu, 05 May 2022 02:35:54 -0700 (PDT) Received: from poulhies-Precision-5550 (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id b9-20020a5d6349000000b0020c5253d8c3sm826234wrw.15.2022.05.05.02.35.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 02:35:54 -0700 (PDT) From: Marc Poulhies To: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] testsuite: add missing dg-require-effective-target fpic References: <20220331142835.1187460-1-poulhies@adacore.com> Date: Thu, 05 May 2022 11:35:53 +0200 In-Reply-To: <20220331142835.1187460-1-poulhies@adacore.com> ("Marc =?utf-8?Q?Poulhi=C3=A8s=22's?= message of "Thu, 31 Mar 2022 16:28:35 +0200") Message-ID: <87czgstj7q.fsf@adacore.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2022 09:35:57 -0000 Marc Poulhi=C3=A8s writes: > Require effective target fpic for newly added test. > > gcc/testsuite/ > * g++.dg/ext/visibility/visibility-local-extern1.C: Add missing > dg-require-effective-target fpic. > > Tested on x86_64-linux. Ok for master? > > --- > gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1= .C b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C > index 40c20199d0c..6fb1cc7f381 100644 > --- a/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C > +++ b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C > @@ -1,6 +1,7 @@ > // PR c++/103291 > // { dg-additional-options -fpic } > // { dg-final { scan-assembler-not "@GOTPCREL" } } > +// { dg-require-effective-target fpic } >=20=20 > #pragma GCC visibility push(hidden) ping ? Marc