From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 705953858C2D for ; Fri, 25 Mar 2022 12:35:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 705953858C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,209,1643702400"; d="scan'208";a="73648895" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 25 Mar 2022 04:35:10 -0800 IronPort-SDR: xht+416ZwaRgtor/wIbDJ2f6e2aMloS8S+SHEEZYJHSq0WxIZ3ny9517Ck5haXnXzBSUkSE6Un aihkV82zRjTgjVtMNyhF0UVgJ4l7tjH4fo8wlUs7D+yOvur/A0BYr7x5Is9mkW7QLgukUPs3/B 6YRKVsxNfE+SzEWFDA8LfhbN0A6e5WfaQpTbdSGzhbGX4aMXbm0pnvN8C1EZwEUoXifjCtDCWF ffuzi2j21epkGacqEnLzYl/QcM7g4Cqs/xVhe0SAkwwbrVZViHIyxkY+45ePG771+mS3bHRGwN sF8= From: Thomas Schwinge To: Tom de Vries CC: Tobias Burnus , Jakub Jelinek , Subject: Re: [PATCH][libgomp, testsuite] Scale down some OpenACC test-cases In-Reply-To: References: <20220325091848.GA22359@delia.home> <40a25c58-630f-d36c-06e5-6ea0769d53ec@codesourcery.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Fri, 25 Mar 2022 13:35:02 +0100 Message-ID: <87cziab47d.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2022 12:35:12 -0000 Hi! On 2022-03-25T13:08:52+0100, Tom de Vries wrote: > On 3/25/22 11:04, Tobias Burnus wrote: >> On 25.03.22 10:27, Jakub Jelinek via Gcc-patches wrote: >>> On Fri, Mar 25, 2022 at 10:18:49AM +0100, Tom de Vries wrote: >>>> [...] >>>> Fix this by scaling down the failing test-cases. >>>> Tested on x86_64-linux with nvptx accelerator. >>>> [...] >>> Will defer to Thomas, as it is a purely OpenACC change. >>> >>> One way to do it is >>> /* { dg-additional-options "-DEXPENSIVE" { target run_expensive_tests >>> } } */ >>> and using >>> #ifdef EXPENSIVE >>> [...] >>> >>> For the Fortran test it would mean .F90 extension though... >> >> Alternative, use the "-cpp" flag in 'dg-additional-options', which also >> enables the C-pre-processor pre-processing in gfortran. > > Ack, updated patch accordingly. Not sure if this additional "complexity" is really necessary here: as far as I can tell, there's no actual rationale behind the original number of iterations, so it seems fine to unconditionally scale them down. I'd thus move forward with your original patch -- but won't object the 'run_expensive_tests' variant either; the latter is already used in a handful of other libgomp test cases. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955