From: Richard Sandiford <richard.sandiford@linaro.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Handle VEC_SERIES with both constant args in simplify_binary_operation
Date: Wed, 22 Nov 2017 13:07:00 -0000 [thread overview]
Message-ID: <87d14aqxka.fsf@linaro.org> (raw)
In-Reply-To: <20171122114056.GS14653@tucnak> (Jakub Jelinek's message of "Wed, 22 Nov 2017 12:40:56 +0100")
Jakub Jelinek <jakub@redhat.com> writes:
> Hi!
>
> I've noticed that if we construct a VEC_SERIES and later propagate
> constants into both arguments (could happen e.g. in DEBUG_INSNs, or
> during combine etc.) we don't simplify that.
>
> The following patch adds that, ok for trunk if it passes bootstrap/regtest?
>
> Or should it go into simplify_constant_binary_operation instead?
> In there it would better match the function name, on the other side
> it would slow down the function for quite a marginal case, because it
> doesn't have a big switch on code, but instead handles just a few cases
> if constant operand kinds vs. the mode.
>
> 2017-11-22 Jakub Jelinek <jakub@redhat.com>
>
> * simplify-rtx.c (simplify_binary_operation_1) <case VEC_SERIES>:
> Handle the case where both arguments are using gen_const_vec_series.
LGTM FWIW. Thanks for doing this.
Richard
prev parent reply other threads:[~2017-11-22 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 11:57 Jakub Jelinek
2017-11-22 13:07 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d14aqxka.fsf@linaro.org \
--to=richard.sandiford@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).