From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53029 invoked by alias); 22 Nov 2017 12:59:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 53020 invoked by uid 89); 22 Nov 2017 12:59:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:959 X-HELO: mail-wm0-f49.google.com Received: from mail-wm0-f49.google.com (HELO mail-wm0-f49.google.com) (74.125.82.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Nov 2017 12:59:12 +0000 Received: by mail-wm0-f49.google.com with SMTP id 128so9985987wmo.3 for ; Wed, 22 Nov 2017 04:59:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:mail-followup-to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version; bh=hJoq41HLUnXqLUP9qPzHc4O8aN5/NBDCdWzCClFvLao=; b=eC+2rlYT1x5dFKjv9rnCp0bnPPj3yl+CyzL4pmZ+zls8HBtCYMGh1Q7RuQkdfDq7Jo IWRj2iIJRL5lnLKsp11O0Qxeti911WkdrS5GZrn0g2oiMme2Z1yFjgiKnKg+DfvPvmGa bcwAlvLJj2HH4cXud2NuFpyj4d6MmAhS2EPF+/uRTBc0m8MZyJmTwTZy+fKiEUm24fQ7 ilkukdAYZtTKKR3amo/Q9bC79lZqdRQjLNmhAfyi3eOCn61I3zgwxqiL8sR8e5aGOufE znrmVNWyPkiPQqyQsEPcDg/FzEaKzVxL9CvPX1fV9IDvU4rvpdqUVbeLd3ECzQNerwOK L5Fg== X-Gm-Message-State: AJaThX5AhvQDSn9KVCIHBgAW1kGWm34jq31AGYJbn/E4EZWxLcUqMEgR mm39K2L1uL2ZNXE4S9gdiXHugHcfvTY= X-Google-Smtp-Source: AGs4zMYMgW1ksW7r2uPYjIHXPM1sFTKFMkc59mkjMEv2/2cS2wl+tOQUKzWSk5UqdHA/KZUIdnO+ZQ== X-Received: by 10.28.190.12 with SMTP id o12mr4041389wmf.148.1511355549993; Wed, 22 Nov 2017 04:59:09 -0800 (PST) Received: from localhost ([2.25.234.120]) by smtp.gmail.com with ESMTPSA id k9sm18385955wrk.88.2017.11.22.04.59.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Nov 2017 04:59:09 -0800 (PST) From: Richard Sandiford To: Jakub Jelinek Mail-Followup-To: Jakub Jelinek ,Richard Biener , gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org Cc: Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Handle VEC_SERIES with both constant args in simplify_binary_operation References: <20171122114056.GS14653@tucnak> Date: Wed, 22 Nov 2017 13:07:00 -0000 In-Reply-To: <20171122114056.GS14653@tucnak> (Jakub Jelinek's message of "Wed, 22 Nov 2017 12:40:56 +0100") Message-ID: <87d14aqxka.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-11/txt/msg02025.txt.bz2 Jakub Jelinek writes: > Hi! > > I've noticed that if we construct a VEC_SERIES and later propagate > constants into both arguments (could happen e.g. in DEBUG_INSNs, or > during combine etc.) we don't simplify that. > > The following patch adds that, ok for trunk if it passes bootstrap/regtest? > > Or should it go into simplify_constant_binary_operation instead? > In there it would better match the function name, on the other side > it would slow down the function for quite a marginal case, because it > doesn't have a big switch on code, but instead handles just a few cases > if constant operand kinds vs. the mode. > > 2017-11-22 Jakub Jelinek > > * simplify-rtx.c (simplify_binary_operation_1) : > Handle the case where both arguments are using gen_const_vec_series. LGTM FWIW. Thanks for doing this. Richard