From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129664 invoked by alias); 31 Mar 2017 15:05:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 129539 invoked by uid 89); 31 Mar 2017 15:05:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL,BAYES_00,FILL_THIS_FORM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:2946, reserved, H*r:PDT, ten X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Mar 2017 15:05:39 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1cty7N-0001wm-7O from Thomas_Schwinge@mentor.com ; Fri, 31 Mar 2017 08:05:37 -0700 Received: from tftp-cs (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.224.2; Fri, 31 Mar 2017 08:05:36 -0700 Received: by tftp-cs (Postfix, from userid 49978) id 71E2FC2325; Fri, 31 Mar 2017 08:05:36 -0700 (PDT) From: Thomas Schwinge To: Jakub Jelinek , Subject: Remove unused "default_kind" member from gcc/omp-low.c's "struct omp_context" User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 31 Mar 2017 15:06:00 -0000 Message-ID: <87d1cxfpvq.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2017-03/txt/msg01570.txt.bz2 Hi! It would appear that ever since the first version of gcc/omp-low.c got committed to GCC trunk (more than ten years ago), it extraced OpenMP default clause data that it doesn't actually use for anything. OK to commit the following cleanup to trunk in next stage 1? commit cd157ff348694009f4043b84f47de8c62774931f Author: Thomas Schwinge Date: Fri Mar 31 15:26:55 2017 +0200 Remove unused "default_kind" member from gcc/omp-low.c's "struct omp_co= ntext" =20=20=20=20 gcc/ * omp-low.c (struct omp_context): Remove "default_kind" member. Adjust all users. --- gcc/omp-low.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git gcc/omp-low.c gcc/omp-low.c index 253dc85..d794e00 100644 --- gcc/omp-low.c +++ gcc/omp-low.c @@ -112,10 +112,6 @@ struct omp_context otherwise. */ gimple *simt_stmt; =20 - /* What to do with variables with implicitly determined sharing - attributes. */ - enum omp_clause_default_kind default_kind; - /* Nesting depth of this context. Used to beautify error messages re invalid gotos. The outermost ctx is depth 1, with depth 0 being reserved for the main body of the function. */ @@ -1162,10 +1158,6 @@ scan_sharing_clauses (tree clauses, omp_context *ctx, install_var_field (decl, by_ref, 3, ctx); break; =20 - case OMP_CLAUSE_DEFAULT: - ctx->default_kind =3D OMP_CLAUSE_DEFAULT_KIND (c); - break; - case OMP_CLAUSE_FINAL: case OMP_CLAUSE_IF: case OMP_CLAUSE_NUM_THREADS: @@ -1332,6 +1324,7 @@ scan_sharing_clauses (tree clauses, omp_context *ctx, case OMP_CLAUSE_SEQ: case OMP_CLAUSE_TILE: case OMP_CLAUSE__SIMT_: + case OMP_CLAUSE_DEFAULT: break; =20 case OMP_CLAUSE_ALIGNED: @@ -1826,7 +1819,6 @@ scan_omp_parallel (gimple_stmt_iterator *gsi, omp_con= text *outer_ctx) if (taskreg_nesting_level > 1) ctx->is_nested =3D true; ctx->field_map =3D splay_tree_new (splay_tree_compare_pointers, 0, 0); - ctx->default_kind =3D OMP_CLAUSE_DEFAULT_SHARED; ctx->record_type =3D lang_hooks.types.make_type (RECORD_TYPE); name =3D create_tmp_var_name (".omp_data_s"); name =3D build_decl (gimple_location (stmt), @@ -1873,7 +1865,6 @@ scan_omp_task (gimple_stmt_iterator *gsi, omp_context= *outer_ctx) if (taskreg_nesting_level > 1) ctx->is_nested =3D true; ctx->field_map =3D splay_tree_new (splay_tree_compare_pointers, 0, 0); - ctx->default_kind =3D OMP_CLAUSE_DEFAULT_SHARED; ctx->record_type =3D lang_hooks.types.make_type (RECORD_TYPE); name =3D create_tmp_var_name (".omp_data_s"); name =3D build_decl (gimple_location (stmt), @@ -2360,7 +2351,6 @@ scan_omp_target (gomp_target *stmt, omp_context *oute= r_ctx) =20 ctx =3D new_omp_context (stmt, outer_ctx); ctx->field_map =3D splay_tree_new (splay_tree_compare_pointers, 0, 0); - ctx->default_kind =3D OMP_CLAUSE_DEFAULT_SHARED; ctx->record_type =3D lang_hooks.types.make_type (RECORD_TYPE); name =3D create_tmp_var_name (".omp_data_t"); name =3D build_decl (gimple_location (stmt), Gr=C3=BC=C3=9Fe Thomas