From: Thomas Schwinge <thomas@codesourcery.com>
To: Nathan Sidwell <nathan@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [gomp4] openacc default handling
Date: Mon, 03 Aug 2015 11:07:00 -0000 [thread overview]
Message-ID: <87d1z4ocjy.fsf@kepler.schwinge.homeip.net> (raw)
In-Reply-To: <55B95DFD.6090703@acm.org>
[-- Attachment #1: Type: text/plain, Size: 2444 bytes --]
Hi!
On Wed, 29 Jul 2015 19:13:01 -0400, Nathan Sidwell <nathan@acm.org> wrote:
> gcc/
> * gimplify.c (oacc_default_clause): Outer scope searching moved to
> omp_notice_variable.
> (omp_notice_variable): For OpenACC search enclosing scopes before
> applying default.
Committed to gomp-4_0-branch in r226495:
commit 9446d5a23e74653407f079188e8be4bc9343e15e
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Mon Aug 3 11:06:38 2015 +0000
Resolve bootstrap failure in oacc_default_clause
[...]/source-gcc/gcc/gimplify.c: In function 'unsigned int oacc_default_clause(gimplify_omp_ctx*, tree, bool, unsigned int)':
[...]/source-gcc/gcc/gimplify.c:5913:13: error: unused parameter 'in_code' [-Werror=unused-parameter]
bool in_code, unsigned flags)
^
Fixup for r226373.
gcc/
* gimplify.c (oacc_default_clause): Remove in_code formal
parameter. Adjust all users.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@226495 138bc75d-0d04-0410-961f-82ee72b054a4
---
gcc/ChangeLog.gomp | 5 +++++
gcc/gimplify.c | 5 ++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git gcc/ChangeLog.gomp gcc/ChangeLog.gomp
index 3b907ea..a30f6a3 100644
--- gcc/ChangeLog.gomp
+++ gcc/ChangeLog.gomp
@@ -1,3 +1,8 @@
+2015-08-03 Thomas Schwinge <thomas@codesourcery.com>
+
+ * gimplify.c (oacc_default_clause): Remove in_code formal
+ parameter. Adjust all users.
+
2015-08-02 Nathan Sidwell <nathan@codesourcery.com>
* omp-low.c (oacc_xform_on_device): New function.
diff --git gcc/gimplify.c gcc/gimplify.c
index 0f8011d..f74f842 100644
--- gcc/gimplify.c
+++ gcc/gimplify.c
@@ -5909,8 +5909,7 @@ device_resident_p (tree decl)
but not declared in an enclosing clause. */
static unsigned
-oacc_default_clause (struct gimplify_omp_ctx *ctx, tree decl,
- bool in_code, unsigned flags)
+oacc_default_clause (struct gimplify_omp_ctx *ctx, tree decl, unsigned flags)
{
switch (ctx->default_kind)
{
@@ -6036,7 +6035,7 @@ omp_notice_variable (struct gimplify_omp_ctx *ctx, tree decl, bool in_code)
}
if (is_oacc)
- flags = oacc_default_clause (ctx, decl, in_code, flags);
+ flags = oacc_default_clause (ctx, decl, flags);
else
flags |= GOVD_MAP;
Grüße,
Thomas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
prev parent reply other threads:[~2015-08-03 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 2:30 Nathan Sidwell
2015-08-03 11:07 ` Thomas Schwinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1z4ocjy.fsf@kepler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).