From: Dodji Seketeli <dodji@redhat.com>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>,
"fortran\@gcc.gnu.org List" <fortran@gcc.gnu.org>,
Tobias Burnus <burnus@net-b.de>
Subject: Re: [PATCH Fortran/Diagnostics] Move Fortran to common diagnostics machinery
Date: Fri, 08 Aug 2014 10:25:00 -0000 [thread overview]
Message-ID: <87d2cbs2ga.fsf@redhat.com> (raw)
In-Reply-To: <CAESRpQAAg8r10Eqw5G-0zXSp=DRv67Rv1KfxpnuQu6A0oiyNNQ@mail.gmail.com> ("Manuel \=\?utf-8\?B\?TMOzcGV6LUliw6HDsWV6Iidz\?\= message of "Wed, 6 Aug 2014 18:50:30 +0200")
Hello Manuel,
Manuel López-Ibáñez <lopezibanez@gmail.com> writes:
> 2014-08-03 Manuel López-Ibáñez <manu@gcc.gnu.org>
>
> PR fortran/44054
> c-family/
> * c-format.c: Handle Fortran flags.
> * diagnostic.c (build_message_string): Make it extern.
> * diagnostic.h (build_message_string): Make it extern.
Small nit; the diagnostic.[ch] files are in gcc/, not in c-family.
The language-agnostic diagnostic infrastructure changes otherwise look
OK to me.
Thanks.
--
Dodji
next prev parent reply other threads:[~2014-08-08 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 16:51 Manuel López-Ibáñez
2014-08-08 10:25 ` Dodji Seketeli [this message]
2014-08-14 20:10 ` Manuel López-Ibáñez
2014-08-15 13:29 ` Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2cbs2ga.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=lopezibanez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).