From: Tom Tromey <tromey@redhat.com>
To: Marc Glisse <marc.glisse@inria.fr>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: extern "C" fixes for sunCC
Date: Thu, 03 Jan 2013 17:28:00 -0000 [thread overview]
Message-ID: <87d2xm41nv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1301031651190.3722@laptop-mg.saclay.inria.fr> (Marc Glisse's message of "Thu, 3 Jan 2013 17:12:32 +0100 (CET)")
>>>>> "Marc" == Marc Glisse <marc.glisse@inria.fr> writes:
Marc> Do you prefer an other approach?
No, this is fine, just yucky.
Marc> Like this? (I'll test if approved, but I am not sure what was wrong
Marc> with the indentation and parentheses so it may be wrong again)
From the node 'Formatting' in the GCS:
Insert extra parentheses so that Emacs will indent the code properly.
For example, the following indentation looks nice if you do it by hand,
v = rup->ru_utime.tv_sec*1000 + rup->ru_utime.tv_usec/1000
+ rup->ru_stime.tv_sec*1000 + rup->ru_stime.tv_usec/1000;
but Emacs would alter it. Adding a set of parentheses produces
something that looks equally nice, and which Emacs will preserve:
v = (rup->ru_utime.tv_sec*1000 + rup->ru_utime.tv_usec/1000
+ rup->ru_stime.tv_sec*1000 + rup->ru_stime.tv_usec/1000);
The comments seem fine.
It is ok with the formatting fixed.
Tom
prev parent reply other threads:[~2013-01-03 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 21:40 Marc Glisse
2013-01-02 13:45 ` Marc Glisse
2013-01-02 14:09 ` Richard Biener
2013-01-03 15:44 ` Tom Tromey
2013-01-03 16:12 ` Marc Glisse
2013-01-03 17:28 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2xm41nv.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marc.glisse@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).