From: Richard Sandiford <richard@codesourcery.com>
To: Sandra Loosemore <sandra@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: PATCH: mips16 float and complex support
Date: Wed, 23 May 2007 07:59:00 -0000 [thread overview]
Message-ID: <87d50s3r90.fsf@firetop.home> (raw)
In-Reply-To: <46538D21.5020007@codesourcery.com> (Sandra Loosemore's message of "Tue, 22 May 2007 20:38:57 -0400")
Sandra Loosemore <sandra@codesourcery.com> writes:
> *************** function_arg (const CUMULATIVE_ARGS *cum
> *** 4032,4038 ****
> }
> }
>
> ! if (!info.fpr_p)
> return gen_rtx_REG (mode, GP_ARG_FIRST + info.reg_offset);
> else if (mips_abi == ABI_32 && TARGET_DOUBLE_FLOAT && info.reg_offset > 0)
> /* In o32, the second argument is always passed in $f14
> --- 4031,4037 ----
> }
> }
>
> ! if (!info.fpr_p || TARGET_MIPS16)
> return gen_rtx_REG (mode, GP_ARG_FIRST + info.reg_offset);
> else if (mips_abi == ABI_32 && TARGET_DOUBLE_FLOAT && info.reg_offset > 0)
> /* In o32, the second argument is always passed in $f14
Please move mips_arg_regno before this function and replace the above
if-else block with:
return mips_arg_regno (mode, TARGET_HARD_FLOAT);
> + /* Return a two-character string representing a function floating
> + point return mode, used to name MIPS16 function stubs. */
Nit, but: "floating point" -> "floating-point"? (Probably my fault.)
> + /* INFO describes an argument that is pased in a single register value.
> + Return the register it uses, assuming that FPRs are available if
> + HARD_FLOAT_P. */
"pased" -> "passed" and "single register" -> "single-register".
(Definitely my fault, sorry.)
OK with those changes. Thanks for putting so much effort into this.
Richard
next prev parent reply other threads:[~2007-05-23 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 0:37 Sandra Loosemore
2007-05-23 7:59 ` Richard Sandiford [this message]
2007-05-23 20:05 ` Sandra Loosemore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d50s3r90.fsf@firetop.home \
--to=richard@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).