From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-195515-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 22591 invoked by alias); 23 May 2007 07:59:17 -0000
Received: (qmail 22581 invoked by uid 22791); 23 May 2007 07:59:16 -0000
X-Spam-Check-By: sourceware.org
Received: from gateway.codesourcery.com (HELO gateway.codesourcery.com) (65.74.133.9)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 May 2007 07:59:13 +0000
Received: (qmail 27722 invoked by uid 1010); 23 May 2007 07:59:08 -0000
From: Richard Sandiford <richard@codesourcery.com>
To: Sandra Loosemore <sandra@codesourcery.com>
Mail-Followup-To: Sandra Loosemore <sandra@codesourcery.com>,GCC Patches <gcc-patches@gcc.gnu.org>, richard@codesourcery.com
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: PATCH:  mips16 float and complex support
References: <46538D21.5020007@codesourcery.com>
Date: Wed, 23 May 2007 07:59:00 -0000
In-Reply-To: <46538D21.5020007@codesourcery.com> (Sandra Loosemore's message 	of "Tue, 22 May 2007 20:38:57 -0400")
Message-ID: <87d50s3r90.fsf@firetop.home>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-05/txt/msg01531.txt.bz2

Sandra Loosemore <sandra@codesourcery.com> writes:
> *************** function_arg (const CUMULATIVE_ARGS *cum
> *** 4032,4038 ****
>   	}
>       }
>   
> !   if (!info.fpr_p)
>       return gen_rtx_REG (mode, GP_ARG_FIRST + info.reg_offset);
>     else if (mips_abi == ABI_32 && TARGET_DOUBLE_FLOAT && info.reg_offset > 0)
>       /* In o32, the second argument is always passed in $f14
> --- 4031,4037 ----
>   	}
>       }
>   
> !   if (!info.fpr_p || TARGET_MIPS16)
>       return gen_rtx_REG (mode, GP_ARG_FIRST + info.reg_offset);
>     else if (mips_abi == ABI_32 && TARGET_DOUBLE_FLOAT && info.reg_offset > 0)
>       /* In o32, the second argument is always passed in $f14

Please move mips_arg_regno before this function and replace the above
if-else block with:

  return mips_arg_regno (mode, TARGET_HARD_FLOAT);

> + /* Return a two-character string representing a function floating
> +    point return mode, used to name MIPS16 function stubs.  */

Nit, but: "floating point" -> "floating-point"?  (Probably my fault.)

> + /* INFO describes an argument that is pased in a single register value.
> +    Return the register it uses, assuming that FPRs are available if
> +    HARD_FLOAT_P.  */

"pased" -> "passed" and "single register" -> "single-register".
(Definitely my fault, sorry.)

OK with those changes.  Thanks for putting so much effort into this.

Richard