From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 77DBC384A40A for ; Thu, 21 Jan 2021 22:56:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 77DBC384A40A Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-VvZBsjb_NcK8SConfVLCtg-1; Thu, 21 Jan 2021 17:56:23 -0500 X-MC-Unique: VvZBsjb_NcK8SConfVLCtg-1 Received: by mail-qk1-f200.google.com with SMTP id e5so2759157qkn.2 for ; Thu, 21 Jan 2021 14:56:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5TUXSfukpB5SwyXtRTnD+kXjBsKhY1SQzprV+ap1MKg=; b=HKh0DN1+RtZTW7Z+Ilo73dk4G6PlXC7osSvE+SwylEfxSU3+WM7i40CsxfsAgPBdj1 j8S6L4GkFwWXo2Z8cd7fc8up+0G6925xfJ8TwRQ1mGUbpVFCDi7t9tr7GETdU/7Yf2u2 h+FTrYxsKTOVw2bEc/uJYVfvlCQnhP1fqs7entBtGqP6X0CLh9sjQa3o7blY/LQJ8gr7 MS6WR6ro33mLu5VN86/un+H/8JSFgVi3KAyOxUYeUM9PIvkub5TjltFA6NMGTPdmxbno tzcvFJ2HpiUYvqSbEQqTd+29/PxgzInBkzt5rtQaW2sbf6vOrJqC0TP0pHdBz3YbmeJK gKYA== X-Gm-Message-State: AOAM5331WDZ2dOA6J/MfZNeUxkQ8X+HzUTG27wzPQQXd4rctz8huOHdF 3IaCsYsrq3nLJB6Kmu4s7PH6ZBn5x0TIWWIb1R8+9C1U+Gm/SCxP98+8zWW8xW2s67BchMBlfoD Hg5Og75ph31hObxBvpeOk/IxJUi3UIApJ2nWA2tdubFPF3VEVwd6wHVvzsI44Mvsjqg== X-Received: by 2002:a37:a544:: with SMTP id o65mr2219765qke.238.1611269781776; Thu, 21 Jan 2021 14:56:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJwiJaKT5si4FSaE7sgz+k0i7BYAfK6xEt55u28A2gW+RDJQxF+uwsfL4qreLP4MMpCCtkqqdA== X-Received: by 2002:a37:a544:: with SMTP id o65mr2219744qke.238.1611269781459; Thu, 21 Jan 2021 14:56:21 -0800 (PST) Received: from [192.168.1.148] (209-6-216-142.s141.c3-0.smr-cbr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.216.142]) by smtp.gmail.com with ESMTPSA id l191sm4940983qke.7.2021.01.21.14.56.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 14:56:20 -0800 (PST) Subject: Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314] To: Anthony Sharp Cc: gcc-patches@gcc.gnu.org References: <8beca582-97eb-3e4c-1437-162ae896f031@redhat.com> <92edd773-5832-6371-4003-d29d1539202a@redhat.com> From: Jason Merrill Message-ID: <87dacae0-c835-1927-b93b-dce704275719@redhat.com> Date: Thu, 21 Jan 2021 17:56:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2021 22:56:26 -0000 On 1/21/21 2:28 PM, Anthony Sharp wrote: > Hi Jason, > > I've finally completed my copyright assignment form. I've attached it > to this email for reference. > >> You don't need write access to the main repository to use these commands >> on your local copy. One nice thing about git compared to svn is that >> you don't need to touch the server for anything but push and pull. >> >> Incidentally, how are you producing your patch? Maybe try git >> format-patch instead. > > The method I am using at the moment is the one Ranjit Mathew talks > about here: http://rmathew.com/articles/gcj/crpatch.html. Interesting. Yeah, that page is obsolete since the move to git. > It's my fault kind of - the official GCC webpage > (https://gcc.gnu.org/gitwrite.html) explaining how to do it is called > 'Read-write Git access' so I assumed it was only relevant for people > who have access to the repo, but I see that is not the case. Those pages could definitely be more clearly organized. > I've tried the git way of doing it and I'm attaching a new patch file > that (hopefully) is better this time. Basically what I did was what > you suggested: > > git pull > contrib/gcc-git-customization.sh > (make changes) > git add * > git gcc-commit-mklog > git gcc-commit-mklog --amend Why two gcc-comit-mklog? That would generate the log entries twice. You should also git gcc-verify at this point; for me, it complains about some of your header lines in the log. Your author line needs to start at the first column, and use "01" for January instead of just "1". The other explanatory lines can be omitted, in favor of: The commit message before the log entries should include your rationale for the patch (e.g. the first two paragraphs of your initial email). > git format-patch -1 master > > I also re-built the source just to make sure I hadn't messed anything > up. I re-ran the C++ regression tests using make check-c and make > check-c++. Whilst I did not do a before/after comparison of the > results, I checked the FAILs in gcc.sum and g++.sum and they all > looked like they had nothing to do with my code. All the code is the > same as before, so I'm thinking it should be fine (I just wanted to be > safe). Also checked against check_GNU_style.sh. > > Assuming that's all fine, as for the code itself, there might well be > some tweaks that could make it better, and so if that is the case then > please let me know. I'll look at the code soon. Thanks, Jason