From: Andi Kleen <ak@linux.intel.com>
To: gcc-patches@gcc.gnu.org
Cc: rguenther@suse.de, richard.earnshaw@arm.com, jakub@redhat.com,
jlaw@ventanamicro.com, josmyers@redhat.com, polacek@redhat.com
Subject: [PING] Re: Updated musttail patchkit
Date: Mon, 01 Jul 2024 09:23:00 -0700 [thread overview]
Message-ID: <87ed8dnkt7.fsf@linux.intel.com> (raw)
In-Reply-To: <20240622185557.1589179-1-ak@linux.intel.com> (Andi Kleen's message of "Sat, 22 Jun 2024 11:54:32 -0700")
Andi Kleen <ak@linux.intel.com> writes:
I wanted to ping this patch kit to add musttail support for C/C++,
to enable future python versions and other users and keep up with clang.
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/thread.html#655447
It unfortunately touches various different parts of the compiler.
All the previous feedback has been addressed, except for
- cannot make it a warning because that would defeat the purpose
- cannot move all of the checking to expand time (would be a whole
scale rewrite of the whole mechanism)
These are RTL level:
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655448.html
(got some feedback from the two Richards and Jakub earlier)
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655450.html
(got some feedback from Andrew)
C++:
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655449.html
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655451.html
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655453.html
(C++, already approved)
C:
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655452.html
(C, got some feedback from Joseph, but never got finally approved)
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655455.html
Unreviewed patches, touching both tree-ssa-tailcall and calls.c expand:
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655454.html
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655457.html
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655456.html
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655458.html
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655459.html
Thanks,
-Andi
> - Fix problems with encoding musttail in tree structure (Thanks Jakub and Jason)
> - Fixes a miscompilation that would break bootstrap with --enable-checking=release
> - Avoids a 0.8% compile time penalty at -O0 for the new musttail pass by using a cfun flag
> that is discovered by tree-cfg
> - Enables translation of musttail error messages
> - Further improves error reporting, avoiding "other reasons" error messages
> for various cases and reporting the correct error in others.
> - Adjusted the test suite to powerpc sibcall limitations
> - Addressed C++ review feedback
> - Improves dump file output
> - Improves the documentation
> - Some random cleanups
> - Rebased on trunk
>
> Tested full bootstrap on x86_64-linux and powerpc64le-linux, as well
> as a x86_64 LTO profiled bootstrap and some x86_64 testing with
> --enable-release=checking.
prev parent reply other threads:[~2024-07-01 16:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 18:54 Andi Kleen
2024-06-22 18:54 ` [PATCH v8 01/12] Improve must tail in RTL backend Andi Kleen
2024-06-22 18:54 ` [PATCH v8 02/12] Fix pro_and_epilogue for sibcalls at -O0 Andi Kleen
2024-06-22 18:54 ` [PATCH v8 03/12] Add a musttail generic attribute to the c-attribs table Andi Kleen
2024-06-22 18:54 ` [PATCH v8 04/12] C++: Support clang compatible [[musttail]] (PR83324) Andi Kleen
2024-06-22 18:54 ` [PATCH v8 05/12] C: Implement musttail attribute for returns Andi Kleen
2024-06-22 18:54 ` [PATCH v8 06/12] Add tests for C/C++ musttail attributes Andi Kleen
2024-06-22 18:54 ` [PATCH v8 07/12] Enable musttail tail conversion even when not optimizing Andi Kleen
2024-06-22 18:54 ` [PATCH v8 08/12] Give better error messages for musttail Andi Kleen
2024-06-22 18:54 ` [PATCH v8 09/12] Delay caller error reporting " Andi Kleen
2024-06-22 18:54 ` [PATCH v8 10/12] Add documentation for musttail attribute Andi Kleen
2024-06-22 18:54 ` [PATCH v8 11/12] Dump reason for missing tail call into dump file Andi Kleen
2024-06-22 18:54 ` [PATCH v8 12/12] Mark expand musttail error messages for translation Andi Kleen
2024-07-01 16:23 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed8dnkt7.fsf@linux.intel.com \
--to=ak@linux.intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jlaw@ventanamicro.com \
--cc=josmyers@redhat.com \
--cc=polacek@redhat.com \
--cc=rguenther@suse.de \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).