From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9AA4E384DED7 for ; Tue, 5 Dec 2023 11:00:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9AA4E384DED7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9AA4E384DED7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701774026; cv=none; b=T/iDSNcViWPM3Z9YW/T6vbHjIIPX/P6gpYk1iBcQUCdL7QgWBfphbwGtm/iSWI0PX2rCc5q0zvrF1nV8wTwiO8Ku56DPvZNMTVsOaP4g5LjkV7i5dL2A8kulgYh1QYDsz7PiNomPXOl7m09iv4RLNsGKJtudo3/ihYGutukEJII= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701774026; c=relaxed/simple; bh=WUhS5eAe0tRGzsuzkO9DXXgiRCd3LVuhRX3roBvHRWU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YokmwljXRAvVsKFEc1QjHo2goHlPUb8W/7uADOlIvsbIo2NMIQq1Rb977Yc2ApGr+Mf6h+R+P1YfgIu8tRhpZj47pTNQ4sRi/084Gx4ULGYos9KEnkzWiqlIqT7+4cnY7bsY3lSz8Xr3ODtWMz70fO8CLnHz/jBW8UQPNDqXzj8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701774025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7psQc0drIUJjNtULuzTlLUT5H7gl8FC/AvXyu1KDbJM=; b=Cmf+EzxI/R3ZDz0/QVyZsTLdO1DJ82BBmhaCzoEoyuMUNcW4WV7zR8k1X3WpRaVxBnaONm luuVY98hAAMnZGF0gOu6A3C69+3GauuLBuNuzc2DdDcFvoPXi+VSsDHVDUb6hmWlsLzGfQ 7juDY5eLjwLPrOn0TKYlozoIGswzlU8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-232-NpZPHuBJOiWwf3gUdDLKPg-1; Tue, 05 Dec 2023 06:00:22 -0500 X-MC-Unique: NpZPHuBJOiWwf3gUdDLKPg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DBF5010B9349; Tue, 5 Dec 2023 11:00:21 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACC7B2166B31; Tue, 5 Dec 2023 11:00:20 +0000 (UTC) From: Florian Weimer To: Richard Earnshaw Cc: Jakub Jelinek , Tobias Burnus , gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: [PATCH] libgfortran: Fix -Wincompatible-pointer-types errors References: <9e40a64880a14cf27d788ecbaf23365b9a5ac069.1700473918.git.fweimer@redhat.com> <87zfypvv6t.fsf@oldenburg.str.redhat.com> <8ba09ce2-9b19-4fd2-9d3a-01c4add02c91@foss.arm.com> <55c954b8-65c3-4df2-ac76-1ab77f42006f@foss.arm.com> Date: Tue, 05 Dec 2023 12:00:19 +0100 In-Reply-To: <55c954b8-65c3-4df2-ac76-1ab77f42006f@foss.arm.com> (Richard Earnshaw's message of "Tue, 5 Dec 2023 10:57:50 +0000") Message-ID: <87edg0x6bg.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Richard Earnshaw: > On 05/12/2023 10:51, Jakub Jelinek wrote: >> On Tue, Dec 05, 2023 at 10:47:34AM +0000, Richard Earnshaw wrote: >>>> The following patch makes libgfortran build on i686-linux after hacking up >>>> --- kinds.h.xx 2023-12-05 00:23:00.133365064 +0100 >>>> +++ kinds.h 2023-12-05 11:19:24.409679808 +0100 >>>> @@ -10,8 +10,8 @@ typedef GFC_INTEGER_2 GFC_LOGICAL_2; >>>> #define HAVE_GFC_LOGICAL_2 >>>> #define HAVE_GFC_INTEGER_2 >>>> -typedef int32_t GFC_INTEGER_4; >>>> -typedef uint32_t GFC_UINTEGER_4; >>>> +typedef long GFC_INTEGER_4; >>>> +typedef unsigned long GFC_UINTEGER_4; >>> >>> That doesn't look right for a 64-bit processor. Presumably 4 means 4 bytes, >> i686-linux is an ILP32 target, which I chose exactly because I >> regularly build >> it, had a tree with it around and because unlike 64-bit targets there are 2 >> standard 32-bit signed integer types. Though, normally int32_t there is >> int rather than long int and so the errors only appeared after this hack. >> > > My point is that on aarch64/x86_64 etc, this will make GFC_INTEGER_4 a > 64-bit type, whereas previously it was 32-bit. I think it's not part of the submission, it was for local testing only. It confused me as well. 8-) Thanks, Florian