From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id F1B4C3858D1E for ; Sat, 11 Nov 2023 14:49:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1B4C3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F1B4C3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.129.153 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699714174; cv=none; b=r4+2sJ1FqLmt87iATU80aK2r57s61sZZV4y84Vcl3nfRDp3E1YF3QpFq5wZpmSVKOLYwQkTszSqvPWdru8Xldv5fK66Bg6opA2mdvWOUDNoAoPqrsear0b3LNYryNiBiZfwKhxAzA8sdiV2X9nOkpjlnng/LWawlTqx48KFxvwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699714174; c=relaxed/simple; bh=FNjbmZGhxPkWepBEqVAEmCivuyB7wndSb1PDAeNQaYk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=KRPhpa4OMrGBXOpUsZKT2RNYHCK5Kl5v4uIbXW9uk49UtGoNPBjruWJ2X1GR7+miI88KHm6hZSB9EK1IG0bN7q0+IUlzqA5eNLv8a0or0ygUJfNPiJKMEmaZZGrwYH24OaSiYjmd23rMqt0obkX2at2c3+DpKBDqXuM3WOqZ3UE= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: VfF+EypYT0SiCSyY57YtPA== X-CSE-MsgGUID: JNzJemwtQTGS2qmpzJpxvw== X-IronPort-AV: E=Sophos;i="6.03,295,1694764800"; d="scan'208";a="25472772" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 11 Nov 2023 06:49:30 -0800 IronPort-SDR: vxB0DgvgyEhqxnICO1xfmcOlaPvKR33twZKo+jxTTmFJozpi9h/P0zOnykQO/3urcUKkO9gLSE Ce+TO5ws8t+PilEr5Lt3am8cQDSL9ciTmZh8e48pwfj/WJyElCBCofQmOeDKhbz9YX6sKQIEXz YhfuszioK6XtSma5tO3RvtwEf4JjlDHLyseirPH1FBlXPhw/4XaFzTxN7uCd7ViW3g+yegxqvB 3XzJY4DqF/V1KXcYnC5kYHMG1dNOGaCKv6vVAyO6BHszmT5Nhw/uTmgUBH7QGl0xw8NiryHwbF xa4= From: Thomas Schwinge To: Alexandre Oliva CC: , Richard Biener Subject: Re: [PATCH] testsuite: xfail scev-[35].c on ia32 In-Reply-To: References: User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Sat, 11 Nov 2023 15:49:22 +0100 Message-ID: <87edgwuyz1.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_NUMSUBJECT,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2023-11-08T13:01:47-0300, Alexandre Oliva wrote: > These gimplefe tests never got the desired optimization on ia32, but > they only started visibly failing when the representation of MEMs in > dumps changed from printing 'symbol: a' to '&a'. ACK -- but why not likewise "fix" the 'gcc.dg/tree-ssa/scev-4.c' FAIL? PASS: gcc.dg/tree-ssa/scev-3.c (test for excess errors) [-FAIL:-]{+XFAIL:+} gcc.dg/tree-ssa/scev-3.c scan-tree-dump-times ivopt= s "&a" 1 PASS: gcc.dg/tree-ssa/scev-4.c (test for excess errors) FAIL: gcc.dg/tree-ssa/scev-4.c scan-tree-dump-times ivopts "&a" 1 PASS: gcc.dg/tree-ssa/scev-5.c (test for excess errors) [-FAIL:-]{+XFAIL:+} gcc.dg/tree-ssa/scev-5.c scan-tree-dump-times ivopt= s "&a" 1 Gr=C3=BC=C3=9Fe Thomas > The transformation is not considered profitable on ia32, that's why it > doesn't take place. Maybe that's a bug in itself, but it's not a > regression, and not something to be noisy about. > > Regstrapped on x86_64-linux-gnu, also tested with gcc-13 on i686- and > x86_64-. Ok to install? > > (Richi, is the non-optimization choice on ia32 something unexpected that > ought to be looked into? I could file a PR, and maybe even look into it > a bit further.) > > > for gcc/testsuite/ChangeLog > > * gcc.dg/tree-ssa/scev-3.c: xfail on ia32. > * gcc.dg/tree-ssa/scev-5.c: Likewise. > > Issue: gcc#155 > TN: W517-007 > --- > gcc/testsuite/gcc.dg/tree-ssa/scev-3.c | 2 +- > gcc/testsuite/gcc.dg/tree-ssa/scev-5.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c b/gcc/testsuite/gcc.d= g/tree-ssa/scev-3.c > index 4babd33f5c062..ac8c8d4519e30 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c > @@ -40,4 +40,4 @@ __BB(6): > > } > > -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" } } */ > +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } = */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c b/gcc/testsuite/gcc.d= g/tree-ssa/scev-5.c > index c2feebdfc2489..c911a9298866f 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c > @@ -40,4 +40,4 @@ __BB(6): > > } > > -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" } } */ > +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } = */ > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > More tolerance and less prejudice are key for inclusion and diversity > Excluding neuro-others for not behaving ""normal"" is *not* inclusive ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955