Hi! On 2022-07-10T16:51:11-0400, Lewis Hyatt via Gcc-patches wrote: > On Sat, Jul 9, 2022 at 11:59 PM Jeff Law via Gcc-patches > wrote: >> On 7/9/2022 2:52 PM, Lewis Hyatt via Gcc-patches wrote: >> > PR97498 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97498) is another PR >> > related to the fact that imprecise locations for _Pragma result in >> > counterintuitive behavior for GCC diagnostic pragmas >> > I think the main source of problems for all remaining issues is that we use >> > the global input_location for deciding when/if a diagnostic should apply. I >> > think it should be eventually doable to eliminate this, and rather properly >> > resolve the token locations to the place they need to be >> I've long wanted to see our dependency on input_location be diminished >> with the goal of making it go away completely. > [...] > Then I will plan to work on > eliminating input_location from c-pragma.cc as a longer term goal. Great; I too am looking forward to that. There, and then elsewhere, everywhere. :-) >> > The rest of [patch] is just tweaking a couple tests which were sensitive to the >> > location being output. In all these cases, the new locations seem more >> > informative to me than the old ones. ACK, thanks. On top of that, I've just pushed to master branch commit 06b2a2abe26554c6f9365676683d67368cbba206 "Enhance '_Pragma' diagnostics verification in OMP C/C++ test cases", see attached. Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955