Re: [1/3] OpenACC reductions

[Thomas Schwinge <thomas@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]

Hi!

On 2015-11-02T11:18:37-0500, Nathan Sidwell <nathan@acm.org> wrote:
> This is the core execution bits of OpenACC reductions.
>
> We have a new internal fn 'IFN_GOACC_REDUCTION' and a new target hook
> goacc.reduction, to lower it on the target compiler.

Yay for proper abstraction!  Long ago committed in r229767 (Git
commit e50146711b7200e8f822c6d8239430c682b76e4f).

> The omp-low changes are:
> 1) remove all the existing OpenACC reduction handling

One more:

> --- gcc/omp-low.c     (revision 229667)
> +++ gcc/omp-low.c     (working copy)

> -[...]
> -       /* Determine if this is kernel will be executed on the host.  */
> -       call = builtin_decl_explicit (BUILT_IN_ACC_GET_DEVICE_TYPE);
> -[...]

Pushed "[OpenACC] Clean up unused 'BUILT_IN_ACC_GET_DEVICE_TYPE'" to
master branch in commit 06870af3e48daf523a973981f053ee5c6f44c871, see
attached.


Grüße
 Thomas


-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-OpenACC-Clean-up-unused-BUILT_IN_ACC_GET_DEVICE_TYPE.patch --]
[-- Type: text/x-diff, Size: 1101 bytes --]

From 06870af3e48daf523a973981f053ee5c6f44c871 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <thomas@codesourcery.com>
Date: Mon, 2 Aug 2021 18:34:47 +0200
Subject: [PATCH] [OpenACC] Clean up unused 'BUILT_IN_ACC_GET_DEVICE_TYPE'

Unused as of r229767 (Git commit e50146711b7200e8f822c6d8239430c682b76e4f)
"OpenACC reductions".

	gcc/
	* omp-builtins.def (BUILT_IN_ACC_GET_DEVICE_TYPE): Remove.
---
 gcc/omp-builtins.def | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gcc/omp-builtins.def b/gcc/omp-builtins.def
index 97964f866ec..4a7e7badd7e 100644
--- a/gcc/omp-builtins.def
+++ b/gcc/omp-builtins.def
@@ -29,8 +29,6 @@ along with GCC; see the file COPYING3.  If not see
 /* The reason why they aren't in gcc/builtins.def is that the Fortran front end
    doesn't source those.  */
 
-DEF_GOACC_BUILTIN (BUILT_IN_ACC_GET_DEVICE_TYPE, "acc_get_device_type",
-		   BT_FN_INT, ATTR_NOTHROW_LIST)
 DEF_GOACC_BUILTIN (BUILT_IN_GOACC_DATA_START, "GOACC_data_start",
 		   BT_FN_VOID_INT_SIZE_PTR_PTR_PTR, ATTR_NOTHROW_LIST)
 DEF_GOACC_BUILTIN (BUILT_IN_GOACC_DATA_END, "GOACC_data_end",
-- 
2.30.2