From: Andi Kleen <ak@linux.intel.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] gcov: Use system IO buffering
Date: Thu, 22 Apr 2021 09:57:23 -0700 [thread overview]
Message-ID: <87eef2uuj0.fsf@linux.intel.com> (raw)
In-Reply-To: <e5a625db-dd5e-aee7-8a07-85d1700ec88f@suse.cz> ("Martin =?utf-8?Q?Li=C5=A1ka=22's?= message of "Wed, 21 Apr 2021 09:52:13 +0200")
Martin Liška <mliska@suse.cz> writes:
> Hey.
>
> I/O buffering in gcov seems duplicite to what modern C library can provide.
> The patch is a simplification and can provide easier interface for system
> that don't have a filesystem and would like using GCOV.
>
> I'm going to install the patch after 11.1 if there are no objections.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
What happens if someone compiles the C library with gcov?
Being as self contained as possible (only system calls) would seem
safer.
-Andi
next prev parent reply other threads:[~2021-04-22 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 7:52 Martin Liška
2021-04-22 16:57 ` Andi Kleen [this message]
2021-04-23 6:49 ` Richard Biener
2021-04-23 9:24 ` Martin Liška
2021-04-23 9:44 ` Richard Biener
2021-04-23 11:54 ` Martin Liška
2021-06-17 1:59 ` [EXTERNAL] " Eugene Rozenfeld
2021-06-17 9:37 ` Martin Liška
2021-06-17 16:21 ` Eugene Rozenfeld
2021-06-22 6:56 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eef2uuj0.fsf@linux.intel.com \
--to=ak@linux.intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).